[Money2020] Adding in activation flow for money20/20 #29288

Beamanator · 2023-10-11T12:10:10Z

cc @MariaHCD in case you want to review!

Details

This is going to be the entry point for attendees of the money2020 conference. They'll either click on a new.expensify.com/money2020 link, or scan a QR code that leads to that same page.

The goal is for them to be able to click or scan, log in if they're not already, then seamlessly be navigated to a chat w/ [email protected] which should be pre-populated with a welcome message whisper

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/324577

Tests

Use staging server to test this today (Friday, Oct 13)

In NewDot, sign out
Manually navigate to /money2020
Sign in with a brand new account
Verify CreateChatReport gets called only once (In Console -> Network tab)
Verify you're automatically navigated to a new chat report, between your account & [email protected]
Verify you automatically see a whisper message with a welcome message like this:

Type a message in the chat, verify it works as expected
Manually navigate to /money2020 again
Verify you don't see another CreateChatReport call, since you already have that chat loaded in Onyx
Navigate to the Concierge report
Manually navigate to /money2020 again
Verify you're taken back to the chat w/ [email protected]

Verify that no errors appear in the JS console

Offline tests

N/A (user needs to be online for all of theses)

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Deep linking not available, so won't be possible to route to /money2020 without clicking on a chat link

cloudflare-workers-and-pages · 2023-10-11T12:12:55Z

Deploying with Cloudflare Pages

Latest commit:	`7044381`
Status:	✅ Deploy successful!
Preview URL:	https://dc967136.helpdot.pages.dev
Branch Preview URL:	https://beaman-activationflowmoney20.helpdot.pages.dev

View logs

…nFlowMoney2020

melvin-bot · 2023-10-13T12:05:12Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-10-13T15:29:38Z

src/pages/DemoSetupPage.js

-function DemoSetupPage() {
-    useFocusEffect(() => {
-        Navigation.isNavigationReady().then(() => {
-            Navigation.goBack(ROUTES.HOME);
-        });
-    });
+function DemoSetupPage(props) {
+    useFocusEffect(
+        useCallback(() => {


NAB. But is there any specific reason why we are no longer using the navigation promise?

I looked around at other similar implementations and noticed we don't use it anymore - and we were somehow getting inside this call twice which called CreateChatReport twice, but without that function we only get there once 🤷

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

s77rt · 2023-10-13T15:34:56Z

Verify you automatically see a whisper message with a welcome message like this:

I don't see any welcome message

Co-authored-by: Abdelhafidh Belalia <[email protected]>

Beamanator · 2023-10-13T15:39:21Z

Hmmmm are you testing on staging?

…

On Fri, Oct 13, 2023 at 6:35 PM Abdelhafidh Belalia < ***@***.***> wrote: Verify you automatically see a whisper message with a welcome message like this: I don't see any welcome message [image: Screenshot 2023-10-13 at 4 34 36 PM] <https://user-images.githubusercontent.com/16493223/274946733-1a1abc30-f886-4060-b6d8-27105a83fd8a.png> — Reply to this email directly, view it on GitHub <#29288 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5UTP4HQRKZ4E45H4Q7TXTX7FNSZAVCNFSM6AAAAAA534LYTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRG4YTKOBZGA> . You are receiving this because you were assigned.Message ID: ***@***.***>

s77rt · 2023-10-13T15:39:58Z

oh! my bad sorry let me test again

s77rt · 2023-10-13T15:49:28Z

Yeah working well 😁

s77rt · 2023-10-13T16:24:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-1.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-10-13T16:26:42Z

@chiragsalian Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-10-13T16:26:46Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29577.

OSBotify · 2023-10-16T07:29:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:48:57Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:13:43Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T00:00:06Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:57:36Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Adding in activation flow for money2020

833cc72

Beamanator self-assigned this Oct 11, 2023

Beamanator changed the title ~~Adding in activation flow for money20/20~~ [Money2020] Adding in activation flow for money20/20 Oct 11, 2023

Beamanator added 9 commits October 11, 2023 17:13

Add in needed imports

4d7e665

Fix up demo action

1841896

Fix existing report route logic

d96a807

Fix double-triggering demo flow

55119bd

Address lint issues

aaab625

I guess this belongs here

c343630

prettier didn't like... something

bb922d8

Merge branch 'main' of github.com:Expensify/App into beaman-activatio…

0a3ce76

…nFlowMoney2020

Add money2020 deep link

1681974

Beamanator marked this pull request as ready for review October 13, 2023 12:05

Beamanator requested a review from a team as a code owner October 13, 2023 12:05

melvin-bot bot requested review from s77rt and removed request for a team October 13, 2023 12:05

s77rt suggested changes Oct 13, 2023

View reviewed changes

Remove old code

7044381

Co-authored-by: Abdelhafidh Belalia <[email protected]>

s77rt approved these changes Oct 13, 2023

View reviewed changes

melvin-bot bot requested a review from chiragsalian October 13, 2023 16:26

melvin-bot bot mentioned this pull request Oct 13, 2023

Payment issue for E/App PR#29288 #29577

Closed

MariaHCD approved these changes Oct 16, 2023

View reviewed changes

MariaHCD merged commit 7d08e23 into main Oct 16, 2023
15 checks passed

MariaHCD deleted the beaman-activationFlowMoney2020 branch October 16, 2023 07:23

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

izarutskaya mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] [$500] Web - Chat - CreateChatReport is called (API call) even though chat is already created #29747

Closed

6 tasks

francoisl mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807

Closed

6 tasks

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Money2020] Adding in activation flow for money20/20 #29288

[Money2020] Adding in activation flow for money20/20 #29288

Beamanator commented Oct 11, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2023 •

edited

Loading

melvin-bot bot commented Oct 13, 2023

s77rt Oct 13, 2023

Beamanator Oct 13, 2023

s77rt commented Oct 13, 2023

Beamanator commented Oct 13, 2023 via email

s77rt commented Oct 13, 2023

s77rt commented Oct 13, 2023

s77rt commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

[Money2020] Adding in activation flow for money20/20 #29288

[Money2020] Adding in activation flow for money20/20 #29288

Conversation

Beamanator commented Oct 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

cloudflare-workers-and-pages bot commented Oct 11, 2023 • edited Loading

Deploying with Cloudflare Pages

melvin-bot bot commented Oct 13, 2023

s77rt Oct 13, 2023

Choose a reason for hiding this comment

Beamanator Oct 13, 2023

Choose a reason for hiding this comment

s77rt commented Oct 13, 2023

Beamanator commented Oct 13, 2023 via email

s77rt commented Oct 13, 2023

s77rt commented Oct 13, 2023

s77rt commented Oct 13, 2023

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

Beamanator commented Oct 11, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Oct 11, 2023 •

edited

Loading