Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

kowczarz · 2023-10-09T15:22:03Z

Details

Fixed Issues

$ #28879
$ #28871
$ #28878

Tests

Birthday:

Log in
Navigate to Settings > Profile > Personal details
Change birthday date

New money request:

Log in
Open chat with existing user
Click + icon > Request money
Set amount > press Next
Press Show more > press Date
Change date and press Save
Request the given amount

New money request:

Log in
Open chat with existing user from whom you have already requested some money
Click on money request
Press Date
Change date and press Save

Verify that no errors appear in the JS console

Offline tests

Birthday:

Log in
Navigate to personal details
Change birthday date

New money request:

Log in
Open chat with existing user
Click + icon > Request money
Set amount > press Next
Press Show more > press Date
Change date and press Save
Request the given amount

New money request:

Log in
Open chat with existing user from whom you have already requested some money
Click on money request
Press Date
Change date and press Save

QA Steps

Birthday:

Log in
Cavigate to personal details
Change birthday date

New money request:

Log in
Open chat with existing user
Click + icon > Request money
Set amount > press Next
Press Show more > press Date
Change date and press Save
Request the given amount

New money request:

Log in
Open chat with existing user from whom you have already requested some money
Click on money request
Press Date
Change date and press Save

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.new_H.265.mp4

android.edit_H.265.mp4

android.bday_H.265.mp4

Android: mWeb Chrome

android.web.bday_H.265.mp4

android.web.edit_H.265.mp4

android.web.new_H.265.mp4

iOS: Native

ios.native.edit.request_H.265.mp4

ios.native.bday_H.265.mp4

ios.native.new.request_H.265.mp4

iOS: mWeb Safari

ios.web.bday_H.265.mp4

ios.web.new_H.265.mp4

ios.native.bday_H.265.mp4

MacOS: Chrome / Safari

web.bday_H.265.mp4

web.edit_H.265.mp4

web.new_H.265.mp4

MacOS: Desktop

desktop.new_H.265.mp4

desktop.edit_H.265.mp4

desktop.bday_H.265.mp4

melvin-bot · 2023-10-11T10:10:13Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-11T13:59:09Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-10-11T14:05:26Z

Cc @luacmartins

luacmartins · 2023-10-11T15:59:54Z

@mananjadhav @aimane-chnaif @allroundexperts any of you available to review this now? I tagged you because you are assigned to the issues, but we combined all 3 issues into a single PR.

aimane-chnaif · 2023-10-11T16:00:28Z

available

aimane-chnaif · 2023-10-11T16:01:55Z

@kowczarz please update Fixed Issues section like this:

$ https://github.com/Expensify/App/issues/28871
$ https://github.com/Expensify/App/issues/28878
$ https://github.com/Expensify/App/issues/28879

luacmartins · 2023-10-11T16:04:00Z

Awesome! Assigned you for review @aimane-chnaif. Thank you so much! I also updated the OP with the Fixed issues format above

luacmartins

Looking good. Left a comment

src/components/NewDatePicker/index.js

aimane-chnaif · 2023-10-11T16:41:11Z

Please pull main

…t-request-created-page

kowczarz · 2023-10-11T16:44:15Z

@aimane-chnaif done ✅

aimane-chnaif · 2023-10-11T16:54:22Z

Cavigate to personal details

update this to

Navigate to Settings > Profile > Personal details

kowczarz · 2023-10-11T16:55:50Z

Done

aimane-chnaif · 2023-10-11T18:31:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif · 2023-10-11T18:32:14Z

Cavigate to personal details

update this to

Navigate to Settings > Profile > Personal details

This typo still exists in Offline / QA Steps 😆

aimane-chnaif

LGTM 🎉

OSBotify · 2023-10-13T21:56:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:08:56Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:25:10Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:00:34Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

s77rt · 2023-12-22T22:09:07Z

src/components/NewDatePicker/index.js

We should not have used InputWrapper here as it "hides" the NewDataPicker's changes from the FormProvider. Instead we should have used InputWrapper to wrap the whole component and not just the TextInput. More info: #31401 (comment). (Coming from #31612)

kowczarz added 2 commits October 9, 2023 17:20

Migrate NewDatePicker

b5975f7

Migrate EditRequestCreatedPage

5b09cc0

kowczarz added 4 commits October 10, 2023 16:19

Fix newDatePicker

b2b0518

Rewrite MoneyRequestDatePage.js to new form

7dbb5bb

Rewrite DateOfBirthPage to new form

c5491b6

Fix from validation

448d193

Lint fixes

c2e85ac

kowczarz marked this pull request as ready for review October 11, 2023 13:58

kowczarz requested a review from a team as a code owner October 11, 2023 13:58

melvin-bot bot removed the request for review from a team October 11, 2023 13:59

melvin-bot bot requested a review from neil-marcellini October 11, 2023 13:59

luacmartins self-requested a review October 11, 2023 15:58

luacmartins assigned kowczarz Oct 11, 2023

luacmartins changed the title ~~Form migration~~ Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage Oct 11, 2023

luacmartins requested a review from aimane-chnaif October 11, 2023 16:03

luacmartins reviewed Oct 11, 2023

View reviewed changes

src/components/NewDatePicker/index.js Outdated Show resolved Hide resolved

Code review changes

1664d66

aimane-chnaif reviewed Oct 11, 2023

View reviewed changes

src/components/NewDatePicker/index.js Outdated Show resolved Hide resolved

Destructure props

4fd5594

kowczarz requested review from aimane-chnaif and luacmartins October 11, 2023 16:40

Merge remote-tracking branch 'expensify/main' into form-migration/edi…

afb0282

…t-request-created-page

aimane-chnaif approved these changes Oct 11, 2023

View reviewed changes

luacmartins approved these changes Oct 11, 2023

View reviewed changes

luacmartins removed the request for review from neil-marcellini October 11, 2023 18:34

luacmartins merged commit bbb5728 into Expensify:main Oct 11, 2023
16 checks passed

mountiny mentioned this pull request Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

melvin-bot bot mentioned this pull request Oct 13, 2023

[HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] DateOfBirthPage #28871

Closed

luacmartins mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] NewContactMethodPage #28874

Closed

kowczarz mentioned this pull request Oct 20, 2023

[Form Provider Refactor] MoneyRequestDatePage #30007

Closed

This was referenced Nov 23, 2023

[Form Provider Refactor] IdologyQuestions #31401

Merged

[HOLD for payment 2023-12-28] [$500] BA - Personal information / Beneficial Form entered offline isn't saved after returning online #31612

Closed

s77rt reviewed Dec 22, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

kowczarz commented Oct 9, 2023 •

edited by luacmartins

Loading

melvin-bot bot commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

kowczarz commented Oct 11, 2023

luacmartins commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023 •

edited

Loading

luacmartins commented Oct 11, 2023 •

edited

Loading

luacmartins left a comment

aimane-chnaif commented Oct 11, 2023

kowczarz commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

kowczarz commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

aimane-chnaif left a comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

s77rt Dec 22, 2023

Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

Conversation

kowczarz commented Oct 9, 2023 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2023

melvin-bot bot commented Oct 11, 2023

kowczarz commented Oct 11, 2023

luacmartins commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023 • edited Loading

luacmartins commented Oct 11, 2023 • edited Loading

luacmartins left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Oct 11, 2023

kowczarz commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

kowczarz commented Oct 11, 2023

aimane-chnaif commented Oct 11, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif commented Oct 11, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

s77rt Dec 22, 2023

Choose a reason for hiding this comment

kowczarz commented Oct 9, 2023 •

edited by luacmartins

Loading

aimane-chnaif commented Oct 11, 2023 •

edited

Loading

luacmartins commented Oct 11, 2023 •

edited

Loading