Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cursor default when menu can not clickable #28973

Conversation

namhihi237
Copy link
Contributor

@namhihi237 namhihi237 commented Oct 6, 2023

Details

Fix the show cursor default when the menu item can not clickable.

Fixed Issues

$ #28565
PROPOSAL: #28565 (comment)

Tests

  1. Open Setting => Share code
  2. Click "Copy URL to clipboard"
  3. Message ""Copied!" appears, hover over it,verify that pointer default appears
  • Verify that no errors appear in the JS console

Offline tests

The same test

QA Steps

The same test

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
web.mov
Mobile Web - Chrome
mweb.mov
Mobile Web - Safari
safari.mov
Desktop
desk.mov
iOS
ios.mov
Android
and.mov

@namhihi237 namhihi237 marked this pull request as ready for review October 6, 2023 02:29
@namhihi237 namhihi237 requested a review from a team as a code owner October 6, 2023 02:29
@melvin-bot melvin-bot bot requested review from thesahindia and removed request for a team October 6, 2023 02:29
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@namhihi237
Copy link
Contributor Author

@thesahindia PR is ready for review.

@thesahindia
Copy link
Member

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screen.Recording.2023-10-07.at.3.04.52.AM.mov
Mobile Web - Chrome N/A
Mobile Web - Safari N/A
Desktop
Screen.Recording.2023-10-07.at.3.23.26.AM.mov
iOS N/A
Android N/A

Copy link
Member

@thesahindia thesahindia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@neil-marcellini neil-marcellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@neil-marcellini neil-marcellini merged commit 987569f into Expensify:main Oct 10, 2023
15 of 17 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 10, 2023
@github-actions
Copy link
Contributor

Performance Comparison Report 📊

Significant Changes To Duration

Name Duration
App start TTI 1184.592 ms → 1252.044 ms (+67.452 ms, +5.7%) 🔴
App start runJsBundle 802.476 ms → 854.956 ms (+52.480 ms, +6.5%) 🔴
Show details
Name Duration
App start TTI Baseline
Mean: 1184.592 ms
Stdev: 41.232 ms (3.5%)
Runs: 1088.4374019997194 1096.4461380001158 1098.2236599996686 1101.3745100004598 1112.7476650001481 1115.447103000246 1124.6032499996945 1133.7480889996514 1134.3352420004085 1135.1785359997302 1135.5347490003332 1139.1031830003485 1140.1492450004444 1140.6910100001842 1143.9148810002953 1144.2553129997104 1145.914966000244 1148.0078010000288 1150.0948219997808 1152.8916870001704 1154.7810040004551 1155.2056139996275 1158.3866640003398 1160.6849339995533 1162.1080329995602 1166.1736719999462 1166.7756190001965 1167.2265440002084 1167.647901000455 1169.0465089995414 1170.379797000438 1170.4075149996206 1171.60290800035 1173.8117859996855 1173.8352979999036 1174.2060529999435 1174.7579389996827 1175.6891740001738 1176.9201330002397 1177.0918389996514 1177.1905829999596 1179.1049210000783 1181.0321540003642 1181.1361239999533 1181.6215639999136 1181.6311520002782 1182.1850049998611 1182.8570860000327 1183.005095999688 1183.1798270000145 1184.2608730001375 1184.8507190002128 1189.5312280002981 1190.8626739997417 1193.1715169996023 1197.5730919996276 1199.7417310001329 1200.6280720001087 1200.7143980003893 1201.3300519995391 1203.1536969998851 1203.3369429996237 1205.1120130000636 1205.9613389996812 1207.2312129996717 1208.4203589996323 1210.2011679997668 1211.8183869998902 1213.2694420004264 1213.738843999803 1214.3432989995927 1218.2217530002818 1222.5382799999788 1223.6524909995496 1227.1832400001585 1231.5235430002213 1232.1688470002264 1232.9938920000568 1233.365117999725 1233.4884909996763 1240.0575519995764 1246.9144900003448 1250.6463519996032 1250.8243349995464 1255.2155729997903 1255.2192959999666 1256.1779399998486 1257.6166340000927 1259.0747199999169 1286.3762469999492

Current
Mean: 1252.044 ms
Stdev: 51.735 ms (4.1%)
Runs: 1152.8534380001947 1154.6393699999899 1159.7833340000361 1165.256723999977 1165.630805999972 1176.4251509997994 1177.5725170001388 1182.665679000318 1183.7052069995552 1192.1652199998498 1193.0672620004043 1194.4164880001917 1195.4867340000346 1195.5162060000002 1199.3398380000144 1200.557307999581 1204.699974999763 1205.393001999706 1205.8954990003258 1208.3156409999356 1211.6300889998674 1211.6752540003508 1212.6948720002547 1214.1044509997591 1220.0386730004102 1220.0509339999408 1220.2655250001699 1220.82542799972 1223.2077350001782 1223.35966499988 1224.3030859995633 1225.4038829999045 1225.5154529996216 1225.6068679997697 1225.6975290002301 1227.4546980001032 1228.0246460000053 1229.033773000352 1231.6440789997578 1232.9185739997774 1236.102861000225 1236.3743879999965 1238.3381460001692 1238.535171000287 1238.9193339999765 1241.6031069997698 1242.0139650003985 1242.654160999693 1245.1905850004405 1254.0800759997219 1259.156955000013 1259.49614499975 1261.2333350004628 1264.221510999836 1265.3142210002989 1265.9164620004594 1267.322827000171 1269.741617999971 1274.1027349997312 1275.0001370003447 1275.4471939997748 1279.7053049998358 1284.1833340004086 1284.9745880002156 1286.9689980000257 1287.4014539998025 1290.0418109996244 1292.190373999998 1292.8454759996384 1293.85436199978 1296.314276999794 1299.1243629995733 1300.4255870003253 1301.8437050003558 1302.3263219995424 1303.7462590001523 1308.8086550002918 1309.771196000278 1311.3369640000165 1312.9573349999264 1315.285821000114 1317.6223050002009 1317.6733689997345 1318.135758000426 1320.8225279999897 1325.5044560004026 1330.4920899998397 1332.6196259995922 1352.83574699983 1357.4782570004463 1357.8612289996818 1385.2862489996478
App start runJsBundle Baseline
Mean: 802.476 ms
Stdev: 25.513 ms (3.2%)
Runs: 747 755 758 758 758 761 761 762 763 770 772 773 778 781 782 783 783 785 788 789 789 790 790 791 791 792 792 793 794 794 794 794 795 795 798 799 800 800 800 800 801 801 801 801 804 804 805 806 806 807 808 809 809 809 811 811 812 813 813 814 816 817 818 819 820 822 822 823 823 826 832 834 836 839 841 843 851 852 853 855 856 862

Current
Mean: 854.956 ms
Stdev: 33.796 ms (4.0%)
Runs: 781 782 791 791 799 800 810 811 812 814 816 817 817 818 823 823 824 824 824 828 829 830 831 833 835 836 837 838 839 839 840 841 841 842 843 843 843 844 844 845 846 846 849 850 850 850 850 851 852 857 857 861 862 863 866 867 868 868 869 871 872 872 874 876 878 879 881 885 885 887 887 889 891 891 893 894 894 896 897 897 898 899 899 902 907 909 915 920 921 927

Meaningless Changes To Duration

Show entries
Name Duration
App start regularAppStart 0.014 ms → 0.015 ms (+0.001 ms, +4.5%)
App start nativeLaunch 21.765 ms → 21.518 ms (-0.247 ms, -1.1%)
Open Search Page TTI 624.918 ms → 615.838 ms (-9.080 ms, -1.5%)
Show details
Name Duration
App start regularAppStart Baseline
Mean: 0.014 ms
Stdev: 0.001 ms (5.2%)
Runs: 0.012613999657332897 0.01314299926161766 0.01318300049751997 0.013264999724924564 0.013264999724924564 0.013265000656247139 0.013305999338626862 0.0134680001065135 0.013508999720215797 0.013508999720215797 0.013549999333918095 0.013590999878942966 0.013631000183522701 0.013631000183522701 0.013631000183522701 0.013631000183522701 0.013631000183522701 0.013632000423967838 0.013671999797224998 0.013671999797224998 0.013712000101804733 0.013712000101804733 0.013712999410927296 0.013712999410927296 0.013753999955952168 0.013753999955952168 0.013753999955952168 0.013793000020086765 0.013793999329209328 0.013833999633789062 0.0138349998742342 0.01387499924749136 0.013875000178813934 0.013996999710798264 0.013997000642120838 0.0139979999512434 0.014078999869525433 0.014078999869525433 0.014118999242782593 0.014118999242782593 0.01411999948322773 0.014159999787807465 0.0142000000923872 0.0142000000923872 0.014200999401509762 0.014201000332832336 0.014201000332832336 0.014240999706089497 0.014240999706089497 0.014241000637412071 0.014281999319791794 0.014282000251114368 0.014282000251114368 0.01428299956023693 0.014321999624371529 0.014322999864816666 0.014364000409841537 0.014444999396800995 0.01444500032812357 0.014485999941825867 0.014485999941825867 0.014526000246405602 0.014526000246405602 0.014526000246405602 0.014567000791430473 0.01460800040513277 0.01460800040513277 0.014688999392092228 0.014728999696671963 0.014729000627994537 0.0147299999371171 0.014770000241696835 0.014810999855399132 0.014851000159978867 0.014933000318706036 0.015096000395715237 0.015217999927699566 0.015421000309288502 0.015747000463306904 0.015828000381588936 0.015869999304413795 0.015949999913573265 0.015951000154018402 0.015990999527275562 0.01607299968600273 0.016112999990582466

Current
Mean: 0.015 ms
Stdev: 0.001 ms (7.7%)
Runs: 0.012370000593364239 0.013061000034213066 0.013306000269949436 0.013347000814974308 0.013427999801933765 0.013508999720215797 0.013508999720215797 0.01355000026524067 0.013590999878942966 0.013631000183522701 0.01371300034224987 0.013833999633789062 0.0138349998742342 0.013875999487936497 0.013915999792516232 0.013915999792516232 0.013917000032961369 0.013956000097095966 0.013996999710798264 0.0139979999512434 0.0139979999512434 0.014038000255823135 0.014038000255823135 0.014078999869525433 0.014119000174105167 0.014159999787807465 0.014161000028252602 0.014241000637412071 0.014282000251114368 0.014282000251114368 0.014282000251114368 0.014283000491559505 0.014321999624371529 0.014322999864816666 0.014322999864816666 0.014405000023543835 0.01444500032812357 0.01444500032812357 0.014566999860107899 0.014606999233365059 0.014607000164687634 0.014607999473810196 0.01460800040513277 0.01464799977838993 0.014649000018835068 0.014688999392092228 0.014770000241696835 0.014811000786721706 0.014851999469101429 0.014891999773681164 0.0148930000141263 0.014933000318706036 0.014973999932408333 0.015013999305665493 0.015054999850690365 0.015137000009417534 0.015177000313997269 0.015177999623119831 0.015217999927699566 0.015217999927699566 0.015339999459683895 0.015381000004708767 0.015420999377965927 0.015502999536693096 0.01550300046801567 0.015544000081717968 0.015665999613702297 0.015666000545024872 0.015747000463306904 0.01574800070375204 0.0157880000770092 0.0157880000770092 0.01595000084489584 0.015951000154018402 0.01603199914097786 0.01607299968600273 0.01647899951785803 0.016479000449180603 0.01672299951314926 0.0168869998306036 0.017008000053465366 0.017048999667167664 0.01733400020748377 0.01737500075250864 0.017578000202775 0.017781000584363937 0.018025999888777733
App start nativeLaunch Baseline
Mean: 21.765 ms
Stdev: 3.213 ms (14.8%)
Runs: 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 25 25 25 26 26 27 28 29 29 29 30 30 30 30

Current
Mean: 21.518 ms
Stdev: 2.156 ms (10.0%)
Runs: 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 25 25 25 26 26 27 27 27 27 27
Open Search Page TTI Baseline
Mean: 624.918 ms
Stdev: 18.510 ms (3.0%)
Runs: 593.4643149999902 597.447387999855 598.1533200005069 598.6812340002507 601.6637780005112 603.2385660000145 603.4025069996715 603.553059999831 603.8955079996958 603.9291989998892 605.2843019999564 605.285848999396 605.3004569998011 605.7491060001776 606.1077469997108 606.3680430008098 606.5789800006896 606.9619550006464 607.3532309997827 607.6785479998216 609.784789999947 610.2592369997874 610.4126789998263 611.7425539996475 612.3705250006169 612.496296999976 612.7491460004821 613.0613609999418 613.1720789996907 613.4322509998456 613.7157800002024 614.2863769996911 614.3861090000719 614.6062019998208 614.6416419995949 614.9379879999906 614.972574999556 615.3082679994404 615.3280029995367 615.756347999908 616.0628669997677 617.1692300001159 618.3914800006896 619.8215740006417 619.996866999194 621.609211999923 621.9204510003328 621.9443770004436 623.0798349995166 623.2373859994113 623.4955249996856 623.8624269999564 625.0045980000868 625.3607590002939 627.4125580005348 628.3571780007333 628.5965579999611 631.0757240001112 631.1846110001206 631.2568769995123 631.7719320002943 631.9139410005882 635.3036700002849 635.8266199994832 635.9994719997048 636.0011399993673 636.0715739997104 636.2917890008539 636.2940680002794 636.3030190002173 638.0673829996958 638.0932620000094 639.4087739996612 639.7985839992762 645.6774899996817 646.6915690004826 646.9657800002024 647.9064529994503 652.2691660001874 652.9812420001253 653.5616049999371 654.4898690003902 654.9206550000235 655.3916419995949 655.7996009998024 656.016072999686 658.2263599997386 661.3486730000004 665.566935999319 665.7427170006558 670.4427089998499

Current
Mean: 615.838 ms
Stdev: 11.715 ms (1.9%)
Runs: 592.9434409998357 593.6977129997686 594.6450199997053 596.269449999556 597.3474120004103 599.8481040000916 599.9447429999709 600.9625649992377 601.2692870004103 604.3787439996377 604.8449710002169 604.9260249994695 604.988241000101 605.0549320001155 605.1038010008633 605.134561999701 605.3835450001061 605.9053139993921 605.9145100004971 606.1250409996137 606.3050939999521 606.6796070002019 606.9611010001972 607.0653069997206 607.1230480000377 607.2044270001352 608.8977460004389 609.1628010002896 609.4503180002794 609.5075279995799 609.7674159994349 611.713460999541 612.4889730000868 612.7433679997921 612.9908849997446 613.369141000323 613.6379000004381 613.7534990003332 614.0439449995756 614.1783849997446 614.4567880006507 614.5390630001202 614.7493900004774 615.1846920000389 615.3096519997343 615.4080810006708 615.6945799998939 616.1230469997972 616.6284189997241 617.0336099993438 617.3584799999371 617.3968909997493 617.4863689998165 618.4527999991551 620.9209799999371 621.2540690004826 621.4384370008484 621.6770019996911 621.7586260000244 621.8304449999705 621.8637290000916 621.9436450004578 622.5612389994785 622.6022549998015 622.9077559998259 622.916300999932 623.1927899997681 623.5052899997681 624.1304529998451 624.4114579996094 624.9615479996428 625.158690999262 625.2886560000479 625.7412930000573 628.7698569996282 630.4797370005399 630.6196699999273 630.803996999748 631.787597999908 632.5170899992809 632.7648930000141 633.2449549995363 642.375163000077 644.5802819998935 645.753581000492 650.7109789997339

@github-actions
Copy link
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.81-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.83-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants