Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NoQA] Access the report action safely in notification logic #28880

Merged
merged 6 commits into from
Oct 8, 2023
Merged

[NoQA] Access the report action safely in notification logic #28880

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bccb1bc
Access the action safely
mountiny Oct 4, 2023
9e5bf45
Safely access orignalMessage of report action
mountiny Oct 4, 2023
2e9b825
Merge branch 'main' into vit-accessNotificationSafely
mountiny Oct 4, 2023
3a0071f
Merge branch 'main' into vit-accessNotificationSafely
mountiny Oct 5, 2023
8f319a3
Merge branch 'main' into vit-accessNotificationSafely
mountiny Oct 6, 2023
cf9a5d5
Access the actionName safely
mountiny Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1661,7 +1661,7 @@ function shouldShowReportActionNotification(reportID, action = null, isRemote =

// Only show notifications for supported types of report actions
if (!ReportActionsUtils.isNotifiableReportAction(action)) {
Log.info(`${tag} No notification because this action type is not supported`, false, {actionName: action.actionName});
Log.info(`${tag} No notification because this action type is not supported`, false, {actionName: lodashGet(action, 'actionName')});
return false;
}

Expand Down
Loading