Remove optimistic personal detail after requesting money #28426

dukenv0307 · 2023-09-29T04:34:56Z

Details

Remove optimistic personal detail after requesting money

Fixed Issues

$ #28028
PROPOSAL: #28028 (comment)

Tests

Go to FAB > Request money
Enter a valid amount and continue
On the participant page, enter a new account that doesn't have the report
Confirm to request money
After the request is created, open the search page and search with the phone number that we entered in Step 3
Verify that only one option appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to FAB > Request money
Enter a valid amount and continue
On the participant page, enter a new account that doesn't have the report
Confirm to request money
After the request is created, open the search page and search with the phone number that we entered in Step 3
Verify that only one option appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-29.at.10.57.41.mov

Mobile Web - Chrome

Record_2023-09-29-11-03-28.mp4

Mobile Web - Safari

Screen.Recording.2023-09-29.at.11.07.40.mov

Desktop

Screen.Recording.2023-09-29.at.11.24.07.mov

iOS

Screen.Recording.2023-09-29.at.11.12.41.mov

Android

Screen.Recording.2023-09-29.at.11.19.43.mov

melvin-bot · 2023-09-29T04:35:14Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-09-29T04:37:53Z

@0xmiroslav Please ignore this issue, I added the wrong link issue.

dukenv0307 · 2023-09-29T06:58:21Z

@narefyev91 We have a problem here because in RequestMoney API BE doesn't return personal detail, report preview display undefined for a few second and jest test fails before OpenReport API is complete. We have two ways to fix:

Fix from FE: add a field to optimistic personal detail in money request isOptimisticPersonalDetail as true and we will hide the optimistic personal in search page
Fix from BE: BE should return personal detail of payee in RequestMoney API

What do you think about this?

narefyev91 · 2023-09-29T07:37:51Z

@narefyev91 We have a problem here because in RequestMoney API BE doesn't return personal detail, report preview display undefined for a few second and jest test fails before OpenReport API is complete. We have two ways to fix:

Fix from FE: add a field to optimistic personal detail in money request isOptimisticPersonalDetail as true and we will hide the optimistic personal in search page

Fix from BE: BE should return personal detail of payee in RequestMoney API

What do you think about this?

Hey i will say that if should be fixed on FE side

dukenv0307 · 2023-09-29T07:44:26Z

@narefyev91 Updated to fix on FE side.

dukenv0307 · 2023-10-02T04:41:57Z

@narefyev91 Friendly bump.

narefyev91 · 2023-10-02T09:34:28Z

@narefyev91 Friendly bump.

Seems @0xmiroslav is assigned to this issue :-)

dukenv0307 · 2023-10-02T09:38:17Z

@narefyev91 That was my mistake when I updated the wrong link issue when open the PR. You are C+ of this issue #28028.

0xmiros · 2023-10-02T10:47:56Z

@narefyev91 I can help review here if you want.

narefyev91 · 2023-10-02T16:41:03Z

@narefyev91 That was my mistake when I updated the wrong link issue when open the PR. You are C+ of this issue #28028.

Ohhh sorry - will be done today for sure

narefyev91 · 2023-10-02T20:12:15Z

@dukenv0307 can you please merge latest main to your branch

Screen.Recording.2023-10-02.at.23.08.21.mov

I see that after sending money and move to search - i see numbers without duplication
But if i go again to Send money flow - and in search insert phone number i see 2 of them - can you please double check

narefyev91 · 2023-10-02T20:14:41Z

We should be sure that all this searches are covered

dukenv0307 · 2023-10-03T03:36:47Z

@narefyev91 Updated.

narefyev91 · 2023-10-03T08:17:43Z

@dukenv0307 now when we send money to not existing account - i could not find this number again - and seems on search page - it shown not correct user (seems one from predefined optimistic)

Screen.Recording.2023-10-03.at.11.00.02.mov

dukenv0307 · 2023-10-03T08:24:13Z

@narefyev91 This image above is the expected.

dukenv0307 · 2023-10-03T08:25:10Z

Screencast.from.03-10-2023.15.24.40.webm

narefyev91 · 2023-10-03T08:29:13Z

@dukenv0307 hmm not sure if image above - are expected - you can see that on the second screenshot - we have information that user with phone number owns money - and i think it's expected that if we insert phone number - we should see those information

dukenv0307 · 2023-10-03T08:31:27Z

@narefyev91 After request money, BE still doesn't return login field until this recevier send a message in this report. So it's expected behavior. Please see my video above for more detail. You also can test this in main branch.

narefyev91 · 2023-10-03T09:56:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

OSBotify · 2023-10-04T16:24:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-05T00:38:45Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T07:53:42Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:25:54Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:34:28Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:43:21Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:19:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

remove optimistic personal detail after requesting money

35f1bc4

dukenv0307 marked this pull request as ready for review September 29, 2023 04:35

dukenv0307 requested a review from a team as a code owner September 29, 2023 04:35

melvin-bot bot removed the request for review from a team September 29, 2023 04:35

melvin-bot bot requested a review from 0xmiros September 29, 2023 04:35

dukenv0307 added 2 commits September 29, 2023 14:00

hide optimistic personal detail in search page

eaffe5c

fix linnt

708465f

dukenv0307 added 2 commits September 29, 2023 14:41

fix jest

1a0a0e7

fix lint

a7918ff

dukenv0307 added 2 commits October 3, 2023 10:02

Merge branch 'main' into fix/28028

f23ca23

fix duplicate option in offline mode

d860aea

add toLowerCase

47d2ece

narefyev91 approved these changes Oct 3, 2023

View reviewed changes

melvin-bot bot requested a review from madmax330 October 3, 2023 09:56

madmax330 approved these changes Oct 4, 2023

View reviewed changes

madmax330 merged commit d9a603d into Expensify:main Oct 4, 2023
12 checks passed

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-13] [$500] The phone number is displayed twice when searching for it after sending a Money Request. #28028

Closed

6 tasks

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove optimistic personal detail after requesting money #28426

Remove optimistic personal detail after requesting money #28426

dukenv0307 commented Sep 29, 2023 •

edited

Loading

melvin-bot bot commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

narefyev91 commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

dukenv0307 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023 •

edited

Loading

0xmiros commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

dukenv0307 commented Oct 3, 2023

narefyev91 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023

narefyev91 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023 •

edited

Loading

narefyev91 commented Oct 3, 2023

narefyev91 left a comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

Remove optimistic personal detail after requesting money #28426

Remove optimistic personal detail after requesting money #28426

Conversation

dukenv0307 commented Sep 29, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

narefyev91 commented Sep 29, 2023

dukenv0307 commented Sep 29, 2023

dukenv0307 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

dukenv0307 commented Oct 2, 2023 • edited Loading

0xmiros commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

narefyev91 commented Oct 2, 2023

dukenv0307 commented Oct 3, 2023

narefyev91 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023

narefyev91 commented Oct 3, 2023

dukenv0307 commented Oct 3, 2023 • edited Loading

narefyev91 commented Oct 3, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

dukenv0307 commented Sep 29, 2023 •

edited

Loading

dukenv0307 commented Oct 2, 2023 •

edited

Loading

dukenv0307 commented Oct 3, 2023 •

edited

Loading