Create Add-a-Business-Bank-Account-(AUD).md

[bfitzexpensify]

Details

Adding a new article to ExpensifyHelp via the instructions in https://stackoverflowteams.com/c/expensify/questions/15135

Fixed Issues

$https://github.com/Expensify/Expensify/issues/309817

[melvin-bot]

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[bfitzexpensify]

OK, comments removed @rushatgabhane

[youssef-lr]

https://www.westpac.com.au/docs/pdf/bb/Importing-Payment-Files-Guide-Online.pdf)!

This link seems dead?

[bfitzexpensify]

Good catch @youssef-lr - I've updated that link now

[rushatgabhane]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[rushatgabhane]

@youssef-lr LGTM

[melvin-bot]

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28782.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start runJsBundle	835.281 ms → 891.281 ms (+56.000 ms, +6.7%) 🔴
App start TTI	1224.947 ms → 1276.175 ms (+51.228 ms, +4.2%)

Show details

Name	Duration
App start runJsBundle	Baseline Mean: 835.281 ms Stdev: 37.264 ms (4.5%) Runs: 741 766 778 791 794 796 813 814 815 816 819 821 827 827 828 837 840 840 841 850 851 852 864 865 866 868 870 873 888 889 892 897 Current Mean: 891.281 ms Stdev: 25.598 ms (2.9%) Runs: 832 838 855 857 866 870 874 875 875 877 877 879 883 886 888 889 894 894 901 903 905 908 909 909 911 914 914 917 926 930 931 934
App start TTI	Baseline Mean: 1224.947 ms Stdev: 42.173 ms (3.4%) Runs: 1118.23466799967 1150.9100810000673 1175.2355810003355 1180.3057220000774 1183.6637260001153 1188.5006229998544 1189.095452000387 1190.756358999759 1192.41232699994 1205.153992000036 1207.1928399996832 1211.194513999857 1213.5060639996082 1223.186623999849 1233.9994170004502 1235.9849129999056 1236.1660209996626 1236.7500189999118 1239.6833729995415 1243.7343290001154 1245.5864289999008 1248.2169709997252 1252.2515019997954 1252.4995330004022 1252.7538970001042 1254.5267000002787 1257.4728359999135 1265.5006250003353 1268.5163399996236 1279.0441330000758 1341.3102609999478 Current Mean: 1276.175 ms Stdev: 38.286 ms (3.0%) Runs: 1220.9385099997744 1222.2680839998648 1235.8248680001125 1236.8628420000896 1241.1015680003911 1241.4973649997264 1241.6576859997585 1246.1587699996307 1247.7719769999385 1251.8786899996921 1253.1039260001853 1258.111817999743 1258.4555190000683 1259.8527100002393 1262.320329000242 1263.864941000007 1266.9077110001817 1268.6843100003898 1274.7785599995404 1275.5602029999718 1280.5006649997085 1290.189218999818 1290.5886230003089 1292.6690330002457 1298.4447689997032 1304.5357419997454 1306.0982050001621 1339.8222650000826 1342.5524639999494 1354.2686080001295 1354.8154189996421 1355.5163179999217

Meaningless Changes To Duration

Show entries

Name	Duration
App start regularAppStart	0.018 ms → 0.015 ms (-0.003 ms, -18.2%) 🟢
Open Search Page TTI	626.792 ms → 626.023 ms (-0.769 ms, ±0.0%)
App start nativeLaunch	22.656 ms → 21.586 ms (-1.070 ms, -4.7%)

Show details

Name	Duration
App start regularAppStart	Baseline Mean: 0.018 ms Stdev: 0.001 ms (5.4%) Runs: 0.0167239997535944 0.01696799974888563 0.017008000053465366 0.017049000598490238 0.017171000130474567 0.01753699965775013 0.01753699965775013 0.017578000202775 0.017700999975204468 0.017985000275075436 0.018025999888777733 0.018228999339044094 0.018310999497771263 0.018432999961078167 0.0185139998793602 0.018635999411344528 0.018717000260949135 0.018717000260949135 0.018717999570071697 0.0188400000333786 0.018920999951660633 0.019084000028669834 0.01912499964237213 0.0192050002515316 0.01953099947422743 0.01965400017797947 0.01977499946951866 0.01977499946951866 0.020263999700546265 0.020548000000417233 Current Mean: 0.015 ms Stdev: 0.001 ms (4.6%) Runs: 0.013915999792516232 0.013956000097095966 0.01403799932450056 0.014201000332832336 0.014241000637412071 0.014241999946534634 0.014363999478518963 0.01444500032812357 0.014485999941825867 0.014689000323414803 0.014851999469101429 0.014891999773681164 0.014933000318706036 0.015054999850690365 0.015096000395715237 0.015217999927699566 0.015299000777304173 0.015339999459683895 0.01534000039100647 0.015420999377965927 0.015461999922990799 0.015502999536693096 0.015502999536693096 0.015625 0.015625 0.015665999613702297 0.015787999145686626 0.0157880000770092 0.015868999995291233 0.01607200037688017 0.016114000231027603 0.0166830001398921
Open Search Page TTI	Baseline Mean: 626.792 ms Stdev: 30.417 ms (4.9%) Runs: 589.2963060000911 596.446940000169 598.681599999778 601.9284669999033 602.0001229997724 602.0607909997925 602.0929770004004 603.0303960004821 603.1847740001976 604.3837080001831 609.5380860008299 611.0321860006079 611.4566249996424 613.1679700007662 613.7842209991068 615.4181320006028 619.4168699998409 619.5389000000432 622.1558030005544 625.2104499991983 626.5970060005784 629.3289799997583 631.0733239995316 634.5062259994447 641.4338790001348 644.2182620000094 652.1379399998114 670.794719000347 671.8494060002267 676.3930259998888 695.6124270008877 719.5658360002562 Current Mean: 626.023 ms Stdev: 19.355 ms (3.1%) Runs: 602.8973799999803 604.18518100027 604.187541000545 605.2451990004629 605.5301519995555 608.1635340005159 609.2007649997249 609.3155929995701 610.146972999908 610.4244380006567 611.740316000767 611.7888179998845 613.5028480002657 619.1890459991992 619.5770269995555 619.597289999947 626.1328539997339 627.3148190006614 628.131306999363 629.2395430002362 631.0246580000967 631.7076819995418 633.3970950003713 636.2639570003375 640.6181230004877 641.3300790004432 642.6582439998165 642.9713960001245 646.1044510006905 667.9058029996231 668.5747480001301 674.6679699998349
App start nativeLaunch	Baseline Mean: 22.656 ms Stdev: 3.479 ms (15.4%) Runs: 19 19 19 19 20 20 20 20 20 20 20 20 21 21 21 21 22 22 22 23 23 23 24 24 26 26 26 26 26 28 31 33 Current Mean: 21.586 ms Stdev: 1.903 ms (8.8%) Runs: 19 19 19 20 20 20 20 20 20 21 21 21 21 21 21 21 22 22 22 22 22 22 23 23 23 23 26 26 26

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[rushatgabhane]

bad bot
we just modified a markdown file here

[youssef-lr]

Not a deploy blocker!

[OSBotify]

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅