Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120

tienifr · 2023-09-25T09:34:18Z

Details

Fixed Issues

$ #26945
PROPOSAL: #26945 (comment)

Tests

Launch app
Tap fab
Tap request money
Tap distance
Tap Start and select an address
Tap Finish and select an address
Tap next
Select a workspace
Note the Request money amount
Navigate back to Request money page
Tap Manual
Verify that the Distance IOU amount is not displayed in manual request money page and the expected result is 0

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Launch app
Tap fab
Tap request money
Tap distance
Tap Start and select an address
Tap Finish and select an address
Tap next
Select a workspace
Note the Request money amount
Navigate back to Request money page
Tap Manual
Verify that the Distance IOU amount is not displayed in manual request money page and the expected result is 0

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-09-25.at.16.11.11.mp4

Mobile Web - Chrome

381755590_6378850562226056_4610030612457005125_n.mp4

Mobile Web - Safari

382657853_6072114082888795_6444920784609858618_n.mp4

Desktop

Screen.Recording.2023-09-25.at.16.25.45.mov

iOS

Uploading Screen Recording 2023-09-25 at 16.39.49.mov…

Android

Screen.Recording.2023-09-25.at.17.00.33.mov

melvin-bot · 2023-09-25T10:02:25Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-09-25T11:05:57Z

src/pages/iou/MoneyRequestSelectorPage.js

+        }
+
+        resetMoneyRequestInfo();
+        // resetMoneyRequestInfo function is not added as dependencies since they don't change between renders


Is this a necessary optimization?

Yes, we don't need to call resetMoneyRequestInfo when resetMoneyRequestInfo get changed

I asked whether it was a necessary optimization. Disabling the exhaustiveness check for this dependency array is forever, for this dependency and for other potential future dependencies.

In other words, does it do any harm to include resetMoneyRequestInfo in the deps? As I see it, you didn't answer this question.

I asked whether it was a necessary optimization. Disabling the exhaustiveness check for this dependency array is forever, for this dependency and for other potential future dependencies.

we're getting iouType and reportID from route, so they are not changed for every re-renders. Currently, in resetMoneyRequestInfo function we're using iouType and reportID, but not wrap it in useCallback, that why resetMoneyRequestInfo function will be created to the new one for every re-renders.

If we want to put resetMoneyRequestInfo in the dependency, we have to wrap resetMoneyRequestInfo, reportID and iouType in useCallback/useMemo, but it can make our code complex and less readable. Beside I see other places in our app still use react-hooks/exhaustive-deps

Do you think we should use useCallback/useMemo here?

First, I'm trying to ensure that we're in agreement on whether this is an optimization that can be done or something that had to be done because otherwise the app behavior would be incorrect.

As I understand it, this the first case.

After giving it a thought, you might be right that silencing the lint might be acceptable here. It's a pity one can't disable this exhaustiveness check more granually, like (pseudo-code):

// eslint-config react-hooks/exhaustive-deps {resetMoneyRequestInfo: false}

cubuspl42 · 2023-09-26T10:13:34Z

@tienifr

Verify that the Distance IOU amount is not displayed in manual request money page.

Mention that the expected result is 0

cubuspl42 · 2023-09-26T10:40:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

reset-money-request-web.mp4

Mobile Web - Chrome

reset-money-request-android-web-compressed.mp4

Mobile Web - Safari

reset-money-request-ios-web.mp4

Desktop

iOS

reset-money-request-ios.mp4

Android

reset-money-request-android-compressed.mp4

marcochavezf

Thanks guys, LGTM

OSBotify · 2023-09-27T02:42:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:18:39Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:22:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:51:13Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:52:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr added 3 commits September 15, 2023 18:01

fix: 26945

7eba3a9

Merge branch 'main' into fix/26945

efc9685

fix lint

33dd82f

tienifr marked this pull request as ready for review September 25, 2023 10:02

tienifr requested a review from a team as a code owner September 25, 2023 10:02

melvin-bot bot requested review from cubuspl42 and removed request for a team September 25, 2023 10:02

cubuspl42 reviewed Sep 25, 2023

View reviewed changes

cubuspl42 approved these changes Sep 26, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf September 26, 2023 10:41

marcochavezf approved these changes Sep 27, 2023

View reviewed changes

marcochavezf merged commit 46775db into Expensify:main Sep 27, 2023
15 of 20 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

aimane-chnaif mentioned this pull request Sep 29, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [HOLD for payment 2023-10-6] [$500] Request money - Extra 0 digit in the amount and app crashes when requesting money #28417

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

melvin-bot bot mentioned this pull request Oct 2, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #26945

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120

Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120

tienifr commented Sep 25, 2023 •

edited

Loading

melvin-bot bot commented Sep 25, 2023

cubuspl42 Sep 25, 2023

tienifr Sep 26, 2023

cubuspl42 Sep 26, 2023 •

edited

Loading

tienifr Sep 26, 2023

cubuspl42 Sep 26, 2023

cubuspl42 commented Sep 26, 2023

cubuspl42 commented Sep 26, 2023

marcochavezf left a comment

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120

Fix: 26945 Android-IOU-Distance IOU amount is auto-filled and displayed in manual request money page #28120

Conversation

tienifr commented Sep 25, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 25, 2023

cubuspl42 Sep 25, 2023

Choose a reason for hiding this comment

tienifr Sep 26, 2023

Choose a reason for hiding this comment

cubuspl42 Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

tienifr Sep 26, 2023

Choose a reason for hiding this comment

cubuspl42 Sep 26, 2023

Choose a reason for hiding this comment

cubuspl42 commented Sep 26, 2023

cubuspl42 commented Sep 26, 2023

Reviewer Checklist

Screenshots/Videos

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

tienifr commented Sep 25, 2023 •

edited

Loading

cubuspl42 Sep 26, 2023 •

edited

Loading