refactor: migrated WalletStatementModal to function component #27934

barttom · 2023-09-21T12:01:03Z

Details

Fixed Issues

$ 16217
PROPOSAL: 16217

Tests

Go to http://localhost:8082/statements/202308 - parameter is a date with format YYYYMM
Verify that there is no error in the console in local environment

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to http://localhost:8082/statements/202308 - parameter is a date with format YYYYMM
Verify that there is no error in the console in local environment (you won't see a statement, just a blank page, but that's expected).

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos


note: In that PR to create screenshots need to hardcode the path because 
this feature is available for US citizens only.
That's why the web view is empty. However, nothing changed in passing the proper url.

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

src/components/WalletStatementModal/index.native.js

rezkiy37

LGTM after resolving navigation. Left a question.

src/components/WalletStatementModal/index.native.js

rezkiy37

LGTM after resolving.

src/CONST.ts

src/components/WalletStatementModal/index.js

rezkiy37

LGTM

melvin-bot · 2023-09-22T13:23:19Z

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan

All commits should be signed and verified

barttom · 2023-09-24T15:41:28Z

@situchan thanks, fixed :)

situchan · 2023-09-24T15:48:29Z

Please add Tests / QA steps

dangrous

This looks good except for one tiny change.

Can you share how to test this? I'm not sure how to access the flow for this page. Thank you!

dangrous · 2023-09-25T04:06:43Z

src/components/WalletStatementModal/index.native.js

-import withLocalize from '../withLocalize';
-import ONYXKEYS from '../../ONYXKEYS';
-import compose from '../../libs/compose';
+


do we need this space?

nope, removed :)

situchan · 2023-09-25T16:28:29Z

We can use same Tests step as #26064

Send this link to any chat: https://staging.new.expensify.com/statements/202309 (in dev:http://localhost:8082/statements/202309)
Click this link

situchan · 2023-09-25T17:19:03Z

Btw, I think we're not able to test better. Just blank page shows on all platforms.

situchan · 2023-09-25T17:19:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

Let's use this as QA step - #27934 (comment)

melvin-bot · 2023-09-25T17:21:45Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #28180.

situchan · 2023-09-25T17:27:50Z

Please fix typo in PR title. reafctor

dangrous

Looks good! I updated the title but can you update the QA steps and then we can merge. Thanks!

barttom · 2023-09-26T05:21:52Z

Looks good! I updated the title but can you update the QA steps and then we can merge. Thanks!

done :)

dangrous · 2023-09-26T07:40:24Z

Sorry, one more - can you clarify for the QA tester what the error they ARE supposed to see is? I jsut want to make it extra clear :)

barttom · 2023-09-26T18:12:16Z

Sorry, one more - can you clarify for the QA tester what the error they ARE supposed to see is? I jsut want to make it extra clear :)

Sorry, my mistake. There is no error to see in the console. Steps fixed .

OSBotify · 2023-09-27T03:26:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:18:19Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:22:14Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:50:52Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:51:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

thiagobrez reviewed Sep 21, 2023

View reviewed changes

src/components/WalletStatementModal/index.native.js Outdated Show resolved Hide resolved

rezkiy37 reviewed Sep 21, 2023

View reviewed changes

src/components/WalletStatementModal/index.native.js Outdated Show resolved Hide resolved

rezkiy37 reviewed Sep 21, 2023

View reviewed changes

barttom force-pushed the refactor/16217/WalletStatementModal-native-component-migration branch from 019bb1d to 1ad4be0 Compare September 22, 2023 05:44

fabioh8010 approved these changes Sep 22, 2023

View reviewed changes

kubabutkiewicz reviewed Sep 22, 2023

View reviewed changes

src/components/WalletStatementModal/index.native.js Outdated Show resolved Hide resolved

rezkiy37 reviewed Sep 22, 2023

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

src/components/WalletStatementModal/index.js Outdated Show resolved Hide resolved

rezkiy37 approved these changes Sep 22, 2023

View reviewed changes

barttom marked this pull request as ready for review September 22, 2023 13:22

barttom requested a review from a team as a code owner September 22, 2023 13:22

melvin-bot bot requested review from dangrous and removed request for a team September 22, 2023 13:23

situchan reviewed Sep 22, 2023

View reviewed changes

barttom force-pushed the refactor/16217/WalletStatementModal-native-component-migration branch from cfdd675 to 98dff02 Compare September 24, 2023 15:35

dangrous requested changes Sep 25, 2023

View reviewed changes

barttom and others added 5 commits September 25, 2023 13:00

reafctor: migrated WalletStatementModal to function component

aeb95dd

refactor: used Navigation instance instead of hook

f01d1be

refactor: added message type to the const object

54e0f20

refactor: changed conts variable name

47a5d08

refactor: remove not needed empty line

378247d

barttom force-pushed the refactor/16217/WalletStatementModal-native-component-migration branch from 98dff02 to 378247d Compare September 25, 2023 11:03

situchan approved these changes Sep 25, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Sep 25, 2023

Payment issue for E/App PR#27934 #28180

Closed

dangrous changed the title ~~reafctor: migrated WalletStatementModal to function component~~ refactor: migrated WalletStatementModal to function component Sep 26, 2023

dangrous approved these changes Sep 26, 2023

View reviewed changes

dangrous merged commit 3f337e8 into Expensify:main Sep 27, 2023
17 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

lanitochka17 mentioned this pull request Sep 29, 2023

Web - Wallet Statement Modal - Statement is not displayed and errors appear #28490

Closed

6 tasks

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: migrated WalletStatementModal to function component #27934

refactor: migrated WalletStatementModal to function component #27934

barttom commented Sep 21, 2023 •

edited by dangrous

Loading

rezkiy37 left a comment

rezkiy37 left a comment

rezkiy37 left a comment

melvin-bot bot commented Sep 22, 2023

situchan left a comment

barttom commented Sep 24, 2023 •

edited

Loading

situchan commented Sep 24, 2023

dangrous left a comment

dangrous Sep 25, 2023

barttom Sep 25, 2023

situchan commented Sep 25, 2023 •

edited

Loading

situchan commented Sep 25, 2023

situchan commented Sep 25, 2023

situchan left a comment

melvin-bot bot commented Sep 25, 2023

situchan commented Sep 25, 2023

dangrous left a comment

barttom commented Sep 26, 2023

dangrous commented Sep 26, 2023

barttom commented Sep 26, 2023

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

refactor: migrated WalletStatementModal to function component #27934

refactor: migrated WalletStatementModal to function component #27934

Conversation

barttom commented Sep 21, 2023 • edited by dangrous Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 left a comment

Choose a reason for hiding this comment

rezkiy37 left a comment

Choose a reason for hiding this comment

rezkiy37 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 22, 2023

situchan left a comment

Choose a reason for hiding this comment

barttom commented Sep 24, 2023 • edited Loading

situchan commented Sep 24, 2023

dangrous left a comment

Choose a reason for hiding this comment

dangrous Sep 25, 2023

Choose a reason for hiding this comment

barttom Sep 25, 2023

Choose a reason for hiding this comment

situchan commented Sep 25, 2023 • edited Loading

situchan commented Sep 25, 2023

situchan commented Sep 25, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 25, 2023

situchan commented Sep 25, 2023

dangrous left a comment

Choose a reason for hiding this comment

barttom commented Sep 26, 2023

dangrous commented Sep 26, 2023

barttom commented Sep 26, 2023

OSBotify commented Sep 27, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

barttom commented Sep 21, 2023 •

edited by dangrous

Loading

barttom commented Sep 24, 2023 •

edited

Loading

situchan commented Sep 25, 2023 •

edited

Loading