Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: arrow navigation in context menu #27877
feat: arrow navigation in context menu #27877
Changes from 3 commits
cd7278f
977d4f1
fa0b8e7
5869c6c
e8d9442
20a5415
18a9e81
777ca93
0867e44
fe46818
85ceb1e
32ac964
56d0a92
c70a374
10bb500
6428b28
4d4fff3
82ed8fc
ea487db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought
isFocused
name is better but didn't request change becausefocused
prop name already exists here 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have adjusted the prop name in the added code.
If you'd like me to refactor the existing prop in MenuItem and change it there + it's usages also, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fine as we didn't touch
MenuItem
component here.If anyone is adding/changing props on that component in the future, they might be responsible.
cc: @francoisl