Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Money request skeleton is shown when delete IOU in offline mode #27753

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Fix: Money request skeleton is shown when delete IOU in offline mode #27753

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2725fb9
fix: 26939
tienifr Sep 10, 2023
f36e68c
Merge branch 'fix/26939' of https://github.com/tienifr/App into fix/2…
tienifr Sep 19, 2023
80dda53
fix lint
tienifr Sep 19, 2023
22b9de7
Merge branch 'main' of https://github.com/tienifr/App into fix/26939
tienifr Sep 21, 2023
f199b8e
use lodashGet
tienifr Sep 21, 2023
02a7563
Merge branch 'main' of https://github.com/tienifr/App into fix/26939
tienifr Sep 21, 2023
1235d8b
update skeleton condition
tienifr Sep 21, 2023
7168e09
update condition
tienifr Sep 21, 2023
013b314
Merge branch 'main' of https://github.com/tienifr/App into fix/26939
tienifr Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ReportActionItem/MoneyRequestPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ function MoneyRequestPreview(props) {
isHovered={isScanning}
/>
)}
{_.isEmpty(props.transaction) ? (
{_.isEmpty(props.transaction) &&
!_.contains([CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE, CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE], lodashGet(props.action, 'pendingAction')) ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking message.isDeletedParentAction || pendingAction === 'delete'

<MoneyRequestSkeletonView />
) : (
<View style={styles.moneyRequestPreviewBoxText}>
Expand Down
Loading