Move all header buttons to overflow menu

[srikarparsi]

Details

Screenshots:

The join and leave thread buttons will be the chatbubbles icon but there's placeholders for now.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/318732
PROPOSAL:

Tests

1. Click pin and unpin conversation to make sure it works as expected
2. Click the google meets and zoom buttons to make sure they take you to their respective site
3. Click on a thread
4. Click join thread and ensure that the thread still shows up in most recent mode even when you navigate away.
5. Go back and click leave thread and ensure the thread disappears from your LHN in most recent mode when you navigate away.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-26.at.1.04.44.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-26.at.1.17.42.PM.mov

Mobile Web - Safari

Screen.Recording.2023-09-26.at.1.19.31.PM.mov

Desktop

Screen.Recording.2023-09-26.at.1.21.11.PM.mov

iOS

Android

Having trouble with emulator, will try more tonight

[melvin-bot]

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[srikarparsi]

Still need to translate the messages in Spanish

[shawnborton]

Screenshots please!

[srikarparsi]

Added :)

[shawnborton]

Nice, looks good so far - I like the leave icon too.

[madmax330]

@srikarparsi can you pull in a C+ 🙏🏽

[dannymcclain]

Here's the "comment bubbles" icon (you can also find it in Figma here)

Comment Bubbles.svg.zip

[srikarparsi]

Ah cool, thanks!

[dannymcclain]

This is looking good! Going to approve without the updated chat bubbles icon but it would be awesome if we could add that in to this.

Also wanted to just point out that while "Leave thread" shows up in a thread's overflow menu, "Leave room" does not show up in a room's overflow menu, only in the details panel. I don't think that was necessarily supposed to be addressed in this issue, but it's an inconsistency that's probably worth thinking about.

[srikarparsi]

Cool yeah! We actually have an issue for that and I'll work on that one right after this one's merged :)

[srikarparsi]

This is ready for re-review @mollfpr, I'm waiting on feedback for the translations but other than that this is ready to be looked at again.

[shawnborton]

Ah okay, if that exists on main then let's create a follow up issue to treat all of the rooms the same. Does that sound right @JmillsExpensify @trjExpensify ?

[trjExpensify]

Yeah, I thought this initiative was to add those options to all reports and within the overflow menu tbh. A separate PR for it sounds good though.

[srikarparsi]

Cool created an issue and assigned myself to it. I think the main initiative is to be able to join and leave threads and consolidating the header overflow menu was a side effect of that since we needed to add the join option to it for threads.

[srikarparsi]

Waiting to get access on Apple Developer to create a build on my phone and add screenshots. I think we can merge after that.

[Julesssss]

Looks good, we just need to test iOS. You should be able to continue with the physical iOS build stackoverflow, right? Else I can test on my test device later this evening

[srikarparsi]

Just added the iOS screenshots so this should be ready to merge whenever you have a chance :)

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[parasharrajat]

@srikarparsi You removed the logic to hide the empty threads from LHN e67845c.

Is this new expected behavior? We have an issue created for this here #29851

[srikarparsi]

Responded on the issue

[eVoloshchak]

👋 Coming from #28535
This doesn't need an iconFill, the color is already applied by default, but passing it here was overriding the behavior when the icon changes color when you hover over it

[parasharrajat]

This created an issue #29851