-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update landing page copy (below headline) for SaaStr & SBE Conferences #26278
Conversation
Confirmed copy is good in slack, still waiting on spanish translations but at least we can review! |
Sorry @jjcoffee unassigning b/c this is a very small change, won't need C+ help testing here 🙏 |
Ready for final review! |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.62-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/311877
Tests
/saastr
(without logging in)/sbe
(without logging in)Offline tests
N/A have to be online
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Not needed - this new text won't show on small screens
Mobile Web - Safari
Not needed - this new text won't show on small screens
Desktop
Not needed, deep linking will occur after logging in i believe
iOS
Not needed - this new text won't show on small screens
Android
Not needed - this new text won't show on small screens