[No QA] Add automated tests for delete money request #26029

rayane-djouah · 2023-08-27T11:28:18Z

Details

Fixed Issues

$ #25601
PROPOSAL: #25601 (comment)

Tests

run: npm run test -- ./tests/actions/IOUTest.js
Verify that the tests passes successfully.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

N/A

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

N/A

iOS

N/A

Android

N/A

…IOU report test case

…ents left in the IOU report test case

melvin-bot · 2023-08-31T14:01:02Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2023-08-31T20:01:55Z

@aimane-chnaif could you review and give me feedback? thank you!

aimane-chnaif · 2023-08-31T20:03:51Z

then I think that I might not be adding a report action properly here could you take a look?

Are you still having trouble finding the root cause of this?

rayane-djouah · 2023-08-31T20:25:06Z

Are you still having trouble finding the root cause of this?

@aimane-chnaif yes

…yRequest

rayane-djouah · 2023-09-05T16:48:57Z

Friendly bump here @aimane-chnaif

tests/actions/IOUTest.js

rayane-djouah · 2023-09-05T20:21:13Z

I need help on the above issues, thank you.

luacmartins · 2023-09-11T01:42:25Z

@aimane-chnaif could you take a look at the above comments? It seems like we're seeing some unexpected behavior with the command

luacmartins · 2023-09-11T04:27:51Z

Also @rayane-djouah, we started allowing async/await in our test suite, so maybe you can rewrite some of the logic here to use that pattern instead and hopefully it'd make things simpler/easier to read/debug.

…yRequest

rayane-djouah · 2023-09-16T22:13:48Z

Updated

luacmartins · 2023-09-18T02:11:16Z

@aimane-chnaif any chance you can review this one today?

aimane-chnaif · 2023-09-18T02:11:58Z

@aimane-chnaif any chance you can review this one today?

yes, will review today

luacmartins · 2023-09-19T01:16:04Z

Thank you @aimane-chnaif!

rayane-djouah · 2023-09-20T22:14:16Z

Merge conflicts resolved

rayane-djouah · 2023-09-20T22:14:22Z

friendly bump @aimane-chnaif

luacmartins

LGTM! Only a few minor NAB, but I'll merge this since it's just tests and we don't need C+ review here

luacmartins · 2023-09-21T00:41:53Z

tests/actions/IOUTest.js

+            Report.openReport(thread.reportID, userLogins, thread, createIOUAction.reportActionID);
+            await waitForBatchedUpdates();
+
+            // Then The iou action has the transaction report id as a child report ID


NAB

Suggested change

// Then The iou action has the transaction report id as a child report ID

// Then the iou action has the transaction report id as a child report ID

luacmartins · 2023-09-21T00:42:23Z

tests/actions/IOUTest.js

+            IOU.deleteMoneyRequest(transaction.transactionID, createIOUAction, false);
+            await waitForBatchedUpdates();
+
+            // Then The report for the given thread ID does not exist


Suggested change

// Then The report for the given thread ID does not exist

// Then the report for the given thread ID does not exist

luacmartins · 2023-09-21T00:42:45Z

tests/actions/IOUTest.js

+            expect(report).toBeFalsy();
+            fetch.resume();
+
+            // Then After resuming fetch, the report for the given thread ID still does not exist


Suggested change

// Then After resuming fetch, the report for the given thread ID still does not exist

// Then after resuming fetch, the report for the given thread ID still does not exist

luacmartins · 2023-09-21T00:44:18Z

tests/actions/IOUTest.js

+            await waitForBatchedUpdates();
+
+            // Given a thread report
+


Suggested change

luacmartins · 2023-09-21T00:45:54Z

tests/actions/IOUTest.js

+            });
+
+            // When we resume fetch
+


Suggested change

luacmartins · 2023-09-21T00:46:03Z

tests/actions/IOUTest.js

+            await waitForBatchedUpdates();
+
+            // Given an added comment to the IOU report
+


Suggested change

luacmartins · 2023-09-21T00:46:14Z

tests/actions/IOUTest.js

+            fetch.resume();
+
+            // Then we expect the moneyRequestPreview to show [Deleted request]
+


Suggested change

luacmartins · 2023-09-21T00:46:33Z

tests/actions/IOUTest.js

+            await waitForBatchedUpdates();
+
+            // Given a second money request in addition to the first one
+


Suggested change

luacmartins · 2023-09-21T00:48:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A we're just adding tests

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-09-21T00:56:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

aimane-chnaif

Sorry for late. Latest changes look good to me too

OSBotify · 2023-09-22T14:01:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.73-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T09:36:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-25T10:08:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.74-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-28T18:50:39Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rayane-djouah added 6 commits August 27, 2023 11:19

add delete a money request successfully test case

aaa19d8

delete the IOU report when there are no visible comments left in the …

07273f3

…IOU report test case

draft: add does not delete the IOU report when there are visible comm…

a34be23

…ents left in the IOU report test case

fix lint errors

d02e3cb

fix lint errors

22ba7a9

add remaining test cases (draft)

b498321

rayane-djouah changed the title ~~Add automated tests for delete money request~~ [No QA] Add automated tests for delete money request Aug 31, 2023

rayane-djouah marked this pull request as ready for review August 31, 2023 14:00

rayane-djouah requested a review from a team as a code owner August 31, 2023 14:00

melvin-bot bot requested review from aimane-chnaif and removed request for a team August 31, 2023 14:01

rayane-djouah added 2 commits September 4, 2023 14:04

Merge branch 'Expensify:main' into Add-automated-tests-for-DeleteMone…

b8d2442

…yRequest

remove unecessary mock

4f2b1cf