fix: check deletion with confirmation modal #24022

s-alves10 · 2023-08-01T21:28:52Z

Details

Fixed Issues

$ #24016
PROPOSAL: #24016 (comment)

Tests

Login ND and go to any chat
Send a message
Switch to edit mode and delete all contents of the draft and click save
Select Delete on delete confirmation modal
Verify that the main composer is shown

Verify that no errors appear in the JS console

Offline tests

Login ND and go to any chat
Send a message
Switch to edit mode and delete all contents of the draft and click save
Select Delete on delete confirmation modal
Verify that the main composer is shown

QA Steps

Login ND and go to any chat
Send a message
Switch to edit mode and delete all contents of the draft and click save
Select Delete on delete confirmation modal
Verify that the main composer is shown

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

24016_mac_chrome.mp4

Mobile Web - Chrome

24016_android_chrome.mp4

Mobile Web - Safari

24016_ios_safari.mp4

Desktop

24016_mac_desktop.mp4

iOS

24016_ios_native.mp4

Android

24016_anrdoid_native.mp4

s77rt · 2023-08-01T21:49:16Z

src/pages/home/report/ReportActionItemMessageEdit.js

-    useEffect(() => {
-        // required for keeping last state of isFocused variable
-        isFocusedRef.current = isFocused;
-    }, [isFocused]);
-


Can you explain why this is needed? @s77rt

The change is not needed. Let's just add the missing condition

@s77rt
reverted

@s77rt

Reverting raises an issue. In android chrome, text input gets focused after deletion and then draft is unmounted. So main composer gets hidden. When the draft is deleted, isFocusedRef.current is false even the input gets focused due to the effect delay.

Using ref only, we can avoid this

@s77rt How about using ref only solution? This works on all platforms

s77rt · 2023-08-01T22:24:22Z

src/pages/home/report/ReportActionItemMessageEdit.js

-            ReportActionContextMenu.showDeleteModal(props.reportID, props.action, false, deleteDraft, () => InteractionManager.runAfterInteractions(() => textInputRef.current.focus()));
+            ReportActionContextMenu.showDeleteModal(props.reportID, props.action, false, deleteDraft);


Why is this change required?

In ReportActionItem, hideDeleteModal is called and then this cancel callback is called. focusing on non-existent element raises an error

What does this have to do with the previous PR changes?

This is a hidden bug. I don't think the previous PR introduced this bug

Please do not make changes that does not reflect the PR scope unless we are fixing another bug - it seems we are removing a feature. We revert the first PR and find a solution to this. I think your solution won't work due to how useEffects propogate.

At first ReportActionContextMenu.isActiveReportAction will be true, but at the end in the useEffect it will be false. The main composer won't show.

At first ReportActionContextMenu.isActiveReportAction will be true, but at the end in the useEffect it will be false. The main composer won't show.

That's true. So I don't use ReportActionContextMenu.isActiveReportAction in useEffect

Please do not make changes that does not reflect the PR scope unless we are fixing another bug

We can't solve this issue because deleting the draft this way raises an error in android native

We revert the first PR and find a solution to this

What's your solution?

Please test your solution in android native

The old PR was reverted by @marcochavezf

What should we do now?

We need to find a fix for the regression. Let's continue working on this on the issue

s77rt · 2023-08-13T02:00:38Z

@s-alves10 Can you please close this PR?

fix: check deletion with confirmation modal

17362ba

s-alves10 mentioned this pull request Aug 1, 2023

mWeb Android/Chrome - Compose box is hidden when we delete edited message #24016

Closed

6 tasks

s77rt suggested changes Aug 1, 2023

View reviewed changes

fix: restore state variable and disable focusing on cancel delete

0cbb3ec

s77rt suggested changes Aug 1, 2023

View reviewed changes

s-alves10 closed this Aug 13, 2023

s-alves10 deleted the fix/issue-24016 branch November 22, 2023 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: check deletion with confirmation modal #24022

fix: check deletion with confirmation modal #24022

s-alves10 commented Aug 1, 2023 •

edited

Loading

s77rt Aug 1, 2023

s-alves10 Aug 1, 2023

s77rt Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023

s77rt Aug 1, 2023

s-alves10 Aug 1, 2023

s77rt Aug 1, 2023

s-alves10 Aug 1, 2023 •

edited

Loading

s77rt Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023

s-alves10 Aug 1, 2023 •

edited

Loading

s77rt Aug 1, 2023

s77rt commented Aug 13, 2023

		ReportActionContextMenu.showDeleteModal(props.reportID, props.action, false, deleteDraft, () => InteractionManager.runAfterInteractions(() => textInputRef.current.focus()));
		ReportActionContextMenu.showDeleteModal(props.reportID, props.action, false, deleteDraft);

fix: check deletion with confirmation modal #24022

fix: check deletion with confirmation modal #24022

Conversation

s-alves10 commented Aug 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s-alves10 Aug 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s-alves10 Aug 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented Aug 13, 2023

s-alves10 commented Aug 1, 2023 •

edited

Loading

s-alves10 Aug 1, 2023 •

edited

Loading

s-alves10 Aug 1, 2023 •

edited

Loading