Fix console error when validating/unlinking secondary account #23469

MonilBhavsar · 2023-07-24T10:36:20Z

Details

We missed initializing during the migration and in turn makes required props undefined and displays an error
#19498 (comment)

Fixed Issues

$ #22923
PROPOSAL:

Tests

Open a tab where account A is signed-in
Add secondary contact method B, and do not verify that contact method
Open a new incognito window > Navigate to sign-in page
Open console and enter secondary contact method B & click on the continue button
Verify that no console error appears

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Open a tab where account A is signed-in
Add secondary contact method B, and do not verify that contact method
Open a new incognito window > Navigate to sign-in page
Open console and enter secondary contact method B & click on the continue button
Verify that no console error appears

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

iOS

N/A

Android

N/A

roryabraham

This seems fine, though I'm unsure the scenarios when these would not be set in the code below

roryabraham · 2023-07-24T22:35:53Z

Thinking about this some more, can you maybe help explain the reproduction steps for this warning / what conditions cause welcomeText and welcomeHeader to not be set below, and that could tell us how to fix it without defaulting to an empty string? Not sure it matters either way though.

MonilBhavsar · 2023-07-25T09:14:39Z

It is not set in shouldShowUnlinkLoginForm here
https://github.com/Expensify/App/pull/23469/files#diff-c5a5c5593f21966821ea88d4630dd1c2b31bc851de5a3634f5d41ac8604d84abR128-R134

I think in some case like this where we don't want to display welcomeText, we'll need to set it as empty string. Instead we can initialize it as empty string, as it is required prop in SigninPageLayout component

melvin-bot · 2023-07-28T06:32:16Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2023-07-28T06:32:36Z

@roryabraham do you please mind merging it 🙏

c3024 · 2023-07-28T06:48:38Z

I think it is better to add welcomeText for shouldShowUnlinkLoginForm as well like this

welcomeText = isSmallScreenWidth ? translate('welcomeText.welcomeBack') : '';

and shouldShowWelcomeText as well true for unlinking page by changing

const shouldShowWelcomeText = shouldShowLoginForm || shouldShowValidateCodeForm || isUnvalidatedSecondaryLogin;

for consistency.
For large screens, we show big "Welcome back" with the welcomeHeader but for smaller screens we don't show the words 'Welcome back". This can be shown with welcomeText for smaller screens for consistency.
Check this video. Reducing the screen size removes the "Welcome back" text.

Screen.Recording.2023-07-28.at.12.12.13.PM.mov

While this is a small issue it is worth fixing since it is being discussed now.

Alternative is to hide welcomeHeader as well for unlinking page if we don't like to show "Welcome back" at all in this page.

0xmiros · 2023-07-28T07:31:50Z

It seems intentional to show different welcome message between small device (hero.header) and large device (welcomeBack).

App/src/pages/signin/SignInPage.js

Line 129 in 975146f

    
           welcomeHeader = isSmallScreenWidth ? translate('login.hero.header') : translate('welcomeText.welcomeBack');

Screen.Recording.2023-07-28.at.9.28.10.AM.mov

c3024 · 2023-07-28T07:33:35Z

Indeed the header is different for large and small screens but the header in large screens is shown as text in smaller screens for all pages except this page.

0xmiros · 2023-07-28T07:35:27Z

I also think it's a bit weird and don't see the reason why they are inconsistent between devices. Btw out of scope for this PR.

0xmiros · 2023-07-28T07:36:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-28.at.9.32.08.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

c3024 · 2023-07-28T07:36:38Z

Shall I raise it as another bug and propose the solution then if it is out of the scope for this PR?

0xmiros · 2023-07-28T07:37:33Z

Shall I raise it as another bug and propose the solution then if it is out of the scope for this PR?

Maybe you can post in slack and get some feedback

0xmiros

LGTM!

melvin-bot · 2023-07-28T07:38:18Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham

Thanks @MonilBhavsar !

OSBotify · 2023-07-28T19:24:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-31T18:57:56Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-01T23:59:12Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-02T01:23:42Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:16:09Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Initialize with empty string

f2a961f

MonilBhavsar self-assigned this Jul 24, 2023

roryabraham reviewed Jul 24, 2023

View reviewed changes

MonilBhavsar marked this pull request as ready for review July 28, 2023 06:32

MonilBhavsar requested a review from a team as a code owner July 28, 2023 06:32

melvin-bot bot removed the request for review from a team July 28, 2023 06:32

melvin-bot bot requested a review from 0xmiros July 28, 2023 06:32

MonilBhavsar removed the request for review from 0xmiros July 28, 2023 06:32

0xmiros approved these changes Jul 28, 2023

View reviewed changes

melvin-bot bot requested a review from jasperhuangg July 28, 2023 07:38

jasperhuangg approved these changes Jul 28, 2023

View reviewed changes

roryabraham approved these changes Jul 28, 2023

View reviewed changes

roryabraham merged commit 513fed9 into main Jul 28, 2023
3 checks passed

roryabraham deleted the monil-fixUnlinkWarning branch July 28, 2023 19:20

OSBotify mentioned this pull request Jul 31, 2023

Deploy Checklist: New Expensify 2023-07-31 #23945

Closed

48 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

melvin-bot bot mentioned this pull request Aug 1, 2023

[HOLD for payment 2023-08-08] Dev: Web - Console log error when trying to unlink secondary contact method #22923

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix console error when validating/unlinking secondary account #23469

Fix console error when validating/unlinking secondary account #23469

MonilBhavsar commented Jul 24, 2023 •

edited

Loading

roryabraham left a comment

roryabraham commented Jul 24, 2023

MonilBhavsar commented Jul 25, 2023

melvin-bot bot commented Jul 28, 2023

MonilBhavsar commented Jul 28, 2023

c3024 commented Jul 28, 2023 •

edited

Loading

0xmiros commented Jul 28, 2023

c3024 commented Jul 28, 2023

0xmiros commented Jul 28, 2023

0xmiros commented Jul 28, 2023

c3024 commented Jul 28, 2023

0xmiros commented Jul 28, 2023 •

edited

Loading

0xmiros left a comment

melvin-bot bot commented Jul 28, 2023

roryabraham left a comment

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Fix console error when validating/unlinking secondary account #23469

Fix console error when validating/unlinking secondary account #23469

Conversation

MonilBhavsar commented Jul 24, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

roryabraham left a comment

Choose a reason for hiding this comment

roryabraham commented Jul 24, 2023

MonilBhavsar commented Jul 25, 2023

melvin-bot bot commented Jul 28, 2023

MonilBhavsar commented Jul 28, 2023

c3024 commented Jul 28, 2023 • edited Loading

0xmiros commented Jul 28, 2023

c3024 commented Jul 28, 2023

0xmiros commented Jul 28, 2023

0xmiros commented Jul 28, 2023

Reviewer Checklist

Screenshots/Videos

c3024 commented Jul 28, 2023

0xmiros commented Jul 28, 2023 • edited Loading

0xmiros left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 28, 2023

roryabraham left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

MonilBhavsar commented Jul 24, 2023 •

edited

Loading

c3024 commented Jul 28, 2023 •

edited

Loading

0xmiros commented Jul 28, 2023 •

edited

Loading