refactor: workspace-invite-page to function component #22646

s-alves10 · 2023-07-11T14:43:46Z

Details

WorkspaceInvitePage was refactored to function component

Fixed Issues

$ #16305
PROPOSAL: #16305 (comment)

Tests

Open ND and go to settings -> workspaces -> workspace -> members -> invite
Verify that user selection/deselection works as expected(toggled)
Verify that user invitation works fine by clicking Next and Invite buttons
Verify that searching works as expected. Selected options should remain when search query is changed

Verify that no errors appear in the JS console

Offline tests

Open ND and go to settings -> workspaces -> workspace -> members -> invite
Verify that user selection/deselection works as expected(toggled)
Verify that user invitation works fine by clicking Next and Invite buttons
Verify that searching works as expected. Selected options should remain when search query is changed

QA Steps

Open ND and go to settings -> workspaces -> workspace -> members -> invite
Verify that user selection/deselection works as expected(toggled)
Verify that user invitation works fine by clicking Next and Invite buttons
Verify that searching works as expected. Selected options should remain when search query is changed

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

16305_mac_chrome.mp4

Mobile Web - Chrome

16305_android_chrome.mp4

Mobile Web - Safari

16305_ios_safari.mp4

Desktop

16305_mac_desktop.mp4

iOS

16305_ios_native.mp4

Android

16305_android_native.mp4

melvin-bot · 2023-07-11T14:58:15Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/WorkspaceInvitePage.js

Santhosh-Sellavel · 2023-07-11T20:38:47Z

@s-alves10 Please check carefully before committing changes. You can check lint before committing using the command npm run lint.

s-alves10 · 2023-07-12T11:52:22Z

@Santhosh-Sellavel

Can you take a look at the PR again?

src/pages/workspace/WorkspaceInvitePage.js

Santhosh-Sellavel · 2023-07-14T18:48:32Z

@s-alves10 Please check carefully before committing changes. You can check lint before committing using the command npm run lint.

Again lint issues

src/pages/workspace/WorkspaceInvitePage.js

s-alves10 · 2023-07-14T18:50:38Z

Again lint issues

Sorry

src/pages/workspace/WorkspaceInvitePage.js

s-alves10 · 2023-07-14T19:02:02Z

Please check again

Santhosh-Sellavel · 2023-07-17T20:11:33Z

@s-alves10 it ran into conflict again please check!

Santhosh-Sellavel · 2023-07-17T20:14:54Z

@s-alves10 Sorry for the delay here. Let's try and get this merged by tomorrow.

Santhosh-Sellavel · 2023-07-19T00:41:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Desktop

iOS & Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-19.at.06.05.47.mp4

Android & Mobile Web - Chrome

Screen.Recording.2023-07-19.at.6.06.49.AM.mov

Santhosh-Sellavel · 2023-07-19T00:42:01Z

@s-alves10

Can you check this console error,

Screen.Recording.2023-07-19.at.5.57.56.AM.mov

s-alves10 · 2023-07-20T03:17:31Z

@Santhosh-Sellavel
Please take a look again. Thanks

Santhosh-Sellavel · 2023-07-20T03:20:31Z

src/libs/PolicyUtils.js

+function getExcludedUsers(policyMembers, personalDetails) {
+    const memberEmailsToExclude = [...CONST.EXPENSIFY_EMAILS];
+    _.each(policyMembers, (policyMember, accountID) => {
+        // Policy members that are pending delete or have errors are not valid and we should show them in the invite options (don't exclude them).
+        if (policyMember.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !_.isEmpty(policyMember.errors)) {
+            return;


JS Doc is missing here

@s-alves10 Can you fix this alone, please?

Santhosh-Sellavel

LGTM, just a couple of items for you to look at!

Approving to get a review from @pecanoro!

src/libs/PolicyUtils.js

Santhosh-Sellavel · 2023-07-23T19:54:58Z

bump @pecanoro!

pecanoro · 2023-07-24T13:47:14Z

I replied to both comments for clarification.

s-alves10 · 2023-07-24T18:42:30Z

@pecanoro

Please take a look again

…Invitees

pecanoro · 2023-07-25T16:28:29Z

@s-alves10 @Santhosh-Sellavel Did you both retest the PR after all the changes? I did and it seems to be working but making sure I am not the only one that tested it after the last commits

Santhosh-Sellavel · 2023-07-25T16:36:24Z

@pecanoro I didn't yet I'll retest again, and let you know!

s-alves10 · 2023-07-25T19:47:41Z

@s-alves10 @Santhosh-Sellavel Did you both retest the PR after all the changes? I did and it seems to be working but making sure I am not the only one that tested it after the last commits

@pecanoro
I have tested again with the latest updates. It works fine

OSBotify · 2023-07-25T22:23:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Santhosh-Sellavel · 2023-07-26T00:26:55Z

Tested well for me too!

OSBotify · 2023-07-26T16:10:14Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:08:10Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:38:59Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-31T18:36:39Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

refactor: workspace-invite-page to function component

79eaaf4

s-alves10 marked this pull request as ready for review July 11, 2023 14:58

s-alves10 requested a review from a team as a code owner July 11, 2023 14:58

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team July 11, 2023 14:58

s-alves10 mentioned this pull request Jul 11, 2023

[HOLD for payment 2023-08-03] [$250] Migrate WorkspaceInvitePage.js to function component #16305

Closed

1 task

Santhosh-Sellavel suggested changes Jul 11, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

sangar-1028 added 4 commits July 11, 2023 11:24

fix: use of useOnNetworkReconnect hook

f91bde4

fix: lint error

86e9eff

fix: remove policyID from dependency

cbb3c5c

fix: lint error

614d744

s-alves10 requested a review from Santhosh-Sellavel July 14, 2023 08:15

Santhosh-Sellavel suggested changes Jul 14, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

src/pages/workspace/WorkspaceInvitePage.js Show resolved Hide resolved

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

fix: use useLocalize and useMemo

0f4f36e

Santhosh-Sellavel reviewed Jul 14, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

Santhosh-Sellavel reviewed Jul 14, 2023

View reviewed changes

src/pages/workspace/WorkspaceInvitePage.js Outdated Show resolved Hide resolved

fix: remove useMemo for headerMessage, llint error

af49b56

s-alves10 requested a review from Santhosh-Sellavel July 17, 2023 20:10

sangar-1028 added 2 commits July 17, 2023 15:29

fix: conflicts

33021ad

fix: lint error

39fe20c

Santhosh-Sellavel suggested changes Jul 20, 2023

View reviewed changes

sangar-1028 added 2 commits July 19, 2023 22:31

fix: add JS docc to getExcludedUsers function

076e59f

fix: prettier issue

fadf3e6

Santhosh-Sellavel approved these changes Jul 20, 2023

View reviewed changes

src/libs/PolicyUtils.js Show resolved Hide resolved

melvin-bot bot requested a review from pecanoro July 20, 2023 03:43

sangar-1028 added 2 commits July 24, 2023 13:29

fix: remove useRef for storing function and minor renaming

755547c

fix: lint error

edc8453

sangar-1028 added 2 commits July 25, 2023 08:59

fix: rename function getMemberAccountIDsForWorkspace -> getIneligible…

82d5364

…Invitees

fix: renaming function

990e610

Merge branch 'main' into refactor/workspace-invite

30a75b5

pecanoro approved these changes Jul 25, 2023

View reviewed changes

pecanoro merged commit 9c5a998 into Expensify:main Jul 25, 2023

eh2077 mentioned this pull request Jul 26, 2023

fix: header message for already invited member of workspace #23490

Merged

58 tasks

Beamanator mentioned this pull request Jul 26, 2023

Use new network hook #23620

Merged

58 tasks

OSBotify mentioned this pull request Jul 26, 2023

Deploy Checklist: New Expensify 2023-07-26 #23657

Closed

43 tasks

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

s-alves10 deleted the refactor/workspace-invite branch November 22, 2023 16:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: workspace-invite-page to function component #22646

refactor: workspace-invite-page to function component #22646

s-alves10 commented Jul 11, 2023

melvin-bot bot commented Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023

s-alves10 commented Jul 12, 2023

Santhosh-Sellavel commented Jul 14, 2023

s-alves10 commented Jul 14, 2023

s-alves10 commented Jul 14, 2023

Santhosh-Sellavel commented Jul 17, 2023

Santhosh-Sellavel commented Jul 17, 2023

Santhosh-Sellavel commented Jul 19, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 19, 2023

s-alves10 commented Jul 20, 2023

Santhosh-Sellavel Jul 20, 2023

Santhosh-Sellavel Jul 20, 2023

s-alves10 Jul 20, 2023

Santhosh-Sellavel left a comment

Santhosh-Sellavel commented Jul 23, 2023

pecanoro commented Jul 24, 2023

s-alves10 commented Jul 24, 2023

pecanoro commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023

s-alves10 commented Jul 25, 2023 •

edited

Loading

OSBotify commented Jul 25, 2023

Santhosh-Sellavel commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

refactor: workspace-invite-page to function component #22646

refactor: workspace-invite-page to function component #22646

Conversation

s-alves10 commented Jul 11, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023

s-alves10 commented Jul 12, 2023

Santhosh-Sellavel commented Jul 14, 2023

s-alves10 commented Jul 14, 2023

s-alves10 commented Jul 14, 2023

Santhosh-Sellavel commented Jul 17, 2023

Santhosh-Sellavel commented Jul 17, 2023

Santhosh-Sellavel commented Jul 19, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Jul 19, 2023

s-alves10 commented Jul 20, 2023

Santhosh-Sellavel Jul 20, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Jul 20, 2023

Choose a reason for hiding this comment

s-alves10 Jul 20, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Santhosh-Sellavel commented Jul 23, 2023

pecanoro commented Jul 24, 2023

s-alves10 commented Jul 24, 2023

pecanoro commented Jul 25, 2023

Santhosh-Sellavel commented Jul 25, 2023

s-alves10 commented Jul 25, 2023 • edited Loading

OSBotify commented Jul 25, 2023

Santhosh-Sellavel commented Jul 26, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 31, 2023

Santhosh-Sellavel commented Jul 19, 2023 •

edited

Loading

s-alves10 commented Jul 25, 2023 •

edited

Loading