Refactor migrate password page to functional component #21960

HezekielT · 2023-06-30T15:52:30Z

Details

Migrate PasswordPage.js to functional component.

Fixed Issues

$ #16283
PROPOSAL: #16283 (comment)

Tests

Open NewDot App.
Navigate to Setting => Security => ChangePassword.
Add an incorrect password to Current Password field and only letters to New Password field and click on Save button.
Verify Your password must have at least 8 characters, 1 capital letter ... error is displayed.
change the New password field to password that fulfills the above requirement and click on Save button.
Verify Your password changes could not be saved because the old password entered is incorrect error is displayed assuming you added an incorrect password in Current Password field.
Add the correct password to Current Password field and click on Save button.
Verify that Password Updated! screen is shown.

Verify that no errors appear in the JS console

Offline tests

Open NewDot App.
Navigate to Setting => Security => ChangePassword.
Add an incorrect password to Current Password field and letter only to New Password field and click on Save button.
Verify Your password must have at least 8 characters, 1 capital letter ... error is displayed.

QA Steps

Same as Tests section above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

PasswordPageWeb.mov

Mobile Web - Chrome

PasswordPageMweb.mov

Mobile Web - Safari

Desktop

PasswordPageDesktop.mov

iOS

Android

PasswordPageAndroidNative.mov

…unctional-component

melvin-bot · 2023-06-30T15:52:35Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-07-04T08:25:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-04.at.2.24.13.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-04.at.2.42.00.PM.mov

Mobile Web - Safari

Screen.Recording.2023-07-04.at.2.38.26.PM.mov

Desktop

Screen.Recording.2023-07-04.at.2.29.12.PM.mov

iOS

Screen.Recording.2023-07-04.at.2.43.42.PM.mov

Android

Screen.Recording.2023-07-04.at.2.45.26.PM.mov

src/pages/settings/PasswordPage.js

allroundexperts · 2023-07-04T09:18:50Z

@HezekielT Try to make your commit messages meaningful.

HezekielT · 2023-07-04T09:19:46Z

@allroundexperts ok sorry.

allroundexperts · 2023-07-04T09:26:52Z

@HezekielT Are you sure that you've uploaded correct screenshots for iOS? I would include the full device frame in the screen recording.

allroundexperts

LGTM!

NikkiWines

one minor minor comment but otherwise looks good

NikkiWines · 2023-07-05T22:40:35Z

src/pages/settings/PasswordPage.js

+    useEffect(
+        () => () => {
+            Session.clearAccountMessages();
+        },
+        [],
+    );


I think you can make this one-line and it still falls within our style guidelines

useEffect(() => () => Session.clearAccountMessages(),[]);

@NikkiWines I've made the change you requested.

NikkiWines

OSBotify · 2023-07-05T23:24:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-07T10:45:39Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-11T00:00:41Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.38-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

HezekielT and others added 8 commits June 28, 2023 22:26

in progress

6f62b59

in progress

d18d365

almost finished

2661e38

in progress

07e6eac

migrated to functional component

ac7b6ee

removed callback

369f1e4

Merge branch 'Expensify:main' into refactor-migrate-PasswordPage-to-f…

b8a8a6d

…unctional-component

Finished migration of PasswordPage to functional component

334c1df

HezekielT requested a review from a team as a code owner June 30, 2023 15:52

melvin-bot bot requested review from allroundexperts and removed request for a team June 30, 2023 15:52

HezekielT mentioned this pull request Jun 30, 2023

[HOLD for payment 2023-07-17] [$250] Migrate PasswordPage.js to function component #16283

Closed

1 task

HezekielT added 6 commits June 30, 2023 19:03

fix lint errors

179a569

fix lint errors 2

22301c8

added callback

c3c088e

fixed lint errors

32a87e0

final change

2f6270f

prettier issue solved

d39ab05

allroundexperts suggested changes Jul 4, 2023

View reviewed changes

src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved

src/pages/settings/PasswordPage.js Outdated Show resolved Hide resolved

fix

5af9a7a

HezekielT force-pushed the refactor-migrate-PasswordPage-to-functional-component branch from 08ed259 to 5af9a7a Compare July 4, 2023 09:52

allroundexperts approved these changes Jul 4, 2023

View reviewed changes

melvin-bot bot requested a review from NikkiWines July 4, 2023 09:55

NikkiWines requested changes Jul 5, 2023

View reviewed changes

fix change the useEffect to one-line

3e94326

NikkiWines approved these changes Jul 5, 2023

View reviewed changes

NikkiWines merged commit 25d3342 into Expensify:main Jul 5, 2023

OSBotify mentioned this pull request Jul 7, 2023

Deploy Checklist: New Expensify 2023-07-07 #22399

Closed

64 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor migrate password page to functional component #21960

Refactor migrate password page to functional component #21960

HezekielT commented Jun 30, 2023

melvin-bot bot commented Jun 30, 2023

allroundexperts commented Jul 4, 2023 •

edited

Loading

allroundexperts commented Jul 4, 2023

HezekielT commented Jul 4, 2023

allroundexperts commented Jul 4, 2023

allroundexperts left a comment

NikkiWines left a comment

NikkiWines Jul 5, 2023

HezekielT Jul 5, 2023

NikkiWines left a comment

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

Refactor migrate password page to functional component #21960

Refactor migrate password page to functional component #21960

Conversation

HezekielT commented Jun 30, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 30, 2023

allroundexperts commented Jul 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts commented Jul 4, 2023

HezekielT commented Jul 4, 2023

allroundexperts commented Jul 4, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

NikkiWines Jul 5, 2023

Choose a reason for hiding this comment

HezekielT Jul 5, 2023

Choose a reason for hiding this comment

NikkiWines left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

OSBotify commented Jul 11, 2023

allroundexperts commented Jul 4, 2023 •

edited

Loading