-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA]Remove CP Staging
label functionality
#21601
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I don't want to CP a random PR to validate the tests. @thienlnam as you're deployer this week, if you get a CP request could you try the 'Use workflow from' option to test against this PR? (someone please correct me if that is not enough to verify) |
We could merge this and then CP it, I am not 100% confident in running the workflow from this branch with out it being merged |
Reviewer Checklist
Screenshots/VideosN/A GH actions only. WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Coolio, will merge and then CP this |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit 0e02294)
Noice - all good https://github.com/Expensify/App/actions/runs/5392582576 |
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.33-4 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀
|
Details
Removes all the functionality that runs when we have the
CP Staging
label as we are moving to an internal Slack process to handle them manually via the @Expensify/mobile-deployersFixed Issues
$ #20764
Tests
CP Staging
labelOffline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
N/A - GitHub Actions
Mobile Web - Chrome
N/A - GitHub Actions
Mobile Web - Safari
N/A - GitHub Actions
Desktop
N/A - GitHub Actions
iOS
N/A - GitHub Actions
Android
N/A - GitHub Actions