Refactor WorkspaceMembersPage to functional component #20687

Li357 · 2023-06-13T15:53:19Z

Details

Refactor WorkspaceMembersPage.js to functional component

Fixed Issues

$ #16306

Tests

Go to Workspace > Members
Verify that searching for members already in workspace works
Verify that invite button navigates to invite page
Verify that individual selection works
Verify that select all only selects non-admin workspace users
Verify that removal works
Verify that selecting admin user gives warning
Verify that removing any selection with admin does not work

Verify that no errors appear in the JS console

Offline tests

Verify that deleting resyncs after network reconnects
Verify that cached members load even if offline
Verify that inviting and deletion when offline leads to grayed out members

QA Steps

Same as local tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web-chrome.mov

web-safari.mov

Mobile Web - Chrome

android-chrome.gif.zip

Mobile Web - Safari

Uploading Simulator Screen Recording - iPhone 14 (16.1) - 2023-06-14 at 12.55.52.mp4…

Desktop

Screen.Recording.2023-06-14.at.1.25.03.PM.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.16.1.-.2023-06-14.at.12.54.07.mp4

Android

android.gif.zip

melvin-bot · 2023-06-14T17:30:02Z

@abdulrahuman5196 @danieldoglas One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-06-15T17:41:48Z

@Li357 Could you kindly resolve the conflicts in the PR?

src/pages/workspace/WorkspaceMembersPage.js

abdulrahuman5196 · 2023-06-17T18:04:34Z

src/pages/workspace/WorkspaceMembersPage.js

+                        }}
+                        accessibilityLabel={props.formatPhoneNumber(item.displayName)}
+                        // disable hover dimming
+                        hoverDimmingValue={1}


NAB: Currently in main hoverDimmingValue is default to 1, so its redundant here

abdulrahuman5196 · 2023-06-17T18:09:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-18.at.1.53.25.PM.1.mp4

Mobile Web - Chrome

az_recorder_20230618_143458.mp4

Mobile Web - Safari

ios.safari.mp4

Desktop

Screen.Recording.2023-06-18.at.3.48.51.PM.mp4

iOS

Screen.Recording.2023-06-18.at.3.03.35.PM.mp4

Android

az_recorder_20230618_155805.mp4

abdulrahuman5196 · 2023-06-18T10:40:01Z

@Li357 "Mobile Web - Safari" video is not present. And why are we upload android videos as zip? It is recommended to directly upload the videos, so that its easy to video from the PR itself.
And kindly mark "Verify that no errors appear in the JS console" on QA steps as well?

abdulrahuman5196

The changes looks good and works well. Reviewers checklist is also complete.

All yours @danieldoglas

@Li357 Kindly update the author's checklist as mentioned here #20687 (comment)

melvin-bot · 2023-06-18T10:59:05Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #16306... Please reach out for help on Slack if no one gets assigned!

abdulrahuman5196 · 2023-06-18T11:01:29Z

Sorry melvin. danieldoglas@ is already assigned as internal engineer for this PR.

melvin-bot · 2023-06-19T17:40:07Z

@danieldoglas looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-06-19T17:43:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-21T02:27:04Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.3.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-22T16:54:42Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.30-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Andrew Li added 2 commits June 12, 2023 10:36

Initial refactor

6f731e7

Fix dependency lists for callbacks

3ae8558

Li357 changed the title ~~Andrewli refactor workspacemembers~~ Refactor WorkspaceMembersPage to functional component Jun 13, 2023

Li357 and others added 2 commits June 13, 2023 14:47

Merge branch 'main' into andrewli-refactor-workspacemembers

4d13308

Run prettier

113d65a

Li357 self-assigned this Jun 14, 2023

Andrew Li added 4 commits June 14, 2023 10:04

Linting

3885b97

Update comments

35f359b

Get workspace members on mount

7cebd1a

Linting part 2

9987f7d

Li357 marked this pull request as ready for review June 14, 2023 17:29

Li357 requested a review from a team as a code owner June 14, 2023 17:29

melvin-bot bot requested review from abdulrahuman5196 and danieldoglas and removed request for a team June 14, 2023 17:30

Merge branch 'main' into andrewli-refactor-workspacemembers

a1f93c5

abdulrahuman5196 reviewed Jun 15, 2023

View reviewed changes

src/pages/workspace/WorkspaceMembersPage.js Outdated Show resolved Hide resolved

Andrew Li added 2 commits June 16, 2023 09:56

Merge main into branch

b119238

Updating state naming and linting

6876eec

abdulrahuman5196 reviewed Jun 17, 2023

View reviewed changes

abdulrahuman5196 approved these changes Jun 18, 2023

View reviewed changes

Merge branch 'main' into andrewli-refactor-workspacemembers

2048b4b

danieldoglas approved these changes Jun 19, 2023

View reviewed changes

danieldoglas merged commit f1b37bb into main Jun 19, 2023

danieldoglas deleted the andrewli-refactor-workspacemembers branch June 19, 2023 17:40

melvin-bot bot added the Emergency label Jun 19, 2023

Li357 removed the Emergency label Jun 20, 2023

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

lanitochka17 mentioned this pull request Jun 21, 2023

Workspace - If admin located at the end of the list select admin warning appears cut off #21224

Closed

6 tasks

melvin-bot bot mentioned this pull request Jun 22, 2023

[HOLD for payment 2023-06-29] [HOLD] [$250] Migrate WorkspaceMembersPage.js to function component #16306

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor WorkspaceMembersPage to functional component #20687

Refactor WorkspaceMembersPage to functional component #20687

Li357 commented Jun 13, 2023 •

edited

Loading

melvin-bot bot commented Jun 14, 2023

abdulrahuman5196 commented Jun 15, 2023

abdulrahuman5196 Jun 17, 2023

abdulrahuman5196 commented Jun 17, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 18, 2023

abdulrahuman5196 left a comment

melvin-bot bot commented Jun 18, 2023

abdulrahuman5196 commented Jun 18, 2023

melvin-bot bot commented Jun 19, 2023

OSBotify commented Jun 19, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

Refactor WorkspaceMembersPage to functional component #20687

Refactor WorkspaceMembersPage to functional component #20687

Conversation

Li357 commented Jun 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 14, 2023

abdulrahuman5196 commented Jun 15, 2023

abdulrahuman5196 Jun 17, 2023

Choose a reason for hiding this comment

abdulrahuman5196 commented Jun 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented Jun 18, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 18, 2023

abdulrahuman5196 commented Jun 18, 2023

melvin-bot bot commented Jun 19, 2023

OSBotify commented Jun 19, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 22, 2023

Li357 commented Jun 13, 2023 •

edited

Loading

abdulrahuman5196 commented Jun 17, 2023 •

edited

Loading