-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17049 - migrate RadioButton to PressableWithFeedback #20250
17049 - migrate RadioButton to PressableWithFeedback #20250
Conversation
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@allroundexperts assigned you as a reviewer since you were assigned to the issue. |
hoverDimmingValue={1} | ||
pressDimmingValue={1} | ||
accessibilityLabel={props.accessibilityLabel} | ||
accessibilityRole="radio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should create a CONST for "radio"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be added in #20251, so we can put this PR on hold until CONST values will be available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that seems fine. We could also add it in this PR in case it's merged first.
@luacmartins How can I test this page? Do I need an account with special permissions? |
@Skalakid could you please provide more details on |
Bump on above @Skalakid! |
@allroundexperts you can get to that page by:
|
@luacmartins Thanks. I'll try this. |
@luacmartins I'm getting the following error after following the steps you mentioned above. |
Hmm maybe my steps are not available in staging 🤔 @Skalakid how did you access that page in staging? |
@allroundexperts @luacmartins I just described how to test this PR, but honestly, I don't know how to do it without changing the code. I was trying to test it using old PRs' test flows (like from #8009 or #9914) but I wasn't able to reproduce them :/ |
@allroundexperts can you just review the code? I'll complete the checklist and submit the videos |
Sure @luacmartins! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise, this looks good!
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromechrome.movMobile Web - Safarisafari.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.27-0 🚀
|
@Skalakid @luacmartins @allroundexperts do we need to QA this? Can you share clear QA steps |
@mvtglobally I think it's fine to QA it as part of Wallet regression tests. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀
|
Details
Fixed Issues
$ #17049
PROPOSAL: #17049
Tests
AdditionalDetailsStep.js
:to:
http://localhost:8080/enable-payments
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mweb-chrome.mov
Mobile Web - Safari
mWeb-safari.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov