Add EmailDeliveryFailure view #19508

NikkiWines · 2023-05-24T01:28:24Z

Details

Adds a new "email delivery failed" view to newDot for when users are blocked because AWS / Mailgun haven't been able to deliver emails to them.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/286767
PROPOSAL: N/A

Tests

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Confirm you see the following view:
Click the here link and confirm it redirects to https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1
Click Back and confirm it takes you back to login view to enter an email/sms number
In your original window run NVP.set('expensify_emailDeliveryFailure', null); in the JS console to unblock your account

Verify that no errors appear in the JS console

Offline tests

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Disable your network connection
Confirm you see the following view:

QA Steps

Login into your account on oldDot and add the email delivery failed NVP by pasting the following in the JS console: NVP.set('expensify_emailDeliveryFailure', {'lastSMTPErrorDatetime': moment.now().addDays(1).toString()});
In an incognito window, try to log into your account in newDot
Confirm you see the following view:
Click the here link and confirm it redirects to https://community.expensify.com/discussion/5651/deep-dive-best-practices-when-youre-running-into-trouble-receiving-emails-from-expensify/p1?new=1
Click Back and confirm it takes you back to login view to enter an email/sms number
In your original window run NVP.set('expensify_emailDeliveryFailure', null); in the JS console to unblock your account

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…aildeliveryissue

…le + merge main

NikkiWines · 2023-06-14T19:55:58Z

Some changes going on with the SignInPage where it was converted to a functional component and then reverted so going to hold off on updates for now

NikkiWines · 2023-06-22T17:56:55Z

Looks like there's a WIP PR to migrate that component again so holding off until that's merged

NikkiWines · 2023-06-30T03:13:52Z

#20708 is in review so going to continue to hold off on making changes

…eryissue

NikkiWines · 2023-07-08T01:26:43Z

src/pages/signin/SignInPage.js

    });

    let welcomeHeader;
    let welcomeText;
-    if (shouldShowValidateCodeForm) {
+    if (shouldShowValidateCodeForm || shouldShowResendValidationForm) {


We were somehow returning true for shouldShowResendValidationForm (which I think should probably be removed) but never had any logic for setting the welcomeHeader or welcomeText for that view. Now we do 😅

NikkiWines · 2023-07-08T01:27:08Z

Ah, sorry about that @Santhosh-Sellavel, should be good now

Santhosh-Sellavel · 2023-07-09T20:23:53Z

src/pages/signin/EmailDeliveryFailurePage.js

+EmailDeliveryFailurePage.displayName = 'EmailDeliveryFailurePage';
+
+export default compose(
+    withLocalize,


Can we use useLocalizeHook here instead of withLocalize HOC

Yep, good catch!

…eryissue

NikkiWines · 2023-07-10T21:54:26Z

Updated once more 🙇

Santhosh-Sellavel · 2023-07-11T14:55:54Z

@NikkiWines Keyboard Doesn't disappear automatically on iOS alone.

Screen.Recording.2023-07-11.at.8.25.13.PM.mov

Santhosh-Sellavel · 2023-07-11T15:01:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-07-11.at.8.13.57.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-07-11.at.8.21.49.PM.mov

iOS & Android

Screen.Recording.2023-07-12.at.2.43.34.AM.mov

Santhosh-Sellavel

Other than this LGTM, tests well!

NikkiWines · 2023-07-11T20:24:25Z

@Santhosh-Sellavel added logic to dismiss the keyboard

Santhosh-Sellavel · 2023-07-11T20:53:13Z

src/pages/signin/EmailDeliveryFailurePage.js

+    useEffect(() => {
+        if (!isKeyboardShown) {
+            return;
+        }
+        Keyboard.dismiss();
+    }, [isKeyboardShown]);


Let's add a comment why this was added, as it look unnecessary here

Santhosh-Sellavel

LGTM tests well!

melvin-bot · 2023-07-11T21:17:06Z

@PauloGasparSv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

PauloGasparSv

LGTM

Web

Mobile Web - Chrome

Skipped, having trouble with the android emulator. Stuck on the loading screen on chrome mobile

Mobile Web - Safari

Desktop

iOS

Android

OSBotify · 2023-07-13T02:00:06Z

🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.40-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-14T14:45:02Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.40-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-07-14T15:20:04Z

@NikkiWines Can I get an issue created for tracking payment?

@mountiny Why the issue was not created automatically here?

mountiny · 2023-07-14T18:50:11Z

There is a regression in the back end so going to fix that

NikkiWines · 2023-07-14T19:05:02Z

@Santhosh-Sellavel issue created! Sorry about that - #22910

NikkiWines added 4 commits May 23, 2023 18:26

add copy for email delivery failure

bd9e3d4

add email delivery page to signin logic

3bd5084

style and consistentcy

9a8cc3f

add emailDeliveryFailurePage

7c0de29

NikkiWines self-assigned this May 24, 2023

NikkiWines added 5 commits June 1, 2023 17:44

Merge branch 'main' of https://github.com/Expensify/App into nikki-em…

387126c

…aildeliveryissue

Merge branch 'main' of https://github.com/Expensify/App into nikki-em…

6815b15

…aildeliveryissue

update copy

e4dfed5

update styling for emaildeliveryfailure view

1cdc46b

ensure we show the correct header

5c23dfb

NikkiWines changed the title ~~Add EmailDeliveryFailure view~~ [HOLD] Add EmailDeliveryFailure view Jun 2, 2023

NikkiWines added 13 commits June 2, 2023 15:43

jsx style

f84803f

prettier style

52051ff

remove out of date comment

fb0b480

Merge branch 'main' of https://github.com/Expensify/App into nikki-em…

1ae9bbe

…aildeliveryissue

update english copy

9a2a4e3

add spanish copy

07ac55d

use presablewithfeedback instead of touchable opacity

3e0f91b

Merge branch 'main' of https://github.com/Expensify/App into nikki-em…

400bc6f

…aildeliveryissue

fix imports

a66dd2c

Update emailDeliveryFailure logic to match new function component sty…

5fc8e29

…le + merge main

function docs, prop validation, minor style

dc7ab26

typo

f2c881d

prettier style

51615f1

Merge branch 'main' of github.com:Expensify/App into nikki-emaildeliv…

cee46c3

…eryissue

NikkiWines changed the title ~~[HOLD] Add EmailDeliveryFailure view~~ Add EmailDeliveryFailure view Jul 3, 2023

update function declaration

3e91861

prettier

e56a2c6

NikkiWines commented Jul 8, 2023

View reviewed changes

Santhosh-Sellavel suggested changes Jul 9, 2023

View reviewed changes

NikkiWines added 2 commits July 10, 2023 14:43

Merge branch 'main' of github.com:Expensify/App into nikki-emaildeliv…

c9495f6

…eryissue

use useLocalize instead of withLocalize

b172a23

NikkiWines added 2 commits July 10, 2023 15:27

don't use compose for single export

6239059

remove unused import

1906916

Santhosh-Sellavel reviewed Jul 11, 2023

View reviewed changes

dismiss keyboard on email delivery failure page

952892b

lint errors

b070b9b

Santhosh-Sellavel suggested changes Jul 11, 2023

View reviewed changes

add clarifying comments

019e919

Santhosh-Sellavel approved these changes Jul 11, 2023

View reviewed changes

melvin-bot bot requested a review from PauloGasparSv July 11, 2023 21:17

PauloGasparSv approved these changes Jul 12, 2023

View reviewed changes

PauloGasparSv merged commit 089cf7e into main Jul 12, 2023

PauloGasparSv deleted the nikki-emaildeliveryissue branch July 12, 2023 01:04

OSBotify mentioned this pull request Jul 13, 2023

Deploy Checklist: New Expensify 2023-07-13 #22783

Closed

53 tasks

NikkiWines mentioned this pull request Jul 14, 2023

[HOLD for payment 2023-07-18][$1000] Payment for #19508 #22910

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add EmailDeliveryFailure view #19508

Add EmailDeliveryFailure view #19508

NikkiWines commented May 24, 2023 •

edited

Loading

NikkiWines commented Jun 14, 2023

NikkiWines commented Jun 22, 2023

NikkiWines commented Jun 30, 2023

NikkiWines Jul 8, 2023

NikkiWines commented Jul 8, 2023

Santhosh-Sellavel Jul 9, 2023

NikkiWines Jul 10, 2023

NikkiWines commented Jul 10, 2023

Santhosh-Sellavel commented Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

NikkiWines commented Jul 11, 2023

Santhosh-Sellavel Jul 11, 2023

NikkiWines Jul 11, 2023

Santhosh-Sellavel left a comment

melvin-bot bot commented Jul 11, 2023

PauloGasparSv left a comment •

edited

Loading

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

Santhosh-Sellavel commented Jul 14, 2023

mountiny commented Jul 14, 2023

NikkiWines commented Jul 14, 2023

Add EmailDeliveryFailure view #19508

Add EmailDeliveryFailure view #19508

Conversation

NikkiWines commented May 24, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

NikkiWines commented Jun 14, 2023

NikkiWines commented Jun 22, 2023

NikkiWines commented Jun 30, 2023

NikkiWines Jul 8, 2023

Choose a reason for hiding this comment

NikkiWines commented Jul 8, 2023

Santhosh-Sellavel Jul 9, 2023

Choose a reason for hiding this comment

NikkiWines Jul 10, 2023

Choose a reason for hiding this comment

NikkiWines commented Jul 10, 2023

Santhosh-Sellavel commented Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

NikkiWines commented Jul 11, 2023

Santhosh-Sellavel Jul 11, 2023

Choose a reason for hiding this comment

NikkiWines Jul 11, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 11, 2023

PauloGasparSv left a comment • edited Loading

Choose a reason for hiding this comment

OSBotify commented Jul 13, 2023

OSBotify commented Jul 14, 2023

Santhosh-Sellavel commented Jul 14, 2023

mountiny commented Jul 14, 2023

NikkiWines commented Jul 14, 2023

NikkiWines commented May 24, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 11, 2023 •

edited

Loading

PauloGasparSv left a comment •

edited

Loading