-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BoundsObserver to keep tooltip over the wrapper #18782
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
70e694b
Use BoundsObserver to keep tooltip over the wrapper
cubuspl42 55b7e4a
Change how tooltip opacity is calculated
cubuspl42 225f3d1
Ensure that the tooltip is not "colliding" with itself
cubuspl42 64ed760
Merge remote-tracking branch 'upstream/main' into bounds-observer-4
cubuspl42 dc9924d
Respond to PR suggestions, part 1
cubuspl42 99faa6c
Ignore all tooltip's elements during the overlap check
cubuspl42 e85f3ad
Fix DomUtils import
cubuspl42 1e6a83a
Tooltip: Introduce "isVisible" flag
cubuspl42 e3023d5
Use `Node.contains` instead of a custom utils
cubuspl42 d50aa61
Clean up tooltip-related naming
cubuspl42 7748d2d
Fix wrapperNominalWidth used instead of wrapperMeasuredWidth
cubuspl42 e56ce29
Clean up tooltip-related naming, round 2
cubuspl42 76f6c12
Clean up tooltip-related naming, round 3
cubuspl42 8f26c99
isOverlappingAtTop: Update JSDoc to match the most recent naming
cubuspl42 b217933
Clean up tooltip-related naming, round 4
cubuspl42 bdb79c7
getTooltipStyles: Fix rootWrapperWidth used instead of tooltipWidth
cubuspl42 cd2520f
getTooltipStyles: Fix unnecessary comment change
cubuspl42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We named
wrapperStyle
totooltipwrapperStyle
to distinguish it frompointerWrapperStyle
. IMO, that was fine too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the reference is named
wrapper
🙁 I renamedwrapper
torootWrapper
andwrapperStyle
torootWrapperStyle
, trying to address both concerns