Open report for anonymous users

[marcochavezf]

The anonymous users' functionality requires these Web-E changes to be live on staging/prod. But to speed things up a bit, this PR will work even without those changes. So we can merge and deploy this PR in parallel with the Web-E changes. The Web-E changes are live on the staging server.

Details

This PR checks if the user is trying to open a chat report when they click on a link. If the URL to open contains a reportID, the app is online and the user is unauthenticated, we check if the chat report is public. If does, we create an anonymous account for the user and let them open the public room.

Fixed Issues

$ #18318

Tests

1. Sign out
2. Open a public room (like the ExpensiConX #announce room)
3. Verify you can see the announce room as an anonymous user (random email).
4. Click on Sign in or any action that should not be allowed to an unauthenticated user
5. Verify you're redirected to the signin page
6. Enter email/phone
7. Enter magic code
8. Verify you can see the public room in the LHN

Update: We're not covering Desktop atm in this PR. We'll cover it in the upcoming changes.

• Verify that no errors appear in the JS console

Offline tests

Update: I noticed the offline scenario is not working, but I will address it in a follow-up PR to avoid blocking this PR for RenderATL, so I will cross it out atm.
1. As unauthenticated user, open a public room (like the ExpensiConX #announce room)
2. Verify it's redirected to the login page
3. Enable the internet connection
5. Verify it opens the public room automatically

QA Steps

Same as test steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-26.at.17.08.45.mov

Mobile Web - Chrome

Screen.Recording.2023-05-26.at.17.17.40.mov

Mobile Web - Safari

Screen.Recording.2023-05-26.at.17.20.40.mov

Desktop

N/A

iOS

Screen.Recording.2023-05-26.at.19.22.42.mov

Android

Screen.Recording.2023-05-26.at.19.19.55.mov

[neil-marcellini]

I'll review this too since I jumped in to review the Web-E PR. First, let's update the test steps to create a public room first because the Expensiconx room won't exist in the local environment obviously.

Let's also test opening a non-public room while signed out, for completeness.

[neil-marcellini]

The online test works. I don't understand how the offline test would work since you can't navigate to a new URL when offline. I'm able to see the report as the anonymous user, but I can't comment, and when I clicked on my avatar I was signed out. When are we planning to fix those pieces?

Screen.Recording.2023-05-26.at.1.53.24.PM.mov

[marcochavezf]

The PR is ready for a final review

[mountiny]

I agree there is a few things to properly research and make sure they dont have any bad influence on performance, or in general the patter of chekcing if an action can be taken when user is anonymous (add reactions) is quite ugly, however there is probably not many ways to make it nicer.

Great job on this one @marcochavezf and thanks everyone for reviews and testing, I will now to staging

[mountiny]

@marcochavezf It would be good to follow up on this and confirm there is no detriment to app performance and how long the splashcreen shows with this change

requested changes addressed

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.20-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[mountiny]

Something does not seem to work as expected, getting this error when trying to access the public report signed out

[situchan]

Thanks @situchan, the backend changes are now live on staging if you want to test there.

@marcochavezf thanks, now I am able to test locally against staging and find bugs.

[situchan]

Something does not seem to work as expected, getting this error when trying to access the public report signed out

The root cause and solution explained in slack

[Julesssss]

This PR also seems to have introduced this regression. Confirmed locally

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Santhosh-Sellavel]

This PR causes this regression(s). We allowed to access public rooms here but didn't allow any actions that can be performed like, copy message, url, etc.

[sobitneupane]

This edge case was missed while handling the issue.

Issue: Deeplink - User is not redirected to public room if the app is already open

The issue is handled by #37664 PR.