Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disables the Button during onPress call in PressableWithFeedback #18122

Merged
merged 15 commits into from
May 12, 2023
Merged

Disables the Button during onPress call in PressableWithFeedback #18122

merged 15 commits into from
May 12, 2023

Commits on Apr 28, 2023

  1. added disabling of Button during onPress call in PressableWithFeedback

    @priyeshshah11
    priyeshshah11 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4471e8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/priyeshshah11/App into priy… 

    …eshshah11-disable-buttons
    @priyeshshah11
    priyeshshah11 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    90d9b72 View commit details
    Browse the repository at this point in the history

  3. code cleanup

    @priyeshshah11
    priyeshshah11 committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    0c045be View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. Merge branch 'main' of https://github.com/priyeshshah11/App into priy… 

    …eshshah11-disable-buttons
    @priyeshshah11
    priyeshshah11 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    fcee719 View commit details
    Browse the repository at this point in the history

  2. code cleanup

    @priyeshshah11
    priyeshshah11 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    76500fc View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. fixed hover & pressed styles

    @priyeshshah11
    priyeshshah11 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    cb06109 View commit details
    Browse the repository at this point in the history

  2. replace View with frgament

    @priyeshshah11
    priyeshshah11 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    11a0929 View commit details
    Browse the repository at this point in the history

  3. changed the pressDimValue back to 0.5 as advised by the design team

    @priyeshshah11
    priyeshshah11 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ee9e4d2 View commit details
    Browse the repository at this point in the history

  4. passing the click events down from BaseGenericPressable to fix a bug

    @priyeshshah11
    priyeshshah11 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ec2b5c2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. restricts press events when the button is disabled

    @priyeshshah11
    priyeshshah11 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e1640db View commit details
    Browse the repository at this point in the history

  2. removed passing down the disabled prop in BaseGenericPressable & fixe… 

    …d dimming effect on press when the button is disabled.
    @priyeshshah11
    priyeshshah11 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2d14e33 View commit details
    Browse the repository at this point in the history

  3. cleanup related to hover & pressed styles

    @priyeshshah11
    priyeshshah11 committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1bca5e6 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. fixes unread indicator test

    @priyeshshah11
    priyeshshah11 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    690cf59 View commit details
    Browse the repository at this point in the history

  2. Update src/components/Button/index.js 

    Co-authored-by: Manan <[email protected]>
    @priyeshshah11 @mananjadhav
    priyeshshah11 and mananjadhav authored May 3, 2023
    Configuration menu
    Copy the full SHA
    738cf17 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge branch 'main' of https://github.com/priyeshshah11/App into priy… 

    …eshshah11-disable-buttons
    @priyeshshah11
    priyeshshah11 committed May 10, 2023
    Configuration menu
    Copy the full SHA
    bba4458 View commit details
    Browse the repository at this point in the history