Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimistically generate transactions in existing IOU flows #17718

Merged
merged 92 commits into from
May 5, 2023
Merged

Optimistically generate transactions in existing IOU flows #17718

merged 92 commits into from
May 5, 2023

Commits on Apr 20, 2023

  1. Create TransactionUtils.buildOptimisticTransaction

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c94e8f4 View commit details
    Browse the repository at this point in the history

  2. Oops, add export

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5705e77 View commit details
    Browse the repository at this point in the history

  3. Make comment optional in buildOptimisticTransaction

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    962009f View commit details
    Browse the repository at this point in the history

  4. Setup transaction data w/ RBR in RequestMoney flow

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c2ab2fc View commit details
    Browse the repository at this point in the history

  5. Make transactionID required in buildOptimisticIOUAction

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8d998d9 View commit details
    Browse the repository at this point in the history

  6. Finish RequestMoney flow

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b68362d View commit details
    Browse the repository at this point in the history

  7. Implement createSplitsAndOnyxData

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a6aec7f View commit details
    Browse the repository at this point in the history

  8. Implement getPayMoneyRequestParams

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ae89202 View commit details
    Browse the repository at this point in the history

  9. Implement getSendMoneyParams

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    42ff9e4 View commit details
    Browse the repository at this point in the history

  10. Update JSDoc comment to make it clear iouTransactionID is not optional

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d997104 View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6d8d11d View commit details
    Browse the repository at this point in the history

  12. Create PusherHelper abstraction

    @roryabraham
    roryabraham committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d85e4a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Create test for requestMoney

    @roryabraham
    roryabraham committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c858075 View commit details
    Browse the repository at this point in the history

  2. Refactor fetch mock

    @roryabraham
    roryabraham committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9176a17 View commit details
    Browse the repository at this point in the history

  3. Create test for requestMoney with existing chatReport

    @roryabraham
    roryabraham committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f622e5c View commit details
    Browse the repository at this point in the history

  4. Create test for requestMoney with existing chatReport and iouReport

    @roryabraham
    roryabraham committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4b79c27 View commit details
    Browse the repository at this point in the history

  5. Add test for failing scenario

    @roryabraham
    roryabraham committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    619e5cb View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Merge branch 'main' into Rory-OptimisticTransactions

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    cb9ceed View commit details
    Browse the repository at this point in the history

  2. Remove unused PusherHelper

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    83b0bc7 View commit details
    Browse the repository at this point in the history

  3. Update TODO link

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    afda245 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Rory-OptimisticTransactions

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0fe4736 View commit details
    Browse the repository at this point in the history

  5. Upgrade Onyx to 1.0.41

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3ee3eb8 View commit details
    Browse the repository at this point in the history

  6. Remove resolved TODOS

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0a1a59b View commit details
    Browse the repository at this point in the history

  7. Fix IOUUtilsTest

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d7c84c6 View commit details
    Browse the repository at this point in the history

  8. Clarify comment on global fetch mock

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    99e89a2 View commit details
    Browse the repository at this point in the history

  9. Fix IOU split transaction amounts

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    00fbb9b View commit details
    Browse the repository at this point in the history

  10. Add test for SplitBill

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    acbedf8 View commit details
    Browse the repository at this point in the history

  11. Standardize on cents for transactions

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    12a27a9 View commit details
    Browse the repository at this point in the history

  12. Add assertions for IOU type

    @roryabraham
    roryabraham committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    f745bf6 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Add assertions for originalMessage.IOUReportID

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9511280 View commit details
    Browse the repository at this point in the history

  2. Add reportID to transaction

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    bc1cf76 View commit details
    Browse the repository at this point in the history

  3. Update SplitBill test to account for group transaction

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    a264814 View commit details
    Browse the repository at this point in the history

  4. Add comment field to optimistic transactions

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ff72d4f View commit details
    Browse the repository at this point in the history

  5. Add string formatting util

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f34a677 View commit details
    Browse the repository at this point in the history

  6. Add merchant to transactions

    @roryabraham
    roryabraham committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    bf1586f View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Merge branch 'main' into Rory-OptimisticTransactions

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    b9d960f View commit details
    Browse the repository at this point in the history

  2. iouTransactionID -> transactionID

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    6bd14d7 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c13d018 View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d2669e6 View commit details
    Browse the repository at this point in the history

  5. Fix missed lint items

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c81c126 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary NumberUtils function

    @roryabraham
    roryabraham committed May 1, 2023
    Configuration menu
    Copy the full SHA
    b9defaa View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Rename ID_DELETED to SPLIT_REPORTID

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d1dc16d View commit details
    Browse the repository at this point in the history

  2. Fix JSDoc comment in buildOptimisticIOUReportAction

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    89a57c2 View commit details
    Browse the repository at this point in the history

  3. Use StringUtils instead of one-off code

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    4f346e2 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    55d3994 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into Rory-OptimisticTransactions 

    # Conflicts:
#	src/libs/ReportUtils.js
    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    bb22ec2 View commit details
    Browse the repository at this point in the history

  6. Clarify jest comment

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    114482d View commit details
    Browse the repository at this point in the history

  7. pendingAction not pendingFields

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    2bedfa6 View commit details
    Browse the repository at this point in the history

  8. Fix comments in tests

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    d8db068 View commit details
    Browse the repository at this point in the history

  9. Fix amount / comment discrepancy

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    adb91e1 View commit details
    Browse the repository at this point in the history

  10. Move cleanup to another promise block

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    0b5f90f View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    b8181f1 View commit details
    Browse the repository at this point in the history

  12. Simplify initialization of IOUUtilsTest

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a06911f View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into Rory-OptimisticTransactions 

    # Conflicts:
#	jest/setup.js
#	package-lock.json
#	package.json
    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e935e01 View commit details
    Browse the repository at this point in the history

  14. Correct comment

    @roryabraham
    roryabraham committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3cff94b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Internationalize string formatter

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5de881a View commit details
    Browse the repository at this point in the history

  2. Localize split bill merchant

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    382e802 View commit details
    Browse the repository at this point in the history

  3. Use SET for optimistic transactions

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    50105d9 View commit details
    Browse the repository at this point in the history

  4. Change CurrencySymbolUtils to just CurrencyUtils

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d2d9ce3 View commit details
    Browse the repository at this point in the history

  5. Move some IOUUtils to CurrencyUtils

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6ca0f60 View commit details
    Browse the repository at this point in the history

  6. Create function to convert amount to smallest unit

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9256a73 View commit details
    Browse the repository at this point in the history

  7. Create convertToDisplayString function

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    422e56d View commit details
    Browse the repository at this point in the history

  8. Always use CurrencyUtils for the amount in the requestMoney flow

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4e13073 View commit details
    Browse the repository at this point in the history

  9. don't convert transaction amount

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9f14ad3 View commit details
    Browse the repository at this point in the history

  10. Always use smallest currency units for SplitBill flows

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    53791cf View commit details
    Browse the repository at this point in the history

  11. Add convertToWholeUnits function

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    164dd2b View commit details
    Browse the repository at this point in the history

  12. Standardize currency handling across the money request flow

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a968d31 View commit details
    Browse the repository at this point in the history

  13. Use CurrencyUtils.convertToDisplayString everywhere

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    296e458 View commit details
    Browse the repository at this point in the history

  14. Refactor CurrencyUtils.convertToDisplayString with USD as default cur… 

    …rency
    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    1aba2a3 View commit details
    Browse the repository at this point in the history

  15. Fix lint

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6dc9879 View commit details
    Browse the repository at this point in the history

  16. Create getLinkedTransactionID function

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    dd11c8f View commit details
    Browse the repository at this point in the history

  17. Fix typo

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    89ee785 View commit details
    Browse the repository at this point in the history

  18. Fix IOU tests

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9900bb0 View commit details
    Browse the repository at this point in the history

  19. Fix IOUUtilsTest

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    609797b View commit details
    Browse the repository at this point in the history

  20. Fix RBR for RequestMoney flow

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    80339aa View commit details
    Browse the repository at this point in the history

  21. Standardize dismissal of reportAction errors and add test coverage

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    22c4c65 View commit details
    Browse the repository at this point in the history

  22. Correctly implement DeleteReport

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9e86e64 View commit details
    Browse the repository at this point in the history

  23. Correctly implement RBR for SplitBill and SendMoney

    @roryabraham
    roryabraham committed May 3, 2023
    Configuration menu
    Copy the full SHA
    92cbd4f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Fix incorrect extra nesting of errors

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    75bffd3 View commit details
    Browse the repository at this point in the history

  2. Fix deleteReport and RBR for SplitBill

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    37b7aaa View commit details
    Browse the repository at this point in the history

  3. Remove accidentally committed code

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    a01c8b9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Rory-OptimisticTransactions 

    # Conflicts:
#	src/components/MoneyRequestConfirmationList.js
#	src/styles/styles.js
    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    558c056 View commit details
    Browse the repository at this point in the history

  5. Update IntlPolyfill to include ListFormat

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    af9c824 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into Rory-OptimisticTransactions 

    # Conflicts:
#	src/libs/ReportUtils.js
#	src/libs/actions/IOU.js
#	tests/unit/IOUUtilsTest.js
    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    e22b9db View commit details
    Browse the repository at this point in the history

  7. Fix lint errors from bad merge

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    8a51895 View commit details
    Browse the repository at this point in the history

  8. Fix IOUUtilsTest

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    28954e0 View commit details
    Browse the repository at this point in the history

  9. Fix polyfill export

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c03cb8b View commit details
    Browse the repository at this point in the history

  10. Fix Intl polyfill

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    e68b986 View commit details
    Browse the repository at this point in the history

  11. Remove debug logs

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    7a9fbbc View commit details
    Browse the repository at this point in the history

  12. Fix lint

    @roryabraham
    roryabraham committed May 4, 2023
    Configuration menu
    Copy the full SHA
    74bef77 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Update src/libs/CurrencyUtils.js 

    Co-authored-by: Carlos Martins <[email protected]>
    @roryabraham @luacmartins
    roryabraham and luacmartins authored May 5, 2023
    Configuration menu
    Copy the full SHA
    78b59bd View commit details
    Browse the repository at this point in the history

  2. Update src/libs/CurrencyUtils.js 

    Co-authored-by: Carlos Martins <[email protected]>
    @roryabraham @luacmartins
    roryabraham and luacmartins authored May 5, 2023
    Configuration menu
    Copy the full SHA
    dbf456d View commit details
    Browse the repository at this point in the history