Sort state list alphabetically #17222

PrashantMangukiya · 2023-04-10T16:49:33Z

@bondydaa @0xmiroslav PR is ready for review.

Details

State list is not sorted correctly in Spanish. So in this pr corrected that problem. So now state list shows alphabetically sorted in Spanish and English also.

Fixed Issues

$ #17080
PROPOSAL: #17080 (comment)

Tests

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

QA Steps

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome En

Web-Chrome-En.mp4

Chrome Es

Web-Chrome-Es.mp4

Android

En

Android-En.mp4

Es

Android-Es.mp4

MelvinBot · 2023-04-10T16:49:37Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

MelvinBot · 2023-04-10T16:49:40Z

@bondydaa @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiros · 2023-04-10T17:39:53Z

@bondydaa should we also sort countries list programmatically as well? I believe they were sorted already in language file but just to confirm.

PrashantMangukiya · 2023-04-10T18:32:41Z

@bondydaa should we also sort countries list programmatically as well? I believe they were sorted already in language file but just to confirm.

@0xmiroslav Country list sorting related issue is here #16060 but it was closed due to dup.

0xmiros · 2023-04-10T18:36:35Z

src/components/StatePicker.js

+        .sortBy(({stateName}) => stateName.toLowerCase())
+        .map(({stateISO, stateName}) => ({value: stateISO, label: stateName}))


let's avoid destructuring as per style guide

0xmiros · 2023-04-10T18:39:25Z

Country list sorting related issue is here #16060 but it was closed due to dup.

yeah, it's already done in language file level. I meant to sort programatically as well for safety.
btw not a blocker

0xmiros · 2023-04-10T18:56:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

0xmiros

LGTM 🎉
@bondydaa all yours

bondydaa

👍 great work

OSBotify · 2023-04-10T21:35:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-11T21:26:25Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.2.99-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-13T03:02:26Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Sort state list alphabetically

f83789a

PrashantMangukiya requested a review from a team as a code owner April 10, 2023 16:49

melvin-bot bot requested review from 0xmiros and bondydaa and removed request for a team April 10, 2023 16:49

0xmiros reviewed Apr 10, 2023

View reviewed changes

Remove object destructuring

6ea5285

0xmiros approved these changes Apr 10, 2023

View reviewed changes

bondydaa approved these changes Apr 10, 2023

View reviewed changes

bondydaa merged commit ca8886a into Expensify:main Apr 10, 2023

OSBotify mentioned this pull request Apr 11, 2023

Deploy Checklist: New Expensify 2023-04-11 #17298

Closed

26 tasks

MelvinBot mentioned this pull request Apr 13, 2023

[HOLD for payment 2023-04-20] [$1000] State in not sorted correctly in Spanish language #17080

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sort state list alphabetically #17222

Sort state list alphabetically #17222

PrashantMangukiya commented Apr 10, 2023

MelvinBot commented Apr 10, 2023

MelvinBot commented Apr 10, 2023

0xmiros commented Apr 10, 2023

PrashantMangukiya commented Apr 10, 2023

0xmiros Apr 10, 2023

PrashantMangukiya Apr 10, 2023

0xmiros commented Apr 10, 2023

0xmiros commented Apr 10, 2023

0xmiros left a comment

bondydaa left a comment

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023

		.sortBy(({stateName}) => stateName.toLowerCase())
		.map(({stateISO, stateName}) => ({value: stateISO, label: stateName}))

Sort state list alphabetically #17222

Sort state list alphabetically #17222

Conversation

PrashantMangukiya commented Apr 10, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Chrome En

Chrome Es

Safari En

Safari Es

En

Es

En

Es

En

Es

En

Es

En

Es

MelvinBot commented Apr 10, 2023

MelvinBot commented Apr 10, 2023

0xmiros commented Apr 10, 2023

PrashantMangukiya commented Apr 10, 2023

0xmiros Apr 10, 2023

Choose a reason for hiding this comment

PrashantMangukiya Apr 10, 2023

Choose a reason for hiding this comment

0xmiros commented Apr 10, 2023

0xmiros commented Apr 10, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

bondydaa left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023