[Snyk] Security upgrade cocoapods from 1.11.3 to 1.11.3 #16952

MelvinBot · 2023-04-05T01:32:06Z

This PR was automatically created by Snyk using the credentials of a real user.

Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.

Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
- Gemfile.lock

Vulnerabilities that will be fixed

With an upgrade:

Severity	Priority Score (*)	Issue	Breaking Change	Exploit Maturity
	479/1000 Why? Has a fix available, CVSS 5.3	Regular Expression Denial of Service (ReDoS) SNYK-RUBY-ACTIVESUPPORT-3237242	No	No Known Exploit
	591/1000 Why? Recently disclosed, Has a fix available, CVSS 6.1	Cross-site Scripting (XSS) SNYK-RUBY-ACTIVESUPPORT-3360028	No	No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Cross-site Scripting (XSS)

Fixed Issues

$ #17080
PROPOSAL: #17080 (comment)

Tests

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

Verify that no errors appear in the JS console

Offline tests

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

QA Steps

Go to Settings > Workspace > Connect bank account
Check State dropdown at step 2 and 3
Verify that State list is sorted alphabetically in English and Spanish both.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-3237242 - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-3360028

MelvinBot · 2023-04-05T01:32:42Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

stitesExpensify · 2023-04-10T19:22:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

stitesExpensify · 2023-04-10T19:23:32Z

Considering this prevents an XSS attack, and doesn't actually change our pod version, I think it's worth doing. I just pulled the branch and built pods without issue, so it shouldn't break anything for us

OSBotify · 2023-04-10T20:03:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-11T21:26:31Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.2.99-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-13T03:02:32Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Gemfile.lock to reduce vulnerabilities

312c00a

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-3237242 - https://snyk.io/vuln/SNYK-RUBY-ACTIVESUPPORT-3360028

MelvinBot requested a review from a team as a code owner April 5, 2023 01:32

melvin-bot bot requested review from stitesExpensify and removed request for a team April 5, 2023 01:32

stitesExpensify approved these changes Apr 10, 2023

View reviewed changes

stitesExpensify merged commit f6d8c43 into main Apr 10, 2023

stitesExpensify deleted the snyk-fix-af43c09fa081f73225837cb02b7bd9af branch April 10, 2023 19:57

OSBotify mentioned this pull request Apr 11, 2023

Deploy Checklist: New Expensify 2023-04-11 #17298

Closed

26 tasks

MelvinBot mentioned this pull request Apr 13, 2023

[HOLD for payment 2023-04-20] [$1000] State in not sorted correctly in Spanish language #17080

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snyk] Security upgrade cocoapods from 1.11.3 to 1.11.3 #16952

[Snyk] Security upgrade cocoapods from 1.11.3 to 1.11.3 #16952

MelvinBot commented Apr 5, 2023 •

edited by stitesExpensify

Loading

MelvinBot commented Apr 5, 2023

stitesExpensify commented Apr 10, 2023 •

edited

Loading

stitesExpensify commented Apr 10, 2023

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023

[Snyk] Security upgrade cocoapods from 1.11.3 to 1.11.3 #16952

[Snyk] Security upgrade cocoapods from 1.11.3 to 1.11.3 #16952

Conversation

MelvinBot commented Apr 5, 2023 • edited by stitesExpensify Loading

Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.

Changes included in this PR

Vulnerabilities that will be fixed

With an upgrade:

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 5, 2023

stitesExpensify commented Apr 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

stitesExpensify commented Apr 10, 2023

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023

MelvinBot commented Apr 5, 2023 •

edited by stitesExpensify

Loading

stitesExpensify commented Apr 10, 2023 •

edited

Loading