[MacOS Electron Popup] allow deeplink popup for all routes on mac #16869

Prince-Mendiratta · 2023-04-03T13:51:31Z

Details

With this PR, we allow all routes to new expensify to show the option to show the "Open link in New Expensify?" desktop app popup.

Specifically, these changes were brought forward to support the desktop app popup when transitioning from old expensify to new expensify via the concierge button on old expensify.

Fixed Issues

$ #16083
PROPOSAL: #16083 (comment)

Tests

We need to check for the deeplink popup when transitioning from old expensify to new expensify via the concierge button on old expensify.

It is slightly complicated to test this functionality locally since we disable the popups in dev environment. To setup the development environment, please do the following:

Checkout this PR locally.
Change the following lines to remove the environment check:

App/src/components/DeeplinkWrapper/index.website.js

Line 19 in 8b9ad23

appInstallationCheckStatus: (this.isMacOSWeb() && CONFIG.ENVIRONMENT !== CONST.ENVIRONMENT.DEV)
App/src/components/DeeplinkWrapper/index.website.js

Line 25 in 8b9ad23

if (!this.isMacOSWeb() || CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV) {

Run npm run web.
Download the production Desktop App from new.expensify.com.

To continue testing the PR,

Open expensify.com, login with account A.
Run app on localhost and login with same account.
Open the Desktop app and login with account A. You can close the app now.
Click on the concierge button at bottom right on expensify.com/inbox
Now, the thing here is that it'll redirect to new.expensify.com, which is not where we want to test. As soon as you click on the button, you'll be redirected. Try to copy the link as soon as possible. It'll be of the format:

https://new.expensify.com/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Once you copy the link, change the scheme and host to:

http://localhost:8080/transition?accountID=[REDACTED]&email=[REDACTED]&shortLivedAuthToken=[REDACTED]&encryptedAuthToken=[REDACTED]&exitTo=r%2F&shouldForceLogin=true

Ensure that you are shown the "Open app in "New Expensify" popup.

Note: Technically the concierge chat should be opened in ND but that is not the case. It is an unrelated bug to this PR and has been reported here.

Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Open staging.expensify.com, login with account A.
Open staging.new.expensify.com and login with same account.
Download and open the staging Desktop App, if you haven't already.
Click on the concierge button at bottom right on staging.expensify.com/inbox
Ensure that you are shown the "Open app in "New Expensify" popup.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Haven't uploaded videos for platform other than MacOS Web because:

The desktop app popup is available only for MacOS.
You cannot open Old dot on desktop app.

Do bring this up if you disagree.

MacOS [Web]

web1.mp4

Signed-off-by: Prince Mendiratta <[email protected]>

MelvinBot · 2023-04-03T13:51:45Z

@iwiznia @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-04-03T13:53:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane · 2023-04-03T15:34:32Z

@Prince-Mendiratta QA steps can be simplified because the concierge link on staging.expensify.com redirects to staging on new dot.

Proposed QA steps:

Download and open the staging Desktop if you haven't already.
Open staging.expensify.com and login
Click on the concierge button at bottom right on staging.expensify.com/inbox

Can you please update the OP if you agree?

rushatgabhane · 2023-04-03T15:42:48Z

@Prince-Mendiratta the test steps on dev could be simplified as well.

Make sure you have the desktop app installed
Open links like [localhost:8080, localhost:8080/settings, localhost:8080/iou/request etc] in a new browser.
Verify that you see a opne in desktop app popup

Prince-Mendiratta · 2023-04-03T15:49:36Z

@rushatgabhane

QA steps can be simplified because the concierge link on staging.expensify.com redirects to staging on new dot.

That's great, I have updated the OP description.

the test steps on dev could be simplified as well.
2. Open links like [localhost:8080, localhost:8080/settings, localhost:8080/iou/request etc] in a new browser.

I don't think we should reduce the test steps to just this, since we need to test the functionality when transitioning from Old Dot. As for the other routes, it already should work since we haven't modified anything that affects them. What do you think?

rushatgabhane · 2023-04-03T15:57:59Z

cool

Signed-off-by: Prince Mendiratta <[email protected]>

Prince-Mendiratta · 2023-04-04T19:23:29Z

@rushatgabhane looks like some quite significant changes were introduced to this component yesterday with #16043. I've tested locally and it works well but can you please take a look as well at the latest conflict resolution and confirm that the changes are aligned with the logic behind this issue and #16043 ?

cc @ntdiary @pecanoro

Signed-off-by: Prince Mendiratta <[email protected]>

Prince-Mendiratta · 2023-04-06T07:29:55Z

gentle bump @rushatgabhane

rushatgabhane

@iwiznia LGTM!

Prince-Mendiratta · 2023-04-10T13:39:39Z

Bump @iwiznia

OSBotify · 2023-04-10T22:52:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-11T21:26:13Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.2.99-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-13T03:02:14Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-09-05T15:03:23Z

src/components/DeeplinkWrapper/index.website.js

-        if (!matchedRoute) {
-            this.updateAppInstallationCheckStatus();
-            return;
-        }


This caused a regression #23409. After allowing all the routes to use the short lived auth token (which is triggered after the highlighted code snippet) the magic login link didn't work correctly because of the existed auth token (the one that that we attach to each url). Magic link only works if no auth token is supplied otherwise we'd be stuck on the account that we used on Web.

allow deeplink popup for all routes on mac

8b9ad23

Signed-off-by: Prince Mendiratta <[email protected]>

Prince-Mendiratta requested a review from a team as a code owner April 3, 2023 13:51

melvin-bot bot requested review from iwiznia and rushatgabhane and removed request for a team April 3, 2023 13:51

Prince-Mendiratta mentioned this pull request Apr 3, 2023

[PAID] [$1000] When clicking link to chat with Concierge on expensify.com, the pop up option to open the desktop app is not surfaced. #16083

Closed

6 tasks

merge main

1132fb4

Signed-off-by: Prince Mendiratta <[email protected]>

revert accidental changes to dev env checking

5e43839

Signed-off-by: Prince Mendiratta <[email protected]>

rushatgabhane approved these changes Apr 6, 2023

View reviewed changes

iwiznia approved these changes Apr 10, 2023

View reviewed changes

iwiznia merged commit 41a629d into Expensify:main Apr 10, 2023

OSBotify mentioned this pull request Apr 11, 2023

Deploy Checklist: New Expensify 2023-04-11 #17298

Closed

26 tasks

This was referenced Apr 13, 2023

[HOLD for payment 2023-07-26] [$2000] Desktop - App is show endless spinner when tap popup Open app in "New Expensify #17391

Closed

[$1000] Desktop - Deeplink from oldDot (Safari browser) do not not open Desktop App #17399

Closed

ntdiary mentioned this pull request May 29, 2023

clean up the deep link code #17452

Merged

56 tasks

s77rt reviewed Sep 5, 2023

View reviewed changes

s77rt mentioned this pull request Sep 5, 2023

[$1000] Login - User logged in with account A via magic link for account B if A logged in Web #23409

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MacOS Electron Popup] allow deeplink popup for all routes on mac #16869

[MacOS Electron Popup] allow deeplink popup for all routes on mac #16869

Prince-Mendiratta commented Apr 3, 2023 •

edited

Loading

MelvinBot commented Apr 3, 2023

rushatgabhane commented Apr 3, 2023 •

edited

Loading

rushatgabhane commented Apr 3, 2023 •

edited

Loading

rushatgabhane commented Apr 3, 2023

Prince-Mendiratta commented Apr 3, 2023

rushatgabhane commented Apr 3, 2023

Prince-Mendiratta commented Apr 4, 2023 •

edited

Loading

Prince-Mendiratta commented Apr 6, 2023

rushatgabhane left a comment

Prince-Mendiratta commented Apr 10, 2023

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023

s77rt Sep 5, 2023

[MacOS Electron Popup] allow deeplink popup for all routes on mac #16869

[MacOS Electron Popup] allow deeplink popup for all routes on mac #16869

Conversation

Prince-Mendiratta commented Apr 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 3, 2023

rushatgabhane commented Apr 3, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented Apr 3, 2023 • edited Loading

rushatgabhane commented Apr 3, 2023

Prince-Mendiratta commented Apr 3, 2023

rushatgabhane commented Apr 3, 2023

Prince-Mendiratta commented Apr 4, 2023 • edited Loading

Prince-Mendiratta commented Apr 6, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Apr 10, 2023

OSBotify commented Apr 10, 2023

OSBotify commented Apr 11, 2023

OSBotify commented Apr 13, 2023

s77rt Sep 5, 2023

Choose a reason for hiding this comment

Prince-Mendiratta commented Apr 3, 2023 •

edited

Loading

rushatgabhane commented Apr 3, 2023 •

edited

Loading

rushatgabhane commented Apr 3, 2023 •

edited

Loading

Prince-Mendiratta commented Apr 4, 2023 •

edited

Loading