Fix/large images android #16532

ArekChr · 2023-03-27T09:57:34Z

Details

Fixed Issues

$ #12893
PROPOSAL: #12893 (comment)

Tests

Go to any chat and upload a very long/large image. Example image
In the Attachment preview, tap the image to zoom
Keep zooming until you'll see that the image is blurry

Verify that no errors appear in the JS console

Offline tests

No offline tests needed

QA Steps

Go to any chat and upload a very long/large image. Example image
In the Attachment preview, tap the image to zoom
Keep zooming until you'll see that the image is blurry

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

native-ios.mov

Android

naive-android.mov

ArekChr · 2023-03-27T12:47:51Z

I found a bug; zoom-in doesn't work on mobile web chrome(android) and safari(iOS)
I can't test these platforms.

Edit: on main, there is a bug with previews at all. Previews don't open, so I can't test mobile web on the latest main branch
https://expensify.slack.com/archives/C049HHMV9SM/p1679991710703309

MelvinBot · 2023-03-30T09:35:52Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cristipaval · 2023-03-30T12:20:07Z

Hey @mananjadhav ! Could you please review this PR? I added you because you are assigned to the issue.

cristipaval · 2023-03-30T12:23:20Z

FYI @mananjadhav , there is a known bug which blocks you to test the zoom-in feature on mobile web, in case you want to test on all platforms, although the current PR is meant to fix a bug which occurs on Android native only.

francoisl · 2023-03-31T22:38:08Z

I was reading this Slack thread to get more context and it mentions creating a PR in the upstream repo, did we do that already?

francoisl · 2023-03-31T22:39:17Z

android/app/src/main/AndroidManifest.xml

@@ -10,6 +10,8 @@

    <application
      android:supportsRtl="false"
+      android:largeHeap="true"
+      android:hardwareAccelerated="false"


Just to make sure I understand correctly, why are we disabling hardware acceleration? The proposal here says:

Displaying images larger than 8k pixels will also require enabling hardware acceleration and a large heap.

@francoisl I made a mistake in the proposal. With enabled hardwareAccelerated together with largeHeap app won't display larger images over 8k pixels.

Here are details of the native error java.lang.RuntimeException: Canvas: trying to draw too large(394141296bytes) bitmap. for test image that have 11k pixels.

Got it, thanks for clarifying.

ArekChr · 2023-04-03T13:08:37Z

I was reading this Slack thread to get more context and it mentions creating a PR in the upstream repo, did we do that already?

Yes, the handling large images feature has been merged to Expensify/react-native-fast-image

francoisl · 2023-04-06T01:36:16Z

@mananjadhav any chance you can help with the testing here please?

francoisl · 2023-04-11T17:14:41Z

Sorry for the delay here. There's a conflict in package-lock.json, can you update the PR please @ArekChr?

@mananjadhav any chance you can help with the testing here please?

mananjadhav · 2023-04-11T17:52:06Z

Sure I can pick this first thing tomorrow. Quick question about the comment here ? Are we good to go ahead with the change?

@ArekChr Could you please resolve the conflicts, and I can start testing this?

ArekChr · 2023-04-12T07:08:49Z

Sure I can pick this first thing tomorrow. Quick question about the comment here ? Are we good to go ahead with the change?

@ArekChr Could you please resolve the conflicts, and I can start testing this?

Hey @mananjadhav, this comment relates to mWeb Safari and Chrome there was an issue "can not zoom-in preview in mWeb".
The PR and issue relate only to Android, and here are no blockers.

mananjadhav

Change looks fine. Testing on Android first now.

MelvinBot · 2023-04-12T13:50:51Z

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

cristipaval · 2023-04-12T13:52:37Z

Ooooh! This happens when you have too many tabs open in chrome!!! 🤦‍♂️
I mistook the PR which I was intending to merge.

@mananjadhav Could you please continue testing? Let me know if we need to revert this one.

OSBotify · 2023-04-12T13:58:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mananjadhav · 2023-04-12T14:23:41Z

I am on the testing @cristipaval

mananjadhav · 2023-04-12T14:41:14Z

I did some basic testing on Android and it seems to be working.

I am going to test this with caching and few other regression tests for images.

mananjadhav · 2023-04-12T19:01:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

ios-large-images.mp4

Android

mananjadhav · 2023-04-12T19:11:19Z

@francoisl @cristipaval Could you help with the iOS screencasts here please? I am a bit blocked on my setup and I tried a few hours but I couldn't resolve it.

OSBotify · 2023-04-13T03:43:48Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.0-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

francoisl · 2023-04-13T17:10:00Z

My iOS dev build has also been broken since the latest XCode update, but I can try from Browserstack!

mananjadhav · 2023-04-14T06:06:22Z

@francoisl this is deployed on staging, so I was able to test on my physical device using Testflight. I've uploaded the screencast in the checklist. That should be good right?

francoisl · 2023-04-14T17:03:05Z

Yep thanks. Out of curiosity, did you notice any performance regression? We had this deploy blocker opened by the QA team yesterday, I wonder if it has to do with disabling hardware acceleration.

OSBotify · 2023-04-17T22:58:14Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

cristipaval assigned cristipaval and ArekChr and unassigned cristipaval Mar 27, 2023

Beamanator mentioned this pull request Mar 27, 2023

[HOLD Expensify/react-native-fast-image#6] [$1000] Attachment preview keeps loading forever when cycle between image and pdf #16046

Closed

6 tasks

ArekChr marked this pull request as ready for review March 27, 2023 12:42

ArekChr force-pushed the fix/large_images_android branch from 3f06c90 to cc7991e Compare March 30, 2023 09:35

ArekChr requested a review from a team as a code owner March 30, 2023 09:35

melvin-bot bot requested review from francoisl and removed request for a team March 30, 2023 09:35

cristipaval requested review from cristipaval and mananjadhav March 30, 2023 12:18

cristipaval previously approved these changes Mar 30, 2023

View reviewed changes

francoisl reviewed Mar 31, 2023

View reviewed changes

ArekChr added 4 commits April 12, 2023 08:55

feat: use rnfs expensfy fork

7e7dc92

feat: use disableTransformation prop, enable largeHeap

2cffedf

fix: disable transformation

e63ef36

fix: link latest working RNFS fork

55c3af2

ArekChr dismissed cristipaval’s stale review via 55c3af2 April 12, 2023 06:56

ArekChr force-pushed the fix/large_images_android branch from cc7991e to 55c3af2 Compare April 12, 2023 06:56

mananjadhav approved these changes Apr 12, 2023

View reviewed changes

cristipaval approved these changes Apr 12, 2023

View reviewed changes

cristipaval merged commit 5fadec9 into Expensify:main Apr 12, 2023

melvin-bot bot added the Emergency label Apr 12, 2023

cristipaval removed the Emergency label Apr 12, 2023

OSBotify mentioned this pull request Apr 13, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

francoisl mentioned this pull request Apr 14, 2023

Android - Setting - Android Staging app has noticeable lag as compared to PROD #17427

Closed

6 tasks

cristipaval mentioned this pull request Apr 24, 2023

[$2000] Large image doesn't zoom well in Android and gets blurry #12893

Closed

Julesssss mentioned this pull request May 16, 2023

Revert "Fix/large images android" #19021

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/large images android #16532

Fix/large images android #16532

ArekChr commented Mar 27, 2023 •

edited by cristipaval

Loading

ArekChr commented Mar 27, 2023 •

edited

Loading

MelvinBot commented Mar 30, 2023

cristipaval commented Mar 30, 2023

cristipaval commented Mar 30, 2023

francoisl commented Mar 31, 2023

francoisl Mar 31, 2023

ArekChr Apr 3, 2023 •

edited

Loading

francoisl Apr 6, 2023

ArekChr commented Apr 3, 2023

francoisl commented Apr 6, 2023

francoisl commented Apr 11, 2023

mananjadhav commented Apr 11, 2023 •

edited

Loading

ArekChr commented Apr 12, 2023

mananjadhav left a comment

MelvinBot commented Apr 12, 2023

cristipaval commented Apr 12, 2023 •

edited

Loading

OSBotify commented Apr 12, 2023

mananjadhav commented Apr 12, 2023

mananjadhav commented Apr 12, 2023

mananjadhav commented Apr 12, 2023 •

edited

Loading

mananjadhav commented Apr 12, 2023

OSBotify commented Apr 13, 2023

francoisl commented Apr 13, 2023

mananjadhav commented Apr 14, 2023

francoisl commented Apr 14, 2023

OSBotify commented Apr 17, 2023

Fix/large images android #16532

Fix/large images android #16532

Conversation

ArekChr commented Mar 27, 2023 • edited by cristipaval Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

ArekChr commented Mar 27, 2023 • edited Loading

MelvinBot commented Mar 30, 2023

cristipaval commented Mar 30, 2023

cristipaval commented Mar 30, 2023

francoisl commented Mar 31, 2023

francoisl Mar 31, 2023

Choose a reason for hiding this comment

ArekChr Apr 3, 2023 • edited Loading

Choose a reason for hiding this comment

francoisl Apr 6, 2023

Choose a reason for hiding this comment

ArekChr commented Apr 3, 2023

francoisl commented Apr 6, 2023

francoisl commented Apr 11, 2023

mananjadhav commented Apr 11, 2023 • edited Loading

ArekChr commented Apr 12, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

MelvinBot commented Apr 12, 2023

cristipaval commented Apr 12, 2023 • edited Loading

OSBotify commented Apr 12, 2023

mananjadhav commented Apr 12, 2023

mananjadhav commented Apr 12, 2023

mananjadhav commented Apr 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Apr 12, 2023

OSBotify commented Apr 13, 2023

francoisl commented Apr 13, 2023

mananjadhav commented Apr 14, 2023

francoisl commented Apr 14, 2023

OSBotify commented Apr 17, 2023

ArekChr commented Mar 27, 2023 •

edited by cristipaval

Loading

ArekChr commented Mar 27, 2023 •

edited

Loading

ArekChr Apr 3, 2023 •

edited

Loading

mananjadhav commented Apr 11, 2023 •

edited

Loading

cristipaval commented Apr 12, 2023 •

edited

Loading

mananjadhav commented Apr 12, 2023 •

edited

Loading