Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

synchronize composer text between tabs #15610

Merged
merged 2 commits into from
Mar 6, 2023
Merged

synchronize composer text between tabs #15610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb62dd7
synchronize composer text between tabs
bernhardoj Mar 2, 2023
c8d3dcb
fix lint
bernhardoj Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pages/home/report/ReportActionCompose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,13 @@ class ReportActionCompose extends React.Component {
this.setMaxLines();
}

// Value state does not have the same value as comment props when the comment gets changed from another tab.
// In this case, we should synchronize the value between tabs.
const shouldSyncComment = prevProps.comment !== this.props.comment && this.state.value !== this.props.comment;

// As the report IDs change, make sure to update the composer comment as we need to make sure
// we do not show incorrect data in there (ie. draft of message from other report).
if (this.props.report.reportID === prevProps.report.reportID) {
if (this.props.report.reportID === prevProps.report.reportID && !shouldSyncComment) {
return;
}

Expand Down