Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle error in workspace's bank account page #15394

Merged
merged 32 commits into from
Apr 20, 2023
Merged

Handle error in workspace's bank account page #15394

merged 32 commits into from
Apr 20, 2023

Commits on Feb 23, 2023

  1. Show error in workspace's bank account page

    @aldo-expensify
    aldo-expensify committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    99df6d7 View commit details
    Browse the repository at this point in the history

  2. Disable disconnect button on pending action

    @aldo-expensify
    aldo-expensify committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    426694b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:Expensify/App into aldo_fix-disconn… 

    …ect-workspace-bankaccount
    @aldo-expensify
    aldo-expensify committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7fb58c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Move error to reimbursementAccount.errors

    @aldo-expensify
    aldo-expensify committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b64bfc3 View commit details
    Browse the repository at this point in the history

  2. Don't clear errors when reloading VBA

    @aldo-expensify
    aldo-expensify committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    814df41 View commit details
    Browse the repository at this point in the history

  3. Add red dot in avatar when error in reimbursementAccount.errors

    @aldo-expensify
    aldo-expensify committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5a2fb89 View commit details
    Browse the repository at this point in the history

  4. Add red dot in Settings when error in reimbursementAccount.errors

    @aldo-expensify
    aldo-expensify committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    c502f90 View commit details
    Browse the repository at this point in the history

  5. Add RBR error indicator in initial workspace page

    @aldo-expensify
    aldo-expensify committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5ef05fc View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Add red dot to workspaces list

    @aldo-expensify
    aldo-expensify committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    623e3a7 View commit details
    Browse the repository at this point in the history

  2. Handle errors when restarting a VBBA setup

    @aldo-expensify
    aldo-expensify committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    8aea1c2 View commit details
    Browse the repository at this point in the history

  3. Remove unused prop

    @aldo-expensify
    aldo-expensify committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    654d582 View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @aldo-expensify
    aldo-expensify committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    3e15034 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Resolve conflicts / merge with main

    @aldo-expensify
    aldo-expensify committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    0bd46f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Merge branch 'main' of github.com:Expensify/App into aldo_fix-disconn… 

    …ect-workspace-bankaccount
    @aldo-expensify
    aldo-expensify committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a93784b View commit details
    Browse the repository at this point in the history

  2. Remove pendingAction on failure

    @aldo-expensify
    aldo-expensify committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5218695 View commit details
    Browse the repository at this point in the history

  3. Recalculate state.shouldHideContinueSetupButton after pendingAction=d… 

    …elete removed
    @aldo-expensify
    aldo-expensify committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ed12f80 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Update misspell

    @aldo-expensify
    aldo-expensify committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    c1b12d0 View commit details
    Browse the repository at this point in the history

  2. Disable button if there are errors

    @aldo-expensify
    aldo-expensify committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    f9a0e34 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge branch 'main' of github.com:Expensify/App into aldo_fix-disconn… 

    …ect-workspace-bankaccount
    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    5425565 View commit details
    Browse the repository at this point in the history

  2. Update continue with setup state

    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2e0bc5d View commit details
    Browse the repository at this point in the history

  3. Update route even when showing continue/starto over button

    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    777f086 View commit details
    Browse the repository at this point in the history

  4. Fix initial step param

    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    332d464 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    81ab0f4 View commit details
    Browse the repository at this point in the history

  6. Keep url /bank-account is we get choice to continue

    @aldo-expensify
    aldo-expensify committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f51f032 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Update logic clearing errors

    @aldo-expensify
    aldo-expensify committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    6914f4c View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Fix edge cases in relation to showing options continue/start over

    @aldo-expensify
    aldo-expensify committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    c957618 View commit details
    Browse the repository at this point in the history

  2. Resolve conflicts

    @aldo-expensify
    aldo-expensify committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    42dac27 View commit details
    Browse the repository at this point in the history

  3. Style

    @aldo-expensify
    aldo-expensify committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    7e36149 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Remove unused variable 

    Co-authored-by: Abdelhafidh Belalia <[email protected]>
    @aldo-expensify @s77rt
    aldo-expensify and s77rt authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    85888a7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Merge main / Resolve conflicts

    @aldo-expensify
    aldo-expensify committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    48585ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'aldo_fix-disconnect-workspace-bankaccount' of github.co… 

    …m:Expensify/App into aldo_fix-disconnect-workspace-bankaccount
    @aldo-expensify
    aldo-expensify committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bd11b4c View commit details
    Browse the repository at this point in the history

  3. Add new line at end of file (style)

    @aldo-expensify
    aldo-expensify committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    270dc00 View commit details
    Browse the repository at this point in the history