fix: disable ios automatic extra space behavior when pasting #15051

fabioh8010 · 2023-02-10T19:09:58Z

Details

Implemented a new prop in the RN TextInput called smartInsertDelete. This prop will allow us to disable the extra space that iOS system put when we paste something inside a input like the Composer.

Two PR's were made to the upstream RN repo and Expensify RN repo respectively:

I also included a patch in this PR to address this changes and it can be removed later when we have a new RN version to use.

Fixed Issues

$ #14049
PROPOSAL: #14049 (comment)

Tests

Go to any report.
Copy the content of a message.
Paste the content inside the Composer a few times. It should not insert extra spaces before the pasted content.
Edit a message and paste something a few times. It should not insert extra spaces before the pasted content.

Offline tests

This feature doesn't change or is impacted by offline mode.

QA Steps

Same as above.

PR Author Checklist

Screenshots/Videos

Web

14049.macos.chrome.mov

14049.macos.safari.mov

Mobile Web - Chrome

14049.android.chrome.v2.mov

Mobile Web - Safari

14049.ios.safari.v2.mov

Desktop

14049.macos.desktop.mov

iOS

14049.ios.native.v2.mov

Android

14049.android.native.v2.mov

MelvinBot · 2023-02-10T19:10:07Z

@sketchydroide @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-02-10T19:10:14Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

fabioh8010 · 2023-02-10T19:10:40Z

I have read the CLA Document and I hereby sign the CLA

roryabraham

Please do not merge this PR with a patch to React Native via patch-package. We have a fork, let's use it.

mountiny

Looking good to me, but we will have to wait for the react native fork to be updated.

mananjadhav · 2023-02-13T15:12:19Z

patches/react-native+0.70.4-alpha.2.patch

@@ -0,0 +1,172 @@
+diff --git a/node_modules/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js b/node_modules/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js


As mentioned earlier, we should remove this.

This will be removed with the RN update

fabioh8010 · 2023-05-15T10:46:14Z

Hi @mountiny , I was revisiting my PRs and noticed that the issue related to this one was closed as being fixed. But the issue is not fixed in iOS yet as we can see in the following video:

Screen.Recording.2023-05-15.at.11.32.55.mov

To actually fix the issue we need to merge this PR. I can confirm that we already have the smartInsertDelete prop available to use on main branch as it is using Expensify RN 0.71.2-alpha.3, which includes this fix.

So, I just need to remove the patch from this PR and merge it to fix the issue. In the following video I added the smartInsertDelete prop in src/components/Composer/index.ios.js file on main branch to show that we can use the prop now.

Screen.Recording.2023-05-15.at.11.35.23.mov

mountiny · 2023-05-15T10:58:35Z

@fabioh8010 thanks for the heads up, I think we can keep that issue closed

Sorry I got a little bit lost on this PR, are we holding for the RN update you are working on right?

fabioh8010 · 2023-05-15T11:10:16Z

@mountiny What I mean is that the fix I did in our RN fork is already available on Expensify/App main branch, so I would just need to update this PR to remove the patch and it could be tested and merged.

PR which got merged: Expensify/react-native#40

mountiny · 2023-05-15T13:39:38Z

@fabioh8010 ah, ok then please update the PR and we can tag C+ to help with the PR testing

fabioh8010 · 2023-05-16T08:36:26Z

@mountiny Done!

mountiny · 2023-05-19T12:37:42Z

@fabioh8010 the HOLD in the title is not needed anymore right?

fabioh8010 · 2023-05-19T13:09:14Z

@mountiny Yes, we can remove the HOLD and test the PR, I removed the patch.

mananjadhav · 2023-05-21T18:34:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-copy-no-space.mov

Mobile Web - Chrome

mweb-chrome-copy-no-space.mov

Mobile Web - Safari

mweb-safari-copy-no-space.mov

Desktop

desktop-copy-no-space.mov

iOS

ios-copy-no-space.mov

Android

android-copy-no-space.mov

Thanks for the patience here. @mountiny All yours, tested this on Composer.

Addressed

mountiny

Thanks @mananjadhav !

OSBotify · 2023-05-22T13:55:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-22T23:50:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-05-25T00:22:04Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.17-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fabioh8010 requested a review from a team as a code owner February 10, 2023 19:09

melvin-bot bot requested review from mananjadhav and sketchydroide and removed request for a team February 10, 2023 19:10

mountiny assigned fabioh8010 Feb 10, 2023

roryabraham previously requested changes Feb 10, 2023

View reviewed changes

mountiny requested a review from roryabraham February 13, 2023 12:45

mountiny previously approved these changes Feb 13, 2023

View reviewed changes

mananjadhav reviewed Feb 13, 2023

View reviewed changes

mountiny changed the title ~~fix: disable ios automatic extra space behavior when pasting~~ [HOLD RN update] fix: disable ios automatic extra space behavior when pasting Feb 13, 2023

fix: disable ios automatic extra space behavior when pasting

e46d81e

fabioh8010 force-pushed the bugfix/14049 branch from 87e57a9 to e46d81e Compare May 16, 2023 08:35

Remove RN patch

38903b0

fabioh8010 dismissed mountiny’s stale review via 38903b0 May 16, 2023 08:35

mountiny changed the title ~~[HOLD RN update] fix: disable ios automatic extra space behavior when pasting~~ fix: disable ios automatic extra space behavior when pasting May 22, 2023

mountiny approved these changes May 22, 2023

View reviewed changes

mountiny merged commit 0ec61bf into Expensify:main May 22, 2023

OSBotify mentioned this pull request May 22, 2023

Deploy Checklist: New Expensify 2023-05-22 #19422

Closed

62 tasks

melvin-bot bot mentioned this pull request May 25, 2023

[HOLD for payment 2023-06-01] [HOLD for payment 2023-05-08] Clipboard copy & paste in edit messages inconsistent between app and mWeb #14049

Closed

2 tasks

fabioh8010 mentioned this pull request Dec 6, 2023

TextInput numberOfLines/maxNumberOfLines workaround (manually calculating maxHeight of TextInput #31483

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: disable ios automatic extra space behavior when pasting #15051

fix: disable ios automatic extra space behavior when pasting #15051

fabioh8010 commented Feb 10, 2023 •

edited by mountiny

Loading

MelvinBot commented Feb 10, 2023

github-actions bot commented Feb 10, 2023 •

edited

Loading

fabioh8010 commented Feb 10, 2023

roryabraham left a comment

mountiny left a comment •

edited

Loading

mananjadhav Feb 13, 2023

mountiny Feb 13, 2023

fabioh8010 commented May 15, 2023

mountiny commented May 15, 2023

fabioh8010 commented May 15, 2023 •

edited

Loading

mountiny commented May 15, 2023

fabioh8010 commented May 16, 2023

mountiny commented May 19, 2023

fabioh8010 commented May 19, 2023

mananjadhav commented May 21, 2023

mountiny left a comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

		@@ -0,0 +1,172 @@
		diff --git a/node_modules/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js b/node_modules/react-native/Libraries/Components/TextInput/RCTTextInputViewConfig.js

fix: disable ios automatic extra space behavior when pasting #15051

fix: disable ios automatic extra space behavior when pasting #15051

Conversation

fabioh8010 commented Feb 10, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 10, 2023

github-actions bot commented Feb 10, 2023 • edited Loading

fabioh8010 commented Feb 10, 2023

roryabraham left a comment

Choose a reason for hiding this comment

mountiny left a comment • edited Loading

Choose a reason for hiding this comment

mananjadhav Feb 13, 2023

Choose a reason for hiding this comment

mountiny Feb 13, 2023

Choose a reason for hiding this comment

fabioh8010 commented May 15, 2023

mountiny commented May 15, 2023

fabioh8010 commented May 15, 2023 • edited Loading

mountiny commented May 15, 2023

fabioh8010 commented May 16, 2023

mountiny commented May 19, 2023

fabioh8010 commented May 19, 2023

mananjadhav commented May 21, 2023

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented May 22, 2023

OSBotify commented May 22, 2023

OSBotify commented May 25, 2023

fabioh8010 commented Feb 10, 2023 •

edited by mountiny

Loading

github-actions bot commented Feb 10, 2023 •

edited

Loading

mountiny left a comment •

edited

Loading

fabioh8010 commented May 15, 2023 •

edited

Loading