Fix copy and paste text inconsistent on mWeb #13396

b1tjoy · 2022-12-07T15:48:32Z

Details

When we copy a multiple line message which contains whitespace in the beginning of line by our App's Copy to clipboard context menu, then long press composer textbox and paste what we copied to it on iOS Safari, whitespace in the beginning of line is missing (problem 1). If we use quick paste suggestion on GBoard to paste what we copied on Android Chrome, new line is missing (problem 2), < and > is encoded (problem 3). This PR fix problem 1.

@aldo-expensify fix problem 2 in PR Expensify/expensify-common#474 and #12968. I fix problem 3 in PR #13108. Both PRs have been merged into main branch.

Since we use Clipboard API to write data to system pasteboard, and Clipboard API is available only in secure context (https), if you test with your local ip address, you need to enable https first.

App/package.json

Line 19 in 699d469

    
           "web-server": "webpack-dev-server --open --config config/webpack/webpack.dev.js",

-     "web-server": "webpack-dev-server --open --config config/webpack/webpack.dev.js",
+     "web-server": "webpack-dev-server --open --config config/webpack/webpack.dev.js --server-type https",

Fixed Issues

$ #10262
PROPOSAL: #10262 (comment)

Tests

Launch and login to Expensify App
Open any chat
Copy multiple line of code from GitHub repo source code page, the text you copied must contain at least one line which has whitespace in the beginning of the line, and must contain < or > too
Paste the text you copied to textbox and send it as plain text rather than code block
Long press the message you just sent, open context menu
Press Copy to clipboard on context menu
Long press textbox and paste to textbox using system paste menu
Verify the text you paste, new line is not missing, whitespace in the beginning of line is not missing, < is not encoded as <, > is not encoded as >
Focus textbox and press quick paste suggestion on GBoard to paste to textbox (this step and the next one are for Android Chrome)
Verify the text you paste, new line is not missing, whitespace in the beginning of line is not missing, < is not encoded as <, > is not encoded as >

Verify that no errors appear in the JS console

Offline tests

QA Steps

Launch and login to Expensify App
Open any chat
Copy multiple line of code from GitHub repo source code page, the text you copied must contain at least one line which has whitespace in the beginning of the line, and must contain < or > too
Paste the text you copied to textbox and send it as plain text rather than code block
Long press the message you just sent, open context menu
Press Copy to clipboard on context menu
Long press textbox and paste to textbox using system paste menu
Verify the text you paste, new line is not missing, whitespace in the beginning of line is not missing, < is not encoded as <, > is not encoded as >
Focus textbox and press quick paste suggestion on GBoard to paste to textbox (this step and the next one are for Android Chrome)
Verify the text you paste, new line is not missing, whitespace in the beginning of line is not missing, < is not encoded as <, > is not encoded as >

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

macOS-Chrome-2022-12-07-220100.mp4

Mobile Web - Chrome

Android-Chrome-2022-12-07-221943.mp4

Mobile Web - Safari

iOS-Safari-2022-12-07-220527.mp4

Desktop

macOS-Desktop-2022-12-07-224349.mp4

iOS

iOS-native-2022-12-07-221319.mp4

Android

Android-native-2022-12-07-223825.mp4

melvin-bot · 2022-12-07T15:48:39Z

@pecanoro @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Clipboard/index.website.js

parasharrajat · 2022-12-08T18:17:45Z

Testing now.

parasharrajat · 2022-12-08T19:23:37Z

Screenshots

🔲 iOS / native

screen-2022-12-09_02.04.56.mp4

🔲 iOS / Safari

screen-2022-12-09_01.53.27.mp4

🔲 MacOS / Desktop

screen-2022-12-09_02.04.33.mp4

🔲 MacOS / Chrome

screen-2022-12-09_00.46.31.mp4

🔲 Android / Chrome

screen-2022-12-09_00.45.50.mp4

🔲 Android / native

screen-2022-12-09_01.02.17.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @pecanoro

🎀 👀 🎀 C+ reviewed

pecanoro · 2022-12-09T03:11:37Z

src/libs/Clipboard/index.js

+    try {
+        document.execCommand('copy');
+        // eslint-disable-next-line no-empty
+    } catch (e) {}


Any specific reason why we need an empty catch here?

I took code snippets from here, the 'copy' command can throw an error according to W3C Doc.

App/src/components/Composer/index.js

Lines 179 to 189 in 216bbe9

paste(text) {

try {

document.execCommand('insertText', false, text);

this.updateNumberOfLines();

// Pointer will go out of sight when a large paragraph is pasted on the web. Refocusing the input keeps the cursor in view.

this.textInput.blur();

this.textInput.focus();

// eslint-disable-next-line no-empty

} catch (e) {}

}

Got it! Can you add a comment explaining why then?

Done. Please review.

Can you move the comment inside the catch as discussed here? https://expensify.slack.com/archives/C01GTK53T8Q/p1670607994265879

parasharrajat · 2022-12-09T17:44:11Z

@pecanoro Let's get this merged today.

OSBotify · 2022-12-09T21:20:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-13T22:37:38Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mollfpr · 2023-02-02T12:04:13Z

Hi! Coming from this issue #14300 where this PR introduces the regression. selection.removeAllRanges(); is removed the highlight from the selection.

Thank you!

fix copy and paste text inconsistent on mWeb

5ce44dc

b1tjoy requested a review from a team as a code owner December 7, 2022 15:48

melvin-bot bot requested review from parasharrajat and pecanoro and removed request for a team December 7, 2022 15:48

b1tjoy mentioned this pull request Dec 7, 2022

[HOLD for payment 2022-12-20] [$2000] mweb - Copy & Paste - Copy & Pasting text form code editor is not consistent #10262

Closed

parasharrajat reviewed Dec 7, 2022

View reviewed changes

src/libs/Clipboard/index.website.js Outdated Show resolved Hide resolved

parasharrajat reviewed Dec 7, 2022

View reviewed changes

src/libs/Clipboard/index.website.js Outdated Show resolved Hide resolved

convert setHTMLSync to normal function and move it to index.js

4c78be6

parasharrajat previously approved these changes Dec 8, 2022

View reviewed changes

pecanoro reviewed Dec 9, 2022

View reviewed changes

add comment for empty catch

3b32ee5

b1tjoy dismissed parasharrajat’s stale review via 3b32ee5 December 9, 2022 15:49

move comment inside catch block

57e2728

pecanoro approved these changes Dec 9, 2022

View reviewed changes

pecanoro merged commit 354db82 into Expensify:main Dec 9, 2022

francoisl mentioned this pull request Dec 10, 2022

Deploy Checklist: New Expensify 2022-12-09 #13498

Closed

32 tasks

kbecciv mentioned this pull request Dec 10, 2022

Web - Chat - Pasting text using the function "Paste as plain text" adds extra blank lines #13507

Closed

mollfpr mentioned this pull request Feb 2, 2023

[HOLD for payment 2023-02-06] [$2000] Message gets unselected after user press Command + C highlighting the text #14300

Closed

1 task

parasharrajat mentioned this pull request May 19, 2023

[$1000] The mini context menu hides when the last comment of a new chat is copied on Safari #18664

Closed

6 tasks

lakchote mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-24] [$250] Room - Room mention is not copied to clipboard and editor is empty when editing room mention #40403

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix copy and paste text inconsistent on mWeb #13396

Fix copy and paste text inconsistent on mWeb #13396

b1tjoy commented Dec 7, 2022

melvin-bot bot commented Dec 7, 2022

parasharrajat commented Dec 8, 2022

parasharrajat commented Dec 8, 2022 •

edited

Loading

parasharrajat left a comment

pecanoro Dec 9, 2022

b1tjoy Dec 9, 2022

pecanoro Dec 9, 2022

b1tjoy Dec 9, 2022

pecanoro Dec 9, 2022

parasharrajat commented Dec 9, 2022

OSBotify commented Dec 9, 2022

OSBotify commented Dec 13, 2022

mollfpr commented Feb 2, 2023

	paste(text) {
	try {
	document.execCommand('insertText', false, text);
	this.updateNumberOfLines();

	// Pointer will go out of sight when a large paragraph is pasted on the web. Refocusing the input keeps the cursor in view.
	this.textInput.blur();
	this.textInput.focus();
	// eslint-disable-next-line no-empty
	} catch (e) {}
	}

Fix copy and paste text inconsistent on mWeb #13396

Fix copy and paste text inconsistent on mWeb #13396

Conversation

b1tjoy commented Dec 7, 2022

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 7, 2022

parasharrajat commented Dec 8, 2022

parasharrajat commented Dec 8, 2022 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

pecanoro Dec 9, 2022

Choose a reason for hiding this comment

b1tjoy Dec 9, 2022

Choose a reason for hiding this comment

pecanoro Dec 9, 2022

Choose a reason for hiding this comment

b1tjoy Dec 9, 2022

Choose a reason for hiding this comment

pecanoro Dec 9, 2022

Choose a reason for hiding this comment

parasharrajat commented Dec 9, 2022

OSBotify commented Dec 9, 2022

OSBotify commented Dec 13, 2022

mollfpr commented Feb 2, 2023

parasharrajat commented Dec 8, 2022 •

edited

Loading