[$500] Update the package "jest" to the latest version

[adelekennedy]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

coming from this issue https://github.com/Expensify/Expensify/issues/218314

Snyk reported a HIGH severity vulnerability in Expensify/App:package.json.

More information about this issue can be found here.

Snyk ID: SNYK-JS-JSONSCHEMA-1920922
Package: json-schema
Version: 0.2.3
Language: js
Date Introduced: 2022-07-04

from @flodnv:

$ npm list jest-cli [12:26:37]
[email protected] /Users/flo/Expensidev/App
├─┬ [email protected]
│ └── [email protected] deduped
└── [email protected]

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[greg-schroeder]

Ah yes, we should update the package "jest" to the latest version, of course

[melvin-bot]

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jeet-dhandha-lio]

https://github.com/Expensify/Expensify/issues/218314

Getting a 404 not found page on this link.

[sketchydroide]

Not sure if this is supposed to be an internal or extenal issue, asking on slack

[melvin-bot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[sibelius]

what is hard about it ?

just upgrade, fix the breaking changes and make the tests pass ?

[jboniface]

@adelekennedy this needs an upwork job when you get a chance (i unassigned myself since you were assigned to manage this in the E/E repo)

[flodnv]

@sibelius nothing hard per se (hopefully), indeed it's just about:

• Reading the changelog, figuring out problems
• Upgrading, fixing problems
• Testing everything
• Shipping it

[adelekennedy]

internal
external

[parasharrajat]

Am I eligible for compensation here? I actually created the PR #10300. I can still upgrade this if needed.

[flodnv]

Do you think we should "cut our losses" and compensate you $500, or that you should continue investigating this for a while and we'll see later?

[parasharrajat]

I am happy to keep tracking the state of the fix on the reanimated repo. Currently, I am checking it on weekly basis.

But I understand, that upgrading jest has no apparent advantage, a working version of jest should be fine.

Any decision is fine with me.

[flodnv]

Ah, ok. I guess we can keep tracking for a little while and see what happens

[parasharrajat]

There is a new PR with the fix on react-native-reanimated.

[sketchydroide]

@parasharrajat any update on this?

[parasharrajat]

The new PR is not yet merged software-mansion/react-native-reanimated#3559.

[adelekennedy]

@parasharrajat @sketchydroide I see the above PR is merged - from the above I think you're due for compensation from the work you've done - does this need to be stay open or can we pay and close?

[parasharrajat]

Thanks for the bump. Let me check the latest state of the PR and I will update you.

[adelekennedy]

@parasharrajat going through my issues before ooo, what are next steps?

[parasharrajat]

Tried the new version. There are a few errors. I will try to fix those. PR is updated to the latest.

[kevinksullivan]

👋 just want to confirm what next steps look like here. @parasharrajat there are errors with the new version, which you will fix in your existing PR? Is that accurate?

[parasharrajat]

Yes, I will try to fix those and share an update as soon as possible.

[parasharrajat]

Tried a few things but had no luck. Will look more into this later. Or I will let you know if we should close this.

[parasharrajat]

This is not blocking anything ATM. I will share an update asap. Working on some priorities.

[sketchydroide]

any update @parasharrajat, just trying to keep this updated.

[parasharrajat]

let me just check it now.

[parasharrajat]

I tried to solve the issue but unfortunately, I have no solution to the following error.

  ● Test suite failed to run

    TypeError: setImmediate is not a function

      22 | }
      23 |
    > 24 | LogBox.ignoreLogs([
         |        ^

setImmediate is directly used in RN and jsdom does not contain setImmediate. It is supported in node testEnvironment. But Tests will fail in node testEnvironment so we can't switch.

The latest changes can be seen here #10300.

Now, the jest 29 version is available which has many changes so I think there is no advantage of upgrading to jest 28.

For now, I think jest 26 is working great with the project and we don't need to upgrade as there are breaking changes.

I suggest we drop this upgrade.

[sketchydroide]

That seems ok, we might as well upgrade to the next one, and it seems everything is still working, if we need we can open it againSent from my iPhoneOn 12 Dec 2022, at 19:15, Rajat Parashar ***@***.***> wrote: I tried to solve the issue but unfortunately, I have no solution to the following error. ● Test suite failed to run TypeError: setImmediate is not a function 22 | } 23 | 24 | LogBox.ignoreLogs([ | ^ setImmediate is directly used in RN and jsdom does not contain setImmediate. It is supported in node testEnvironment. But Tests will fail in node testEnvironment so we can't switch. The latest changes can be seen here #10300. Now, the jest 29 version is available which has many changes so I think there is no advantage of upgrading to jest 28. For now, I think jest 26 is working great with the project and we don't need to upgrade as there are breaking changes. I suggest we drop this upgrade. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[sketchydroide]

That seems ok, we might as well upgrade to the next one, and it seems everything is still working, if we need we can open it again