Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA - Back button doesn't work #52536

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 14, 2024 · 10 comments
Closed
2 of 8 tasks

2FA - Back button doesn't work #52536

IuliiaHerets opened this issue Nov 14, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.62-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #51817
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch New Expensify app > Create a new workspace
  2. Go to workspace settings > Accounting.
  3. Tap Connect next to Xero.
  4. Tap Enable two-factor authentication.
  5. Tap app back button.

Expected Result:

App should navigate back to Accounting page

Actual Result:

App doesn't respond when clicking back button

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6664986_1731577161470.Screen_Recording_2024-11-14_at_12.33.25_in_the_afternoon.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 14, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 14, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 14, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Nodebrute
Copy link
Contributor

Issue not reproducible on latest main

Screen.Recording.2024-11-14.at.2.57.19.PM.mov

@hoangzinh
Copy link
Contributor

This issue will be fixed if we deploy this PR to staging #52513

cc @FitseTLT

@lakchote
Copy link
Contributor

This issue will be fixed if we deploy this PR to staging #52513

That explains why it's working on latest main. Thanks @hoangzinh @Nodebrute for early investigation.

@lakchote
Copy link
Contributor

Cherry pick requested here

@lakchote
Copy link
Contributor

Cherry pick has been deployed.

Bug not present on staging anymore cc @IuliiaHerets:

Screen.Recording.2024-11-14.at.12.21.09.mov

@IuliiaHerets
Copy link
Author

@lakchote Issue is no longer reproducible on our side too

Screen.Recording.2024-11-14.at.7.47.11.in.the.evening.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants