[$125] Copilot - Clicking outside magic code RHP does not dismiss the RHP entirely

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account settings > Security.
3. Click Add copilot.
4. Select a user > Next.
5. Select an access level > Next.
6. Click Add copilot.
7. Click outside the RHP to dismiss it.

Expected Result:

The RHP will be dismissed when clicking outside it for the first time (production behavior).

Actual Result:

The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6642180_1729610329475.20241022_231619.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850957170859734764
• Upwork Job ID: 1850957170859734764
• Last Price Increase: 2024-11-04
• Automatic offers:
• mkzie2 | Contributor | 104756037

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RHP is not dismissed when clicking outside it for the first time. It returns to copilot confirmation page.

What is the root cause of that problem?

We only hide the modal when it's closed

App/src/pages/settings/Security/AddDelegate/DelegateMagicCodeModal.tsx

Lines 36 to 38 in 3e27050

	const onBackButtonPress = () => {
	setIsValidateCodeActionModalVisible(false);
	};

What changes do you think we should make in order to solve the problem?

We should dismiss the modal if we click outside. We can add onBackdropPress to Modal here.

onBackdropPress={() => {
    Navigation.dismissModal();
}}

App/src/components/ValidateCodeActionModal/index.tsx

Line 50 in 3e27050

<Modal

OPTIONAL: We can introduce a new prop onBackdropPress in ValidateCodeActionModal and add onBackdropPress here that will dismiss the modal here and other places that use ValidateCodeActionModal and want to dismiss the modal if clicking outside.

App/src/pages/settings/Security/AddDelegate/DelegateMagicCodeModal.tsx

Line 56 in 3e27050

<ValidateCodeActionModal

What alternative solutions did you explore? (Optional)

[pecanoro]

Since this is under a beta, I am going to remove the blocker first

[melvin-bot]

@pecanoro, @OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

Opening for proposals but this one is pretty straightforward so setting bounty to $125

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850957170859734764

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

@pecanoro, @OfstadC, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[pecanoro]

@sobitneupane Please, can you review the proposals?

[OfstadC]

Bump @sobitneupane - please review proposals by EOD 😃

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@pecanoro, @OfstadC, @sobitneupane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[sobitneupane]

@mkzie2 There have been few changes in DelegateMagicCodeModal recently. Would you like to update your proposal?

Looks like the issue is reproducible for all the components using ValidateCodeActionModal. Let's make sure we handle all the cases.

We should close the modal on clicking outside but we should only go back to the previous page on the modal on pressing back button on the modal.

[mkzie2]

@sobitneupane My proposal will fix all cases in which we use ValidateCodeActionModal by adding onBackdropPress to the Modal component in ValidateCodeActionModal

onBackdropPress={() => {
    Navigation.dismissModal();
}}

[sobitneupane]

Thanks for the update @mkzie2

Proposal from @mkzie2 looks good to me. @mkzie2 Let's make sure to test all the instances where ValidateCodeActionModal is used.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignee @pecanoro is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@pecanoro @OfstadC @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[pecanoro]

Assigning @mkzie2!

[melvin-bot]

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mvtglobally]

Issue not reproducible during KI retests. (First week)