[HOLD for payment 2024-10-11] Add the workspace name to the title of the workspace chats

[davidcardoza]

Background

We’ve been discussing making the workspace name appear first in all workspace rooms to improve efficiency when identifying which company we are communicating with. The current process requires multiple clicks (#admins > #admins details > members) to see the domain of a new lead, which is inefficient. More background can be found in this Slack conversation - https://expensify.slack.com/archives/C07HPDRELLD/p1726677008605379

Design
The plan is to adda workspace name to the front of the workspca rooms, for example, "My Workspace • #admins". This will allow the workspace name to be visible without needing to click through multiple steps.

Example:

Issue Owner

Current Issue Owner: @puneetlath

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

[nyomanjyotisa]

Edited by proposal-police: This proposal was edited at 2024-09-24 02:22:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add the workspace name to the title of the workspace chats

What is the root cause of that problem?

Changes request

What changes do you think we should make in order to solve the problem?

Add the following code here to add workspace name to the report title if the chatType is policyRoom policyAnnounce policyAdmins or domainAll

    if (isUserCreatedPolicyRoom(report) || isDefaultRoom(report)){
        formattedName = report?.policyName + " • " +  report?.reportName;
    }

Additionally we can return empty string on getChatRoomSubtitle function here if we don't need to display any subtitle on the Room screen for report with chatType equals to policyRoom policyAnnounce policyAdmins or domainAll

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

New feature request

What changes do you think we should make in order to solve the problem?

1. We need to add a new condition here to add the workspace name in the title base on chatType.

    if (isUserCreatedPolicyRoom(report) || isDefaultRoom(report)) {
        formattedName = `${report?.policyName ?? ''} • ${report?.reportName ?? ''}`;
    }

App/src/libs/ReportUtils.ts

Line 3721 in ae57639

2. As I see in the design, we will not show the subtitle as the workspace name so we need to add early return empty string here

    if (isChatThread(report) || isUserCreatedPolicyRoom(report) || isDefaultRoom(report)) {
        return '';
    }

App/src/libs/ReportUtils.ts

Line 3860 in ae57639

if (isChatThread(report)) {

3. We also don't need the additional text in HeaderView here

    if (shouldShowSubtitle() || isPersonalExpenseChat || !policyName || !isEmptyObject(parentNavigationSubtitleData) || isSelfDM || ReportUtils.isUserCreatedPolicyRoom(report) || ReportUtils.isDefaultRoom(report)) {
            return null;
    }

App/src/pages/home/HeaderView.tsx

Line 112 in ae57639

const renderAdditionalText = () => {

What alternative solutions did you explore? (Optional)

[mollfpr]

@nkdengineer, your first step does not seem to be working well. It got overridden from the next condition.

App/src/libs/ReportUtils.ts

Lines 3850 to 3852 in 05ca35c

	if (isChatRoom(report) || isTaskReport(report)) {
	formattedName = report?.reportName;
	}

---

@nyomanjyotisa Almost looks good. There are a couple of things that we need to work on:

1. There's still additional text in the header view
2. Looking at the design, there's no workspace name in the welcome text
   
3. The workspace name is undefined when creating a room offline
   

---

I think we can go with @nyomanjyotisa proposal and fix the above issue while working on the PR.

🎀 👀 🎀 C+ reviewed!

[melvin-bot]

Triggered auto assignment to @mountiny, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[nkdengineer]

@mollfpr your first step does not seem to be working well. It got overridden from the next condition.

@mollfpr I see @nyomanjyotisa's proposal also uses the same condition as mine. Why did you only inform me?
And nyomanjyotisa's proposal does not cover all cases

[mollfpr]

I see @nyomanjyotisa's proposal also uses the same condition as mine. Why did you only inform me?

Their latest update proposal is come first from your proposal. Yours 03:11 UTC and theirs 02:22 UTC, I don't see anything wrong with that.

And nyomanjyotisa's proposal does not cover all cases

You're correct, but the result from your proposal wasn't close to the design either. So I don't have anything to asses.

[dubielzyk-expensify]

Default workspace names or long workspace names will clip the room name on mobile phones:

cc @Expensify/design

[dannymcclain]

Default workspace names or long workspace names will clip the room name on mobile phones

I brought this up more than once and advocated for putting the room name first, but it didn't seem like anyone outside the design team was concerned about this inevitability... Definitely feel free to bring it up again in Slack! Or we can let this play out and let people experience the issue for themselves.

[dubielzyk-expensify]

Yeah, I did the same. Let's push through then and see if this becomes a more widespread problem or not 👍

[davidcardoza]

Side note: I’d love to see the room name as a header in the LHN, with the chat preview as a subheader. I feel like this would keep the LHN way more organized and give more space for the chat preview, especially when the room name is too long.

Example:

Workspace123 - #admins
What up, this my admins chat

Workspace456 - #admins
Do you like peanut butter on your expenses?

I think a similar idea was discussed before in a thread somewhere, but nothing came of it.

[trjExpensify]

Default workspace names or long workspace names will clip the room name on mobile phones:

cc @Expensify/design

Dang, that's really not great IMO. To further illustrate the point, add a bunch of messages in those chats and you won't be able to see the name at all anywhere. Super disorientating.

[JmillsExpensify]

Woof, I'm in the same spot. I think this creates more problems than it solves.

[mountiny]

I agree that we should ensure the room name is visible at the header at all times.

[trjExpensify]

There's a thread here.

[JmillsExpensify]

Maybe we should create a new discussion thread and also revert this change until we have a holistic solution?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add the workspace name to the title of the workspace chats #49911

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment through NewDot Manual Requests
• @nyomanjyotisa requires payment (Needs manual offer from BZ)

[mountiny]

We ended up reverting this PR, but I think its fair we will pay the contributors on this one as it was product decision down the line

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[mountiny]

$250 to @mollfpr and @nyomanjyotisa

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mollfpr owed $250 via NewDot
• ROLE: @nyomanjyotisa paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@puneetlath, @mollfpr, @mountiny, @nyomanjyotisa, @dubielzyk-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[puneetlath]

@nyomanjyotisa can you link me your upwork profile?

[puneetlath]

Payment summary:

• C - $250 - @nyomanjyotisa - paid via Upwork
• C+ - $250 - @mollfpr - to be paid via NewDot

Thanks everyone!

[nyomanjyotisa]

@puneetlath here is my upwork profile https://www.upwork.com/freelancers/~0153bd482cfbf9ad36

[puneetlath]

@nyomanjyotisa offer is here. Please ping me on this issue when you've accepted.

https://www.upwork.com/nx/wm/offer/104447593

[nyomanjyotisa]

@puneetlath offer accepted

[puneetlath]

@nyomanjyotisa has been paid. @mollfpr please request on NewDot. Thanks y'all!

[garrettmknight]

$250 approved for @mollfpr