[HOLD for payment 2024-11-01] [$250] Tag rules - Tag rules are available for multi tags when the rules are not present on Old Dot

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Rules are enabled
• Dependent multi tags are set up on OD.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Tags.
3. Click on any main tag.
4. Click on any sub tag.

Expected Result:

Tag rules should not be available for multi tags (because the rules are not present on Old Dot).

Actual Result:

Tag rules are available for multi tags when the rules are not present on Old Dot.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6610082_1726848355301!Dependent_-_Multi_Level_tags_NEW.csv

Bug6610082_1726848355336.20240920_235201.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843317478267181555
• Upwork Job ID: 1843317478267181555
• Last Price Increase: 2024-10-14
• Automatic offers:
• situchan | Contributor | 104469276

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[melvin-bot]

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[deetergp]

This is behind a beta so it's not a blocker.

cc @marcaaron

[marcaaron]

I'm also slightly confused about why we don't allow approvers on multi-level tags. Maybe there's just not much overlap or it would be strange to potentially have multiple approvers? @JmillsExpensify what do you think about this one?

[marcaaron]

I'm not able to reproduce this on main fwiw. @yuwenmemon is working on tags related features for NewDot, maybe we can ask him to keep an eye on this.

[marcaaron]

maybe this has something to do with multiple policy set up with different configurations?

[IuliiaHerets]

@marcaaron Policy should be Control, you can enable Rules in More features to upgrade it

[marcaaron]

Yes. Tested with a Control policy. The provided steps do not lead to a reproduction.

[IuliiaHerets]

Issue is still reproducible, tested just now

bandicam.2024-09-20.23-07-06-209.mp4

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[deetergp]

Swapped out @parasharrajat for @situchan. Thanks for stepping up, Situ!

[situchan]

restrict the tag rule settings for multi-tags for now

So this is what we landed!

The proposal looks good. I think we can continue PR.
🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @deetergp is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[deetergp]

@rezkiy37 Proposal looks good. Adding them now.

[rezkiy37]

I've opened a PR (#50917) for review 🙂

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Restrict the tag rules settings for multiple-level tags #50917

If no regressions arise, payment will be issued on 2024-11-01. 🎊

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[situchan]

There was no regression.

Regression Test Proposal

Precondition:
The rules are enabled.
Dependent multi-tags are set up on OD.

1. Go to workspace settings > Tags.
2. Click on any main tag.
3. Click on any sub tag.
4. Verify that the tag rules should not be available for multi-tags.

[bfitzexpensify]

Payment complete, regression steps added. Closing this out, thanks everyone!