[HOLD for payment 2024-09-26] Expense - Bad grammar "You's expense(s)" instead of "Your expense(s)" in report banner

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workflows are enabled.
• Delayed submissions are enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense and avoid all the violations.
4. Go to expense report.

Expected Result:

The banner should display "Waiting for expense(s) to automatically submit on Sunday".

Actual Result:

The banner displays "Waiting for <You's> expense(s) to automatically submit on Sunday".

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6608869_1726749811266.bandicam_2024-09-19_20-36-51-692.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bad grammar "You's expense(s)" instead of "Your expense(s)" in report banner

What is the root cause of that problem?

This is what we are implementing

What changes do you think we should make in order to solve the problem?

If we do not want to add the name of use then we have to remove this

{ 
     text: `${ownerDisplayName}'s`, 
     type: 'strong', 
 }, 

form here

App/src/libs/NextStepUtils.ts

Lines 138 to 141 in 040c801

	{
	text: `${ownerDisplayName}'s`,
	type: 'strong',
	},

What alternative solutions did you explore? (Optional)

If we want to remove 's then we will remove it

App/src/libs/NextStepUtils.ts

Lines 138 to 141 in 040c801

	{
	text: `${ownerDisplayName}'s`,
	type: 'strong',
	},

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2024-09-19 14:17:12 UTC.

Proposal

Bad grammar "You's expense(s)" instead of "Your expense(s)" in report banner

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

here we dont handle the case where the ownerDisplayName resolves to "You"

App/src/libs/NextStepUtils.ts

Lines 138 to 141 in 18ce38b

	{
	text: `${ownerDisplayName}'s`,
	type: 'strong',
	},

What changes do you think we should make in order to solve the problem?

• in this case we should add a condition to check if the the ownerDisplayName is you then replace it with your and remove the 's after the your word:
• also we should take care of the translation because you changes depending on the localize language

suggested change:
import translate from useLocalize

    const {translate} = useLocalize();

optionally also we need to define the languages translations for your

then use it here:

text:  ownerDisplayName === translate('common.you')? `${translate('common.your')}`: `${ownerDisplayName }'s`,

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bad grammar "You's expense(s)" instead of "Your expense(s)" in report banner

What is the root cause of that problem?

We always add 's to the ownerDisplayName here

App/src/libs/NextStepUtils.ts

Lines 138 to 141 in 040c801

	{
	text: `${ownerDisplayName}'s`,
	type: 'strong',
	},

What changes do you think we should make in order to solve the problem?

set the text to "Your" if the the owner name is "You"

const isOwnerYou = ownerDisplayName === Localize.translateLocal('common.you');
...
            {
                text: isOwnerYou ? 'Your' : `${ownerDisplayName}'s`,
                type: 'strong',
            },

What alternative solutions did you explore? (Optional)

Base on expected result we should display "Waiting for expense(s) to automatically submit on Sunday", so we need change this to the following

    ...(!isOwnerYou ? [
        {
            text: `${ownerDisplayName}'s`,
            type: 'strong',
        },
    ] : []),

[abzokhattab]

Proposal updated

made the translation step of your as optional

[grgia]

Looking at this

[grgia]

Caused by #49315

[grgia]

https://expensify.slack.com/archives/C01GTK53T8Q/p1726754452736749

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[allgandalf]

Please assign me here, i reviewed the linked PR , thanks :) 🙏

[aldo-expensify]

Summary:

Assigned @allgandalf in the role of C+ reviewing #49482
@ishpaul777 is the author of #49482 fixing this deploy blocker

@ishpaul777 was the C+ of #49315 that introduced the regression
@aldo-expensify is the author of #49315 that introduced the regression

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fixes optimistc case and delay submission current user bad grammar #49482

If no regressions arise, payment will be issued on 2024-09-26. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

Note

No checklist here as this was a regression from some other recent PR

Only payment remaining

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@anmurali)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allgandalf]

not overdue waiting for payment

[melvin-bot]

@anmurali, @grgia, @aldo-expensify, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[anmurali]

Offer is here

[anmurali]

Paid.