[HOLD for payment 2024-11-07] QBO - Syncing is stuck at "Waiting for imported data to load"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.37-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Connect to QBO.
4. Enter credential and log in.

Expected Result:

Syncing will be completed without issue.

Actual Result:

Syncing is stuck at "Waiting for imported data to load".
It disappears after reopening Accounting tab.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6607107_1726613737077.20240918_055049.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[etCoderDysto]

Is there a credential for contributor to connect to QBO?

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Forget to add a DeployBlockerCash label

[izarutskaya]

This issue reproducible for Xero connection also. Let me know if we need to create a new GH ticket. Thank you

Bug6607542.1726654355222.Xero.Connection.Stuck.mp4

[slafortune]

I was able to successfully connect to SuccessTeam1 - In the video I don't see where you entered the credentials, just selected a company file -

2024-09-18_10-02-07.mp4

[grgia]

I got stuck on waiting for data to load but it loaded on refresh

[grgia]

I think we can at the very least demote this for now.

[arosiclair]

I only see these logs for [email protected]. The auto sync failed due to

QBO auto sync error ~~ msg: 'Refresh token is no longer valid, need to renew credentials.' code: '407' class: 'OAuthAuthenticationException'

which doesn't really match the bug report (there was no error it just appeared stuck). That was also from yesterday not today. So it looks like the email in the report is not accurate.

Syncing is stuck at "Waiting for imported data to load".
It disappears after reopening Accounting tab.

This sounds like some sync progress updates were not received. IIRC those don't use reliable updates so that may fix that issue. cc @aldo-expensify

[aldo-expensify]

This sounds like some sync progress updates were not received. IIRC those don't use reliable updates so that may fix that issue. cc @aldo-expensify

Seems like the jobDone update is the only progress update sent through reliable updates: https://github.com/Expensify/Integration-Server/blob/f0fde768b3ea60545eac564ba367bf09cff67f40/src/expensify/progress/PushOnyxUpdateProgressManager.java#L51-L53

[madmax330]

@aldo-expensify @arosiclair can one of you pick this up since you seem to know what's going on?

[arosiclair]

@aldo-expensify I think you're probably best to take it on?

[trjExpensify]

I'm not sure this is necessarily internal,

Cool, if we firm up on that, I'm sure someone from the C+ pool would be willing to do the work if they can.

[aldo-expensify]

Two things I see for now:

• When I run the integrations, I don't find any onyxUpdates in the database for the collection policyConnectionSyncProgress_<policyID>. This I think means that the jobDone for some reason is not using reliable updates as I thought, so if you miss it because you close the window it is lost forever.
• When the integration is stuck with the spinner, if you reload the window, there is not call to ReconnectApp which is what usually brings pending onyx updates. There is only a call to OpenInitialSettingsPage, but this command doesn't load pending updates. I guess this is a problem that any setting page can have.

[aldo-expensify]

Regarding the jobDone being a reliable update, we had a bug here, fixing here: https://github.com/Expensify/Auth/pull/12801

[aldo-expensify]

Easy reproduction steps:

1. Connect QBO to a workspace
2. Close the tab before the connection finishes syncing
3. Wait for a minute or more until the connecting syncing has finished
4. Reopen the tab
5. You will be left with the spinner showing like it is syncing even if it finished

Why is this happening? because of point 2 here: #49371 (comment)

The PR https://github.com/Expensify/Auth/pull/12801 was deployed and it was a necessary fix, but we still need to do something about commands like OpenInitialSettingsPage not loading missed onyx updates. I'll start a slack convo in the engineering chat after lunch to get some consensus on what to do for this case.

Asked here: https://expensify.slack.com/archives/C03TQ48KC/p1729204325866909

[aldo-expensify]

Seems like the expectation is that ReconnectApp should have been called after reopening the tab, so I'm going to investigate why it is not happening.

[aldo-expensify]

PR up: #51110 for fixing the missing calls to ReconnectApp.

@abdulrahuman5196 got assigned as reviewer (C+)

[slafortune]

Just deployed to staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add missing calls to App.confirmReadyToOpenApp #51110

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment through NewDot Manual Requests

[melvin-bot]

@abdulrahuman5196 @slafortune The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[slafortune]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[slafortune]

@abdulrahuman5196 can you please complete the checklist?

[abekkala]

bump @abdulrahuman5196

The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it.

[abdulrahuman5196]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: I don't think we have direct PR regression which caused, more like a case which wasn't found.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Connect QBO to a workspace
2. Close the tab before the connection finishes syncing
3. Wait for a minute or more until the connecting syncing has finished
4. Reopen the tab
5. You will be left with the spinner showing like it is syncing even if it finished

Do we agree 👍 or 👎

@abekkala @slafortune