[HOLD for payment SEPT 23][$250] iOS - 2FA code input is hidden by keyboard when disabling 2FA

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.28-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validation PR #48030
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Launch New Expensify app.
2. Go to Account settings > Security,
3. Tap Disable 2FA.

Expected Result:

2FA code input will not be hidden by keyboard when disabling 2FA

Actual Result:

2FA code input is hidden by keyboard when disabling 2FA

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6591193_1725320683828.ScreenRecording_09-03-2024_07-41-10_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831813205395072237
• Upwork Job ID: 1831813205395072237
• Last Price Increase: 2024-09-05
• Automatic offers:
• alitoshmatov | Reviewer | 103915601

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Julesssss]

This is a new step in the process and shouldn't block deployment, as users can still enter the code (without visible confirmation).

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2FA code is behind the keyboard.

What is the root cause of that problem?

In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button.

App/src/pages/settings/Security/TwoFactorAuth/Steps/GetCode.tsx

Lines 29 to 31 in aa69371

	<StepWrapper
	title={translate('twoFactorAuth.disableTwoFactorAuth')}
	shouldEnableKeyboardAvoidingView={false}

What changes do you think we should make in order to solve the problem?

Enable the keyboard avoiding view by removing the shouldEnableKeyboardAvoidingView prop.

[Julesssss]

In the code page, we disable the keyboard avoiding view which is required for iOS to push up the button.

It would be good to confirm there wasn't a specific reason for this before moving forward.

[parasharrajat]

I don't think there was a reason for this. Looks like a simple mistake.

[tgolen]

Ah yeah, that was just a mistake. I wasn't aware of it and it just came over with some copy/paste from one of the other views.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[ItxAltaf]

<KeyboardAvoidingView
        behavior={Platform.OS === 'ios' ? 'padding' : null}
      >
<TextInput>
</KeyboardAvoidingView>

[melvin-bot]

@Julesssss, @abekkala, @alitoshmatov Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Julesssss]

Awiating proposals and review

[alitoshmatov]

Looks straightforward fix, we can go with @bernhardoj 's proposal here

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Current assignee @Julesssss is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[bernhardoj]

PR is ready

cc: @alitoshmatov

[alitoshmatov]

Deployed to production on 16th

[abekkala]

PAYMENT SUMMARY FOR SEPT 23

• Fix: @bernhardoj [$250, if no regresssions] payment via NewDot
• PR Review: @alitoshmatov [$250, if no regresssions] Offer

[abekkala]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

---

@alitoshmatov can you complete checklist so I can issue payment - thank you!

[abekkala]

@alitoshmatov, can you complete the checklist above, please?

[abekkala]

@alitoshmatov just a friendly bump here. Please complete the checklist above and I can issue payment. (before the offer expires in Upwork)

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: Require a 2FA code to disable 2FA #48030
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48030/files#r1788965261
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug. I think no need since it wasn't regression but rather incomplete feature

[alitoshmatov]

@abekkala Sorry for late response

[abekkala]

@alitoshmatov payment sent and contract ended - thank you! 🎉

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj