[HOLD for payment 2024-09-19] [$250] Tags - App closes RHP after upgrade and clicking back button in GL code page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.25-10
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a Collect workspace.
3. Go to Categories.
4. Click on any category > GL code/Payroll code.
5. Click Upgrade > Click Got it, thanks.
6. On the code editor page, click on the app back button.
7. Note that app returns to category details RHP.
8. Create a Collect workspace.
9. Go to Tags.
10. Add a tag > Click on tag > GL code.
11. Click Upgrade > Click Got it, thanks.
12. On the code editor page, click on the app back button.

Expected Result:

App will return to tag details RHP after upgrade and clicking back button in GL code page.

Actual Result:

App closes RHP after upgrade and clicking back button in GL code page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6585134_1724841637865.20240828_183542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b3d86efe655bb313
• Upwork Job ID: 1829329439413113957
• Last Price Increase: 2024-08-30
• Automatic offers:
• ZhenjaHorbach | Reviewer | 103806540
• Krishna2323 | Contributor | 103806542

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2023-10-17T11:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

We aren't passing the fallback route to goBack.

App/src/pages/workspace/tags/TagGLCodePage.tsx

Line 68 in 392da13

onBackButtonPress={() => Navigation.goBack()}

What changes do you think we should make in order to solve the problem?

• Pass ROUTES.WORKSPACE_TAG_SETTINGS.getRoute(route.params.policyID, orderWeight, tagName) as the fallback route to the goBack function.
• We should also look for similar inconsistencies and should fix those as well.

What alternative solutions did you explore? (Optional)



Result

[abzokhattab]

Edited by proposal-police: This proposal was edited at 2023-10-11T13:45:00Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App closes RHP after upgrade and clicking back button in GL code page

What is the root cause of that problem?

• The fallback route is not passed to the goBack function in this

  App/src/pages/workspace/tags/TagGLCodePage.tsx

  Line 68 in 392da13

  onBackButtonPress={() => Navigation.goBack()}

• To resolve this, we should apply the same goBack logic in the submit logic

What changes do you think we should make in order to solve the problem?

• To ensure consistency, since the back behavior is the same for both the submit and back buttons, we should create a goBack function and use it in both locations instead of duplicating the code.
• This approach should also be applied to the CategoryPayrollCodePage.

What alternative solutions did you explore? (Optional)

N.A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b3d86efe655bb313

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

I will check proposals today or tomorrow !

[ZhenjaHorbach]

@Krishna2323 @abzokhattab

Thanks for your proposals !
Your proposals are correct but similar
So I will choose first one

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

CC: @garrettmknight @allroundexperts upgrades related!

[melvin-bot]

@stephanieelliott, @MonilBhavsar, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Hey @MonilBhavsar can you confirm the proposal selected here?

[MonilBhavsar]

Looks good!

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@ZhenjaHorbach, PR ready for review ^

[stephanieelliott]

PR was merged to main 🎉

[ZhenjaHorbach]

Looks like automation failed here, and this PR was merged in Prod #48664 on 09/09.
So we are ready for payment !

[ZhenjaHorbach]

BugZero Checklist

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

#46617

• [ @ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/46617/files#r1763836095

• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

• Create a Collect workspace.
• Go to Tags.
• Add a tag > Click on tag > GL code.
• Click Upgrade > Click Got it, thanks.
• On the code editor page, click on the app back button.
• Verify app returns to tag details RHP after upgrade and clicking back button in GL code page.

Do we agree 👍 or 👎

[ZhenjaHorbach]

@stephanieelliott
Friendly bump

[stephanieelliott]

Oop yea looks like automation didn't work, this was ready to pay out on 9/16. Setting up for payment now.

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @Krishna2323 $250 via Upwork -- PAID
• Contributor+: @ZhenjaHorbach $250 $250 via Upwork -- PAID

Upwork job is here: https://www.upwork.com/jobs/~01b3d86efe655bb313

[stephanieelliott]

Regression test issue here: https://github.com/Expensify/Expensify/issues/430822