[HOLD ON #47482][$250] Workspace switcher - Filter is not consistently applied when creating workspace from switcher

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.20-6
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Open workspace switcher.
3. Select a workspace.
4. Go to Search and then back to Inbox.
5. Open workspace switcher.
6. Click on the Create workspace button.
7. Go back to Inbox.
8. Note that the workspace switcher is reset to Expensify.
9. Go to Search.
10. Note that the workspace switcher is still the workspace selected in Step 3.
11. Go back to Inbox.
12. Now the workspace switcher changes back to the workspace selected in Step 3.

Expected Result:

The workspace switcher filter should be consistent when selecting a workspace and creating a new workspace from the workspace switcher.

Actual Result:

In Step 8. after creating a new workspace from the workspace switcher, the filter resets to Expensify.
The filter is not reset in Search page in Step 10.
When returning from Search to Inbox (Step 12), the filter reverts to the one selected in Step 3.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

20240815_135908.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0191bfdce4cbe61eaa
• Upwork Job ID: 1824021164684057828
• Last Price Increase: 2024-08-22

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0191bfdce4cbe61eaa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[jliexpensify]

I can repro - essentially, when we use the Workspace switcher a second time, it should default to the newly created workspace. Is that correct @IuliiaHerets?

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - Filter is not consistently applied when creating workspace from switcher

What is the root cause of that problem?

Before navigating we are not checking if the activeWorkspaceID is undefined or not.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Lines 86 to 100 in 65a3811

	const navigateToSearch = useCallback(() => {
	if (selectedTab === SCREENS.SEARCH.BOTTOM_TAB) {
	return;
	}
	interceptAnonymousUser(() => {
	const currentSearchParams = getCurrentSearchParams();
	if (currentSearchParams) {
	const {q, ...rest} = currentSearchParams;
	const policy = PolicyUtils.getPolicy(currentSearchParams?.policyIDs);
	Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest, policyIDs: policy ? currentSearchParams?.policyIDs : undefined}));
	return;
	}
	Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: CONST.SEARCH.TAB.EXPENSE.ALL}));
	});
	}, [selectedTab]);

What changes do you think we should make in order to solve the problem?

We can pass undefined when activeWorkspaceID is undefined.

Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest, policyIDs: policy && activeWorkspaceID ? currentSearchParams?.policyIDs : undefined}));

What alternative solutions did you explore? (Optional)

We can always use activeWorkspaceID for policyIDs.

[BhuvaneshPatil]

I am not able to reproduce it on latest main

[jliexpensify]

Bump @shubham1206agra to double-check if this can still be reproduced + proposal reviews, thanks!

[melvin-bot]

@jliexpensify, @shubham1206agra Eep! 4 days overdue now. Issues have feelings too...

[jliexpensify]

Bumping @shubham1206agra again

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@jliexpensify, @shubham1206agra 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[jliexpensify]

Hi @shubham1206agra - bump on this! Will also DM you.

[Kicu]

Hello, I wanted to point out that I have a PR ready that will significantly change how filtering by policyID will work: #47787

I'd suggest to do no work on this bug until ☝️ PR is merged, and most likely this bug will be fixed.

[melvin-bot]

@jliexpensify, @shubham1206agra 10 days overdue. I'm getting more depressed than Marvin.

[shubham1206agra]

@jliexpensify Please put this issue on hold as per #47482 (comment)

[jliexpensify]

Done!

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jliexpensify]

Looks like the other PR was deployed a while back, please retest @IuliiaHerets

[shubham1206agra]

@IuliiaHerets Bump here

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[jliexpensify]

Awesome, thanks - closing!