[PAID] [$250] The preference setting doesn’t work when navigating between chat and settings.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @suneox
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723478204237729

Action Performed:

1. Go to setting/preferences
2. Navigate to chat
3. Navigate back to setting tab
   (If issue doesn’t occur, try again few times)

Expected Result:

Setting animation should work and user can select option from preference setting.

Actual Result:

Setting animation doesn’t work and user can’t select option from preference setting.

This issue also happen on setting/security setting/about setting/Troubleshoot setting/Save the world

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-08-12.at.22.44.07.mp4

Recording.3154.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017fa6be05e532f86f
• Upwork Job ID: 1825658706975919362
• Last Price Increase: 2024-08-19
• Automatic offers:
• suneox | Contributor | 103646524
• QichenZhu | Contributor | 103646535

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[QichenZhu]

Edited by proposal-police: This proposal was edited at 2024-08-17 14:26:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pages with animated illustrations become unresponsive after switching to another page and back.

What is the root cause of that problem?

The root cause is similar to #36645 (comment).

When you switch to another page, the animated illustration keeps running in the background, adding tasks to a queue.

When you switch back, the browser has to process these tasks first, making it unresponsive to actions using the same queue, such as opening a right-side modal.

What changes do you think we should make in order to solve the problem?

Follow @hoangzinh's suggestion. The previous fix didn’t implement it because it wasn’t quite relevant to that issue, but it does resolve this issue.

Moreover, if we can combine useIsFocused and useAppState hooks, I think it would improve performance here.

App/src/components/Lottie/index.tsx

Line 36 in 7615898

if (isError || appState.isBackground || !animationFile || !isSplashHidden) {

import {useIsFocused} from '@react-navigation/native';

const isFocused = useIsFocused();
if (isError || !isFocused || appState.isBackground || !animationFile || !isSplashHidden) {

What alternative solutions did you explore? (Optional)

The drawback of the main solution is that the animated illustration disappears when the right-side modal is open. We can address this with the code below.

import {useNavigation} from '@react-navigation/native'
import NAVIGATORS from '@src/NAVIGATORS';

const [isHidden, setIsHidden] = React.useState(false);
const navigation = useNavigation();

React.useEffect(() => {
    const unsubscribe = navigation.addListener('focus', () => {
        setIsHidden(false);
    });
    return unsubscribe;
}, [navigation]);

React.useEffect(() => {
    const unsubscribe = navigation.addListener('blur', () => {
        const state = navigation.getState();
        if (state?.routes?.[state?.index ?? 0]?.name !== NAVIGATORS.RIGHT_MODAL_NAVIGATOR) {
            setIsHidden(true);
        }
    });
    return unsubscribe;
}, [navigation]);

if (isError || isHidden || appState.isBackground || !animationFile || !isSplashHidden) {

[strepanier03]

Confirmed this occurred on v9.0.22-5 after 3 tries.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017fa6be05e532f86f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[suneox]

I have raised this issue so I'd like to be a reviewer for this issue

[hungvu193]

Go ahead please @suneox 😄

[suneox]

@QichenZhu proposal LGTM, We can proceed with the primary solution.

🎀 👀 🎀 C+ reviewed

@strepanier03 Could you please assign me for reviewer? Thank you.

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @QichenZhu 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aldo-expensify]

Contributor role: @QichenZhu
C+ role: @suneox

[hungvu193]

@suneox can you please try to test it with #48040 (comment)?

[QichenZhu]

@suneox can you please try to test it with #48040 (comment)?

The animations under the backdrop can still play when a right-side modal is open because it was explicitly enabled in this line. Similarly, we could add logic to src/components/Lottie/index.tsx to allow animations to play in the background in the scenario of #48040.

[QichenZhu]

I think that's better to keep these animations to run on the background or at least when we still can see it through backdrop.

Agree. I think if you can see the animations, we should let them run. Alternatively we could replace the animation with a static frame/illustration... but that kinda feels like the juice wouldn't be worth the squeeze to me.

The problem is that sometimes playing animations in the background causes issues, and sometimes it doesn’t. Previously, when something went wrong, such as in #36645 and this issue, we added logic to src/components/Lottie/index.tsx. Ideally, though, it would be better to handle all these scenarios in a unified way.

[dubielzyk-expensify]

Agree. I think if you can see the animations, we should let them run. Alternatively we could replace the animation with a static frame/illustration... but that kinda feels like the juice wouldn't be worth the squeeze to me.

Agree with @dannymcclain here

[hungvu193]

Btw, #48283 was reverted, so I think that's ok to create another PR to cover both case. @QichenZhu

[suneox]

@QichenZhu I think we should check navigationRef.isReady() before access navigation to resolve regression issue. We're still waiting your update

[suneox]

Btw, #48283 was reverted, so I think that's ok to create another PR to cover both case. @QichenZhu

@hungvu193 The PR for this issue has been reverted on the latest main, and the PR you’re working on is still in draft. So I think we shouldn’t handle issue not ready within the scope of this issue.

[QichenZhu]

@suneox @hungvu193 I agree that it's too early to consider it at this stage, as both #48040 and our new PR #48444 are in progress. After whichever PR is merged first, I think the other side might need to retest if the issue still exists and avoid it if needed.

[hungvu193]

#48040 only updates the UI and we found this bug while testing.

[QichenZhu]

@hungvu193 Yeah, but it's tested with the old PR.

Is there a plan when #48040 will be merged?

If so, @suneox could we hold this on it?

[hungvu193]

I don't think we should hold this issue for it, please go ahead and continue with the PR, but please also fix #47273 (comment)

[suneox]

#48040 only updates the UI and we found this bug while testing.

@hungvu193 Could you please help me confirm if the reference issue doesn't occur on the latest main after revert #48283? Due to i could not find any other places showing the same behavior as the reference issue.
Thank you

[suneox]

@hungvu193 I’ve verified the new PR for this issue, and it also resolves #47273 (comment). So we will proceed without holding for your referenced issue

[suneox]

Bugzero Checklist

• [@suneox] The PR that introduced the bug has been identified. Link to the PR: Enable React concurrent mode #42592
• [@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A: Due to the offending PR is an infrastructure update.
• [@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@suneox] Determine if we should create a regression test for this bug. N/A: This issue has fixed the regression caused by the infrastructure update.

[suneox]

@strepanier03 This issue has been deployed to production two weeks ago, and the checklist is completed, so we can proceed with payment for this issue.

[suneox]

@strepanier03 Friendly bump for payment

[QichenZhu]

Gentle bump @strepanier03

[strepanier03]

Sorry for missing this one, the automation to update the title helps so much and when it fails 🤦‍♀️ it makes it tough. Handling this now.

[strepanier03]

This is paid and contracts closed. Sorry again.