[HOLD for payment 2023-08-23] Group chat - Unable to search for members when inviting group members

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to a group chat.
3. Click on the chat header.
4. Click Members.
5. Click Invite member.
6. Search with a valid term.

Expected Result:

The results are not filtered. Nothing happens after searching for a member.

Actual Result:

The relevant results will come up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564383_1723034456089.20240807_203841.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[trjExpensify]

I can repro this, not responding to the input at all:

2024-08-07_16-40-43.mp4

Looking at the deploy checklist, thinking maybe #46409? @TMisiukiewicz @adhorodyski @mkhutornyi?

[trjExpensify]

FWIW, from testing this it seems isolated to group chat > members > invite members and the bug is not on production.

[marcochavezf]

Looking at the deploy checklist, thinking maybe #46409?

Git bisect led me to the same PR #46409, creating a revert PR in a moment

[trjExpensify]

It's a pretty big PR that. Do we know why there's a problem here with the groups members page only? I'm wondering if we want to get a fix up for that, instead of a full revert.

[trjExpensify]

In fact, I think we should probably not block on this. The perf gains in the core flows (start chat, submit expense etc) aren't worth reverting for this bug in the groups members page which aren't really utilised much right now.

Removing getSearchText speeds up creating option list by around 40%. In the context of a trace provided for a linked issue, it reduces accumulated createOption time from 5.7s to 4s (~42% improvement)

So maybe we demote, and @adhorodyski @TMisiukiewicz can look into the fix as a Daily?

[TMisiukiewicz]

@trjExpensify I'll take care of it today 👍

[adamgrzybowski]

@trjExpensify me or the other Adam? 😄 @adhorodyski

[trjExpensify]

Adam H, my bad!

[adhorodyski]

haha sure thing, please see #47051 - I believe this should be enough to avoid reverting:)

[TMisiukiewicz]

PR open ✅

[trjExpensify]

Thanks, added @hoangzinh to the issue for the C+ review!

[stephanieelliott]

PR is on staging!

[stephanieelliott]

This was deployed to prod on the 16th per #47356 -- updating with payment labels!

[stephanieelliott]

Summarizing payment on this issue:

• Contributor: @TMisiukiewicz no payment due (agency)
• Contributor+: @hoangzinh $250 via Upwork - PAID

Upwork job is here: https://www.upwork.com/jobs/~01377f35a0f0d576f7

[hoangzinh]

Accepted. Thanks @stephanieelliott

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: perf: remove getSearchText function #46409
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: PR author already raised a PR to fix it [HOLD for payment 2023-08-23] Group chat - Unable to search for members when inviting group members #46972 (comment) so no need to comment on the offending PR anymore
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ⛔ I'ts a DB so I think we already have regression test for this issue.

[stephanieelliott]

Thanks @hoangzinh, all paid!