[WAITING ON CHECKLIST][$250] Workspace picker -Inconsistent Navigation After Creating Workspace on "Workspace picker"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to [staging.new.expensify.com].
2. Click on the "Workspace picker"
3. Click on the plus icon to create a new workspace.
4. Click the in-app back button.
5. Observe that you are not navigated back to the previous page.
6. Navigate to the inbox.
7. Click on the "Workspace picker"
8. Click on the plus icon to create a new workspace.
9. Click the browser’s back button.

Expected Result:

After creating a workspace from the "Workspace picker" page, the in-app back button should navigate the user back to the "Workspace picker" page, consistent with the behavior of the browser's back button.

Actual Result:

After creating a workspace from the "Workspace picker" page using the plus icon, the in-app back button fails to navigate to the workspace picker page, while the browser’s back button correctly returns the user to the "Workspace picker" page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6551272_1721804258973.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d2558fbd9a9d9b23
• Upwork Job ID: 1820632265547564333
• Last Price Increase: 2024-08-06

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d2558fbd9a9d9b23

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[jliexpensify]

Able to repro on v9.0.16-5 (staging)

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-08-06 06:56:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a workspace from the "Workspace picker" page using the plus icon, the in-app back button fails to navigate to the workspace picker page, while the browser’s back button correctly returns the user to the "Workspace picker" page.

What is the root cause of that problem?

When going back here, we just dismissModal, so it will only dismiss the workspace profile page and will not go back to the workspace switcher as it should do.

What changes do you think we should make in order to solve the problem?

We should use the accepted approach of using backTo route param to make sure the navigation is correct in these cases. (We use same approach in various scenarios, examples: there, there and there)

1. Update

   App/src/pages/workspace/WorkspaceInitialPage.tsx

   Line 396 in 6c3dcc2

   onBackButtonPress={Navigation.dismissModal}

   to go to the backTo route if there's backTo param defined.

onBackButtonPress={() => {
    if (route.params?.backTo) {
        Navigation.resetToHome();
        Navigation.navigate(route.params.backTo);
    } else {
        Navigation.dismissModal();
    }
}}

2. Update the route definition here to allow a backTo param

getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}`, backTo) as const,

3. Use the backTo param here and in createWorkspaceWithPolicyDraftAndNavigateToIt too

4. Then in here, pass the current route (or specifically ROUTES.WORKSPACE_SWITCHER) as backTo

What alternative solutions did you explore? (Optional)

In step 1 above, to navigate to backTo route we can use

Navigation.goBack(route.params.backTo, true);

[nkdengineer]

Proposal updated to add an alternation solution

[eh2077]

@nkdengineer 's proposal looks good to me. Coding details can be discussed in PR.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

❌ There was an error making the offer to @eh2077 for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @nkdengineer for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

Current assignee @eh2077 is eligible for the External assigner, not assigning anyone new.

[jliexpensify]

Hmm looks like the automation broke, I'll manually hire.

[jliexpensify]

Hired @eh2077 and @nkdengineer

[parasharrajat]

Please hold off hiring anyone while I am checking the task.

[melvin-bot]

@carlosmiceli, @jliexpensify, @eh2077, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[carlosmiceli]

What's the status here @parasharrajat?

[parasharrajat]

I noticed that the PR is merged for this issue so there is nothing we need to hold here.

[carlosmiceli]

Gotcha! Can we close this then @jliexpensify ?

[jliexpensify]

Before I do, I just want to confirm: @parasharrajat you had a PR that fixed this, so there's no need to hire and pay anyone?

I notice @nkdengineer and @eh2077 were hired, so will need to cancel these contracts if so.

[eh2077]

@jliexpensify I believe our work previously hired is legitimate for payment. And it's been overdue for quite a while

[jliexpensify]

Sorry, let's take a step back here! I want to clarify exactly what needs to be done.

Firstly, I am trying to work out what @parasharrajat means by this: #46816 (comment)

Rajat, can you clarify this comment please? Are you implying the PR was not needed to fix this issue?

Separately, @eh2077 - you and @nkdengineer worked on #46939 that resolved this issue? cc @carlosmiceli

[eh2077]

Yes, #46939 is the PR we worked on to fix this issue.

[jliexpensify]

Great, so it sounds like this is the Payment Summary and job:

• C: @nkdengineer
• C+: @eh2077

https://www.upwork.com/jobs/~01d2558fbd9a9d9b23

So @parasharrajat - I'll wait for your explanation on this before making payment: #46816 (comment)

[parasharrajat]

Actually, the PR for this issue was already merged before I was tagged on this issue. That's why I suggested we don't need to hold this issue if the work is already done here. No PR has been created or reviewed by me for this issue yet.

[jliexpensify]

Ok, thanks for clearing this one up! @eh2077 do we need a checklist here?

[jliexpensify]

Everyone has been paid, just waiting on checklist.

[jliexpensify]

Bump @eh2077 for checklist

[eh2077]

Checklist

• [@eh2077] The PR that introduced the bug has been identified. Link to the PR: I don't think there's a PR causes this bug. It's an edge case we want to polish
• [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@eh2077] Determine if we should create a regression test for this bug. Yes

Regression test

1. Click on the "Workspace picker"
2. Click on the plus icon to create a new workspace.
3. Click the in-app back button.
4. Observe that you are not navigated back to the previous page.
5. Navigate to the inbox.
6. Click on the "Workspace picker"
7. Click on the plus icon to create a new workspace.
8. Click the browser’s back button.
9. Verify that: After creating a workspace from the "Workspace picker" page, the in-app back button should navigate the user back to the "Workspace picker" page

Do you agree 👍 or 👎?