[$50] Press enter key in Survey response page doesn't go to the next step

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.16-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1722852976083389

Action Performed:

1. Go to Settings > Switch to Expensify Classic
2. Select an option in the Before you Go page and press enter
3. Verify that we go to the next step
4. On this page, enter some text and press enter key from keyboard

Expected Result:

The user should go to the next page

Actual Result:

A new line added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-08-05.at.17.16.46.mov

Recording.408.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d9a19e776870f01d
• Upwork Job ID: 1821126615691301457
• Last Price Increase: 2024-08-07
• Automatic offers:
• dukenv0307 | Contributor | 103431375
• nkdengineer | Contributor | 103432719

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dukenv0307]

I report this issue so would love to take this one as C+

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A new line is added when pressing the enter key on the exit survey response page

What is the root cause of that problem?

This text input is multiline and we don't pass shouldSubmitForm as true. So by default, a new line is added when we press on enter key

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Line 130 in 02d0d61

autoGrowHeight

What changes do you think we should make in order to solve the problem?

We should add shouldSubmitForm prop as true for this text input as we do on other pages like here, here, ...

App/src/pages/settings/ExitSurvey/ExitSurveyResponsePage.tsx

Line 124 in 02d0d61

<InputWrapper

What alternative solutions did you explore? (Optional)

[abzokhattab]

I think this is the expected behavior since the input is multiline. Therefore, it makes sense for the default behavior to go to a new line when pressing Enter.

[nkdengineer]

I don't think so. The description task and some other description fields are also multiline input and it submits the form when we press on enter key.

Screen.Recording.2024-08-05.at.23.13.46.mov

[dylanexpensify]

confirming behavior

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d9a19e776870f01d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

Upwork job price has been updated to $50

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dylanexpensify]

assigned you @dukenv0307, made lower given simplicity

[dukenv0307]

This is the very simple issue. Let's go with @nkdengineer's solution

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dylanexpensify]

pending regression period, but smooth sailing here

[rlinoz]

Deployed to prod Aug 14th #47025 (comment)

[dylanexpensify]

NICE!

[dylanexpensify]

Payment summary:

Contributor: @nkdengineer $50 via Upwork
Contributor+: @dukenv0307 $50 via NewDot

Please apply/request!

[dylanexpensify]

confirming done!

[dylanexpensify]

paid!