Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes - Tax code content is not shown until the workspace is upgraded to Control #46624

Closed
6 tasks done
m-natarajan opened this issue Jul 31, 2024 · 8 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when validating #45866
Version Number: 9.0.15-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a Collect workspace.
  3. Go to workspace settings > Taxes.
  4. Click on any tax.
  5. Note that Tax code is empty.
  6. Click on the Tax code.
  7. Click Upgrade.
  8. Note that Tax code content is only shown after upgrading to Control.

Expected Result:

in Step 5, Tax code content will be shown even if the workspace plan is Collect (production behavior).

Actual Result:

in Step 5, Tax code content is not shown until the workspace is upgraded to Control (Step 8).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6558669_1722464787662.20240801_062231.mp4

View all open jobs on GitHub

@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 31, 2024
Copy link

melvin-bot bot commented Jul 31, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@m-natarajan
Copy link
Author

We think that this bug might be related to #wave-control

@neonbhai
Copy link
Contributor

neonbhai commented Jul 31, 2024

This should be expected as noted in #45866 (comment)

we are going to hide the taxID for non control policy because it makes it look more like its behind a paywall

cc: @rushatgabhane

@rushatgabhane
Copy link
Member

this is not a bug. it is expected

@rushatgabhane
Copy link
Member

thanks for tagging @neonbhai

@brunovjk
Copy link
Contributor

brunovjk commented Aug 2, 2024

Should we create a regre test here including this scenario?

@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2024
Copy link

melvin-bot bot commented Aug 6, 2024

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

@strepanier03
Copy link
Contributor

@brunovjk - I agree we should create the reg test for this. Gonna close out this GH but feel free to comment in that other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants