Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji - Specific "♤"Emoji shows blank in popup and doesn't appear in "Frequently Used" #46496

Closed
1 of 6 tasks
lanitochka17 opened this issue Jul 30, 2024 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 30, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.14-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #45860

Action Performed:

  1. Access New Expensify app
  2. Sign into a valid account
  3. Send "♤" emoji in the composer and Highlight it with the cursor &/or check Frequently used

Expected Result:

User expects that in the popup, the "♤" is displayed but enlarged and also shows in "Frequently used" emoji section

Actual Result:

♤ does not appear in the popup and also does not appear in frequently used section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6556951_1722310591662.Specific_emoji_does_not_appear.mp4
!Does_not_show_

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 30, 2024
Copy link

melvin-bot bot commented Jul 30, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@VictoriaExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Jul 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some emojis shows blank in popup and don't appear in "Frequently Used".

What is the root cause of that problem?

We don't have a mapping for ♤ and some other emojis as well.

const emojis: PickerEmojis = [

What changes do you think we should make in order to solve the problem?

Update the mapping for missing emojis. We can get a list from the design team.

{
        name: 'example',
        code: '♤', 
},

@ShridharGoel
Copy link
Contributor

@VictoriaExpensify Can you check if this can have the external label?

@melvin-bot melvin-bot bot added the Overdue label Aug 1, 2024
@VictoriaExpensify
Copy link
Contributor

So this does look buggy but seems like a pretty low priority if it's only happening with the one emoji. I wonder if this needs to a reduced price if we decide to fix it. I'm going to look into that

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 2, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@VictoriaExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@VictoriaExpensify
Copy link
Contributor

Ok I've looked into this more. This issue actually isn't related to emoji's, it's related to ascii characters. But it's actually different to the issue being described because this actually effects all ascii characters:

image

@ShridharGoel would you interested in giving an updated proposal based on the updated problem? If not, we might just close this one out and have a new issue reopened.

@melvin-bot melvin-bot bot removed the Overdue label Aug 6, 2024
@VictoriaExpensify
Copy link
Contributor

I'm going to close this one out because the issue described is not the correct issue. Since this is very minor, closing it out seems like the right course of action.

@ShridharGoel
Copy link
Contributor

ShridharGoel commented Aug 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants