[Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
*

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create an expense
3. Go to search
4. Click on an expense from the expense list
5. Go offline

Expected Result:

There will be an offline indicator under the composer and the composer will have a bottom margin

Actual Result:

The composer does not have a bottom margin and there is no offline indicator

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6554985_1722117881417.4_5848162808948069413.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a491780ac50be9ec
• Upwork Job ID: 1817922651827967932
• Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

Production

Recording.2656.mp4

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense page composer loses bottom margin when going offline

What is the root cause of that problem?

if isOffline we set the minHeight to 0 here

App/src/pages/home/report/ReportFooter.tsx

Line 101 in 66ebb3e

const chatFooterStyles = {...styles.chatFooter, minHeight: !isOffline ? CONST.CHAT_FOOTER_MIN_HEIGHT : 0};

And we no longer show the OfflineIndicator here since we change the condition from !isSmallScreenWidth to !shouldUseNarrowLayout on this PR

App/src/pages/home/report/ReportFooter.tsx

Lines 194 to 196 in 66ebb3e

	{!shouldUseNarrowLayout && (
	<View style={styles.offlineIndicatorRow}>{shouldHideComposer && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}</View>
	)}

What changes do you think we should make in order to solve the problem?

set the minHeight to 0 only if isOffline && !shouldUseNarrowLayout

const chatFooterStyles = {...styles.chatFooter, minHeight: isOffline && !shouldUseNarrowLayout ? 0 : CONST.CHAT_FOOTER_MIN_HEIGHT};

RESULT

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Composer bottom spacing is gone when turn offline in report RHP page.

What is the root cause of that problem?

This happens after we replace isSmallScreenWidth usage with shouldUseNarrowLayout.

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Lines 496 to 504 in 3722b22

	<View
	style={[
	styles.flexRow,
	styles.justifyContentBetween,
	styles.alignItemsCenter,
	(!shouldUseNarrowLayout || (shouldUseNarrowLayout && !isOffline)) && styles.chatItemComposeSecondaryRow,
	]}
	>
	{!shouldUseNarrowLayout && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}

The chatItemComposeSecondaryRow style contains the spacing. shouldUseNarrowLayout is true in RHP and when we go offline, both of the conditions become false, so the spacing is gone.

What changes do you think we should make in order to solve the problem?

Use the previous condition by relying on isSmallScreenWidth.

(!isSmallScreenWidth || (isSmallScreenWidth && !isOffline)) && styles.chatItemComposeSecondaryRow,

The reason we have this style in composer is that in ScreenWrapper, we have an offline indicator that is shown only on a small screen. However, we still want to show the offline indicator for the report screen, whether large or small screen, because it's the central screen.

!isSmallScreenWidth makes sure the spacing is always available on the large screen. (isSmallScreenWidth && !isOffline) allows the spacing to show on the small screen, but only when online (if we show it while offline too, then there will be extra space from the ScreenWrapper offline indicator).

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a491780ac50be9ec

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[D-01576]

Proposal

Problem Description

There is an issue in the project where the container intended to display the online/offline status is not showing correctly. Specifically, instead of indicating the offline status, the container is being displayed as none.

Issue

There is no margin defined.
Instead of showing the status as offline, the container is being displayed as none.

Solution

The issue can be resolved by ensuring the container correctly shows the online/offline status.

Current Implementation

The relevant div element in the ReportActionCompose.tsx file is structured as follows:

<div data-element="View" data-source-file="ReportActionCompose.tsx" class="css-175oi2r" style="flex-direction: row; justify-content: space-between; align-items: center; height: 15px; margin-bottom: 5px; margin-top: 5px;"></div>

[melvin-bot]

📣 @Siraj01576! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[D-01576]

Proposal

Problem Description

There is an issue in the project where the container intended to display the online/offline status is not showing correctly. Specifically, instead of indicating the offline status, the container is being displayed as none.

Issue

There is no margin defined.
Instead of showing the status as offline, the container is being displayed as none.

Solution

The issue can be resolved by ensuring the container correctly shows the online/offline status.

Current Implementation

The relevant div element in the ReportActionCompose.tsx file is structured as follows:

<div data-element="View" data-source-file="ReportActionCompose.tsx" class="css-175oi2r" style="flex-direction: row; justify-content: space-between; align-items: center; height: 15px; margin-bottom: 5px; margin-top: 5px;"></div>

[mananjadhav]

Based on the comment here and the review of the proposals I still feel we should use isSmallScreenWidth. Hence @bernhardoj's proposal looks good to me.

But @bernhardoj as mentioned please import it from useResponsiveLayout and not useWindowDimensions.

[carlosmiceli]

Let's wait for @bernhardoj to confirm and I'll assign, thanks @mananjadhav :)

[bernhardoj]

please import it from useResponsiveLayout and not useWindowDimensions.

useResponsiveLayout is already imported into the file, so we will use it.

[melvin-bot]

@carlosmiceli, @mananjadhav, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[carlosmiceli]

Should I assign you @bernhardoj ?

[bernhardoj]

Yes, please

[bernhardoj]

PR is ready

cc: @mananjadhav

[isabelastisser]

It looks like PR was not merged yet. Waiting!

[mananjadhav]

This was deployed to production 5 days ago. This should be ready for payout by 09/06.

[isabelastisser]

Thanks for the update!

[mananjadhav]

We linked the offending PR here but this is more of an edge case. We still use the isSmallScreenWidth.

Also I think we don't need a regression test for this one. @carlosmiceli wdyt?

@isabelastisser This is ready for payout. Can you please post a payout summary for this one?

[carlosmiceli]

@mananjadhav Yeah, no need for regression test here!

[isabelastisser]

Payment summary:

@mananjadhav, $250 for C+ review. Payment via NewDot
@bernhardoj, $250 for Contributor proposal - Payment via NewDot.

[isabelastisser]

All set!

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[garrettmknight]

$250 approved for @mananjadhav